Completed
Push — master ( 7946fe...187872 )
by Craig
06:44
created
system/CategoriesModule/DependencyInjection/ZikulaCategoriesExtension.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
      */
27 27
     public function load(array $configs, ContainerBuilder $container)
28 28
     {
29
-        $loader = new YamlFileLoader($container, new FileLocator(realpath(__DIR__.'/../Resources/config')));
29
+        $loader = new YamlFileLoader($container, new FileLocator(realpath(__DIR__ . '/../Resources/config')));
30 30
 
31 31
         $loader->load('services.yml');
32 32
         $loader->load('helpers.yml');
Please login to merge, or discard this patch.
src/system/CategoriesModule/Form/Type/CategoryType.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
                 'mapped' => false,
92 92
                 'required' => false
93 93
             ])
94
-            ->addEventListener(FormEvents::SUBMIT, function (FormEvent $event) use ($options) {
94
+            ->addEventListener(FormEvents::SUBMIT, function(FormEvent $event) use ($options) {
95 95
                 // ensure all locales have a display name
96 96
                 /** @var CategoryEntity $category */
97 97
                 $category = $event->getData();
@@ -109,10 +109,10 @@  discard block
 block discarded – undo
109 109
         $builder->get('name')
110 110
             ->addModelTransformer(new CallbackTransformer(
111 111
                 // remove slash from name before persistence to prevent issues with path
112
-                function ($string) {
112
+                function($string) {
113 113
                     return $string;
114 114
                 },
115
-                function ($string) {
115
+                function($string) {
116 116
                     return str_replace('/', '/', $string);
117 117
                 }
118 118
             ))
Please login to merge, or discard this patch.
src/system/CategoriesModule/Form/Type/CategoriesType.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -57,10 +57,10 @@  discard block
 block discarded – undo
57 57
 
58 58
         /** @var CategoryRegistryEntity[] $registries */
59 59
         foreach ($registries as $registry) {
60
-            $queryBuilderClosure = function (CategoryRepositoryInterface $repo) use ($registry, $options) {
60
+            $queryBuilderClosure = function(CategoryRepositoryInterface $repo) use ($registry, $options) {
61 61
                 return $repo->getChildrenQueryBuilder($registry->getCategory(), $options['direct']);
62 62
             };
63
-            $choiceLabelClosure = function (CategoryEntity $category) use ($registry) {
63
+            $choiceLabelClosure = function(CategoryEntity $category) use ($registry) {
64 64
                 $indent = str_repeat('--', $category->getLvl() - $registry->getCategory()->getLvl() - 1);
65 65
 
66 66
                 return (!empty($indent) ? '|' : '') . $indent . $category->getName();
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
         $resolver->setAllowedTypes('entityCategoryClass', 'string');
120 120
         $resolver->setAllowedTypes('em', [ObjectManager::class, 'null']);
121 121
 
122
-        $resolver->addAllowedValues('entityCategoryClass', function ($value) {
122
+        $resolver->addAllowedValues('entityCategoryClass', function($value) {
123 123
             return is_subclass_of($value, AbstractCategoryAssignment::class);
124 124
         });
125 125
     }
Please login to merge, or discard this patch.
src/system/CategoriesModule/Controller/NodeController.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
                 $newCategory->setName($category->getName() . 'copy');
55 55
                 $displayNames = [];
56 56
                 foreach ($newCategory->getDisplay_name() as $locale => $displayName) {
57
-                    $displayNames[$locale] = $displayName . ' ' .$this->__('copy');
57
+                    $displayNames[$locale] = $displayName . ' ' . $this->__('copy');
58 58
                 }
59 59
                 $newCategory->setDisplay_name($displayNames);
60 60
                 $action = 'edit';
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -70,7 +70,8 @@
 block discarded – undo
70 70
                         $parent = $repo->find($parentId);
71 71
                         $category->setParent($parent);
72 72
                         $category->setRoot($parent->getRoot());
73
-                    } elseif (empty($parent) && $request->request->has('after')) { // sibling of top-level child
73
+                    } elseif (empty($parent) && $request->request->has('after')) {
74
+// sibling of top-level child
74 75
                         $sibling = $repo->find($request->request->get('after'));
75 76
                         $category->setParent($sibling->getParent());
76 77
                         $category->setRoot($sibling->getRoot());
Please login to merge, or discard this patch.
src/system/CategoriesModule/Controller/CategoryController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
         return [
80 80
             'decorate' => true,
81 81
             'html' => true,
82
-            'childOpen' => function ($node) {
82
+            'childOpen' => function($node) {
83 83
                 $jsTreeData = [];
84 84
                 $jsTreeData['disabled'] = $node['status'] != 'A';
85 85
                 $jsTreeData['type'] = $node['is_leaf'] ? 'leaf' : 'default';
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
 
88 88
                 return '<li ' . $jsTreeData . 'class="jstree-open" id="' . $this->domTreeNodePrefix . $node['id'] . '">';
89 89
             },
90
-            'nodeDecorator' => function ($node) use ($locale) {
90
+            'nodeDecorator' => function($node) use ($locale) {
91 91
                 $displayName = isset($node['display_name'][$locale]) ? $node['display_name'][$locale] : $node['name'];
92 92
                 $title = ' title="' . $this->createTitleAttribute($node, $displayName, $locale) . '"';
93 93
                 $classes = [];
Please login to merge, or discard this patch.
src/lib/Zikula/Bundle/HookBundle/Controller/HookController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
                 }
209 209
 
210 210
                 // does the user have admin permissions on the provider module?
211
-                if (!$this->get('zikula_permissions_module.api.permission')->hasPermission($hookproviders[$i]['name']."::", '::', ACCESS_ADMIN)) {
211
+                if (!$this->get('zikula_permissions_module.api.permission')->hasPermission($hookproviders[$i]['name'] . "::", '::', ACCESS_ADMIN)) {
212 212
                     unset($hookproviders[$i]);
213 213
                     continue;
214 214
                 }
@@ -292,7 +292,7 @@  discard block
 block discarded – undo
292 292
         if (!$this->get('kernel')->isBundle($subscriber)) {
293 293
             throw new \RuntimeException($this->get('translator.default')->__f('Subscriber module "%s" is not available.', $subscriber));
294 294
         }
295
-        if (!$this->get('zikula_permissions_module.api.permission')->hasPermission($subscriber.'::', '::', ACCESS_ADMIN)) {
295
+        if (!$this->get('zikula_permissions_module.api.permission')->hasPermission($subscriber . '::', '::', ACCESS_ADMIN)) {
296 296
             throw new AccessDeniedException();
297 297
         }
298 298
 
@@ -310,7 +310,7 @@  discard block
 block discarded – undo
310 310
         if (!$this->get('kernel')->isBundle($provider)) {
311 311
             throw new \RuntimeException($this->get('translator.default')->__f('Provider module "%s" is not available.', $provider));
312 312
         }
313
-        if (!$this->get('zikula_permissions_module.api.permission')->hasPermission($provider.'::', '::', ACCESS_ADMIN)) {
313
+        if (!$this->get('zikula_permissions_module.api.permission')->hasPermission($provider . '::', '::', ACCESS_ADMIN)) {
314 314
             throw new AccessDeniedException();
315 315
         }
316 316
 
@@ -372,7 +372,7 @@  discard block
 block discarded – undo
372 372
         if (!$this->get('kernel')->isBundle($subscriber)) {
373 373
             throw new \RuntimeException($this->get('translator.default')->__f('Subscriber module "%s" is not available.', $subscriber));
374 374
         }
375
-        if (!$this->get('zikula_permissions_module.api.permission')->hasPermission($subscriber.'::', '::', ACCESS_ADMIN)) {
375
+        if (!$this->get('zikula_permissions_module.api.permission')->hasPermission($subscriber . '::', '::', ACCESS_ADMIN)) {
376 376
             throw new AccessDeniedException();
377 377
         }
378 378
 
Please login to merge, or discard this patch.
src/system/RoutesModule/Listener/InstallerListener.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,6 @@
 block discarded – undo
49 49
     /**
50 50
      * InstallerListener constructor.
51 51
      *
52
-     * @param ObjectManager $objectManager
53 52
      */
54 53
     public function __construct(
55 54
         CacheClearer $cacheClearer,
Please login to merge, or discard this patch.
src/system/RoutesModule/Form/Handler/Route/EditHandler.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -63,8 +63,8 @@
 block discarded – undo
63 63
     {
64 64
         $entity = $this->entityRef;
65 65
 
66
-        list($controller, ) = $this->sanitizeHelper->sanitizeController($entity['controller']);
67
-        list($action, ) = $this->sanitizeHelper->sanitizeAction($entity['action']);
66
+        list($controller,) = $this->sanitizeHelper->sanitizeController($entity['controller']);
67
+        list($action,) = $this->sanitizeHelper->sanitizeAction($entity['action']);
68 68
 
69 69
         $entity['controller'] = $controller;
70 70
         $entity['action'] = $action;
Please login to merge, or discard this patch.
src/system/SearchModule/Twig/TwigExtension.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
     /**
80 80
      * Returns a list of custom Twig functions.
81 81
      *
82
-     * @return array
82
+     * @return \Twig_SimpleFunction[]
83 83
      */
84 84
     public function getFunctions()
85 85
     {
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
     /**
97 97
      * Returns a list of custom Twig filters.
98 98
      *
99
-     * @return array
99
+     * @return \Twig_SimpleFilter[]
100 100
      */
101 101
     public function getFilters()
102 102
     {
Please login to merge, or discard this patch.