zikula / core

src/system/RoutesModule/Helper/Base/AbstractCollectionFilterHelper.php

Indentation +6 added lines, -6 removed lines

@@ -171,14 +171,14 @@ 
                 if ((!is_numeric($v) && $v != '') || (is_numeric($v) && $v > 0)) {
                     if ($k == 'workflowState' && substr($v, 0, 1) == '!') {
                         $qb->andWhere('tbl.' . $k . ' != :' . $k)
-                           ->setParameter($k, substr($v, 1, strlen($v)-1));
+                            ->setParameter($k, substr($v, 1, strlen($v)-1));
                     } elseif (substr($v, 0, 1) == '%') {
                         $qb->andWhere('tbl.' . $k . ' LIKE :' . $k)
-                           ->setParameter($k, '%' . $v . '%');
+                            ->setParameter($k, '%' . $v . '%');
                     } else {
                         $qb->andWhere('tbl.' . $k . ' = :' . $k)
-                           ->setParameter($k, $v);
-                   }
+                            ->setParameter($k, $v);
+                    }
                 }
             }
         }
@@ -282,10 +282,10 @@ 
     
         if (is_array($userId)) {
             $qb->andWhere('tbl.createdBy IN (:userIds)')
-               ->setParameter('userIds', $userId);
+                ->setParameter('userIds', $userId);
         } else {
             $qb->andWhere('tbl.createdBy = :userId')
-               ->setParameter('userId', $userId);
+                ->setParameter('userId', $userId);
         }
     
         return $qb;

Spacing +1 added lines, -1 removed lines

@@ -171,7 +171,7 @@
                 if ((!is_numeric($v) && $v != '') || (is_numeric($v) && $v > 0)) {
                     if ($k == 'workflowState' && substr($v, 0, 1) == '!') {
                         $qb->andWhere('tbl.' . $k . ' != :' . $k)
-                           ->setParameter($k, substr($v, 1, strlen($v)-1));
+                           ->setParameter($k, substr($v, 1, strlen($v) - 1));
                     } elseif (substr($v, 0, 1) == '%') {
                         $qb->andWhere('tbl.' . $k . ' LIKE :' . $k)
                            ->setParameter($k, '%' . $v . '%');

Unused Use Statements -2 removed lines

@@ -17,8 +17,6 @@
 use Symfony\Component\HttpFoundation\RequestStack;
 use Zikula\UsersModule\Api\ApiInterface\CurrentUserApiInterface;
 use Zikula\UsersModule\Constant as UsersConstant;
-use Zikula\RoutesModule\Entity\RouteEntity;
-use Zikula\RoutesModule\Entity\Factory\RoutesFactory;
 
 /**
  * Entity collection filter helper base class.

src/system/PermissionsModule/Tests/Api/PermissionApiTest.php

Spacing +2 added lines, -2 removed lines

@@ -55,7 +55,7 @@ 
         $this->userRepo
             ->method('findByUids')
             ->with($this->anything())
-            ->will($this->returnCallback(function (array $uids) {
+            ->will($this->returnCallback(function(array $uids) {
                 $groups = [];
                 // getGroups returns [gid => $group, gid => $group, ...]
                 if (in_array(self::RANDOM_USER_ID, $uids)) {
@@ -125,7 +125,7 @@ 
         $this->currentUserApi
             ->method('get')
             ->with($this->equalTo('uid'))
-            ->will($this->returnCallback(function () use ($uid) {
+            ->will($this->returnCallback(function() use ($uid) {
                 return isset($uid) ? $uid : Constant::USER_ID_ANONYMOUS;
             }));
         $api = new PermissionApi($this->permRepo, $this->userRepo, $this->currentUserApi, $this->translator);

src/system/GroupsModule/GroupsModuleInstaller.php

Spacing +2 added lines, -2 removed lines

@@ -70,8 +70,8 @@
         switch ($oldVersion) {
             case '2.3.2':
             case '2.4.0':
-                $this->setVar('mailwarning', (bool) $this->getVar('mailwarning'));
-                $this->setVar('hideclosed', (bool) $this->getVar('hideclosed'));
+                $this->setVar('mailwarning', (bool)$this->getVar('mailwarning'));
+                $this->setVar('hideclosed', (bool)$this->getVar('hideclosed'));
                 $this->setVar('hidePrivate', false);
             case '2.4.1':
                 /** @var UserEntity $anonymousUser */

src/system/CategoriesModule/Entity/CategoryEntity.php

Doc Comments +1 added lines, -1 removed lines

@@ -383,7 +383,7 @@
 
     /**
      * get the category display name
-     * @param $lang
+     * @param string $lang
      *
      * @return array|string the category display name(s)
      */

src/system/UsersModule/Twig/Extension/OnlineExtension.php

Spacing +1 added lines, -1 removed lines

@@ -69,6 +69,6 @@
             ->andWhere(Criteria::expr()->gt('lastused', $since));
         $online = $this->sessionRepository->matching($c)->count();
 
-        return (bool) $online;
+        return (bool)$online;
     }
 }

src/system/RoutesModule/Form/Handler/Common/Base/AbstractEditHandler.php

Spacing +1 added lines, -1 removed lines

@@ -292,7 +292,7 @@
         $routeParams = $this->request->get('_route_params', []);
         if (empty($this->idValue)) {
             if (array_key_exists($this->idField, $routeParams)) {
-                $this->idValue = (int) !empty($routeParams[$this->idField]) ? $routeParams[$this->idField] : 0;
+                $this->idValue = (int)!empty($routeParams[$this->idField]) ? $routeParams[$this->idField] : 0;
             }
             if (0 === $this->idValue) {
                 $this->idValue = $this->request->query->getInt($this->idField, 0);

src/lib/Zikula/Bundle/CoreBundle/Console/Application.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
         parent::__construct($kernel);
 
         $this->setName('Zikula');
-        $this->setVersion(ZikulaKernel::VERSION.' - '.$kernel->getName().'/'.$kernel->getEnvironment().($kernel->isDebug() ? '/debug' : ''));
+        $this->setVersion(ZikulaKernel::VERSION . ' - ' . $kernel->getName() . '/' . $kernel->getEnvironment() . ($kernel->isDebug() ? '/debug' : ''));
     }
 
     protected function registerCommands()

src/system/UsersModule/Controller/AccessController.php

Braces +2 added lines, -1 removed lines

@@ -91,7 +91,8 @@
                 $form = $this->createForm(DefaultLoginType::class, ['uid' => $uid]);
                 $loginFormEvent = new UserFormAwareEvent($form);
                 $dispatcher->dispatch(AccessEvents::AUTHENTICATION_FORM, $loginFormEvent);
-                if ($form->count() > 3) { // count > 3 means that the AUTHENTICATION_FORM event added some form children
+                if ($form->count() > 3) {
+// count > 3 means that the AUTHENTICATION_FORM event added some form children
                     $form->handleRequest($request);
                     if ($form->isValid() && $form->isSubmitted()) {
                         $uid = $form->get('uid')->getData();

src/system/ZAuthModule/Form/Type/ConfigType.php

Spacing +2 added lines, -2 removed lines

@@ -132,7 +132,7 @@ 
             /**
              * Form Listeners
              */
-            ->addEventListener(FormEvents::POST_SUBMIT, function (FormEvent $event) {
+            ->addEventListener(FormEvents::POST_SUBMIT, function(FormEvent $event) {
                 $data = $event->getData();
                 // clear anti-spam answer if there is no question
                 if (empty($data[ZAuthConstant::MODVAR_REGISTRATION_ANTISPAM_QUESTION])) {
@@ -160,7 +160,7 @@ 
             'translator' => null,
             'constraints' => [
                 new Callback([
-                    'callback' => function ($data, ExecutionContextInterface $context) {
+                    'callback' => function($data, ExecutionContextInterface $context) {
                         if (!empty($data[ZAuthConstant::MODVAR_REGISTRATION_ANTISPAM_QUESTION]) && empty($data[ZAuthConstant::MODVAR_REGISTRATION_ANTISPAM_ANSWER])) {
                             $context->buildViolation('If a spam protection question is provided, then a spam protection answer must also be provided.')
                                 ->atPath(ZAuthConstant::MODVAR_REGISTRATION_ANTISPAM_ANSWER)