Zikula\PermissionsModule\Controller\ConfigController::configAction()

Complexity

Conditions	11
Paths	51

Size

Total Lines	47
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function configAction(
        Request $request,
        VariableApiInterface $variableApi,
        PermissionRepositoryInterface $permissionRepository
    ) {
        $modVars = $variableApi->getAll('ZikulaPermissionsModule');
        $modVars['lockadmin'] = (bool)$modVars['lockadmin'];
        $modVars['filter'] = (bool)$modVars['filter'];

        $form = $this->createForm(ConfigType::class, $modVars);
        $form->handleRequest($request);
        if ($form->isSubmitted() && $form->isValid()) {
            if ($form->get('save')->isClicked()) {

The method isClicked() does not exist on Symfony\Component\Form\FormInterface. It seems like you code against a sub-type of Symfony\Component\Form\FormInterface such as Symfony\Component\Form\SubmitButton.

                $formData = $form->getData();

                $error = false;

                $lockadmin = isset($formData['lockadmin']) ? (bool)$formData['lockadmin'] : false;
                $variableApi->set('ZikulaPermissionsModule', 'lockadmin', $lockadmin);

                $adminId = isset($formData['adminid']) ? (int)$formData['adminid'] : 1;
                if (0 !== $adminId) {
                    $perm = $permissionRepository->find($adminId);

The method find() does not exist on Zikula\PermissionsModule\Entity\RepositoryInterface\PermissionRepositoryInterface. It seems like you code against a sub-type of Zikula\PermissionsModule\Entity\RepositoryInterface\PermissionRepositoryInterface such as Zikula\PermissionsModule\Entity\Repository\PermissionRepository.

                    if (!$perm) {
                        $adminId = 0;
                        $error = true;
                    }
                }
                $variableApi->set('ZikulaPermissionsModule', 'adminid', $adminId);

                $filter = isset($formData['filter']) ? (bool)$formData['filter'] : false;
                $variableApi->set('ZikulaPermissionsModule', 'filter', $filter);

                if (true === $error) {
                    $this->addFlash('error', 'Error! Could not save configuration: unknown permission rule ID.');
                } else {
                    $this->addFlash('status', 'Done! Configuration updated.');
                }
            } elseif ($form->get('cancel')->isClicked()) {
                $this->addFlash('status', 'Operation cancelled.');
            }

            return $this->redirectToRoute('zikulapermissionsmodule_permission_list');
        }

        return [
            'form' => $form->createView()
        ];