Zikula\BlocksModule\BlocksModuleInstaller::upgrade()

Complexity

Conditions	37
Paths	4032

Size

Total Lines	136
Code Lines	98

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	2	Features	0

<?php
    public function upgrade(string $oldVersion): bool
    {
        $blockRepository = $this->entityManager->getRepository(BlockEntity::class);
        // Upgrade dependent on old version number
        switch ($oldVersion) {
            case '3.8.1':
            case '3.8.2':
            case '3.9.0':
                $sql = 'SELECT * FROM blocks';
                $blocks = $this->entityManager->getConnection()->fetchAll($sql);

The method getConnection() does not exist on Doctrine\Persistence\ObjectManager. It seems like you code against a sub-type of Doctrine\Persistence\ObjectManager such as Doctrine\ORM\Decorator\EntityManagerDecorator or Doctrine\ORM\EntityManagerInterface.

                foreach ($blocks as $block) {
                    $content = $block['content'];
                    if ($this->isSerialized($content)) {
                        $content = unserialize($content);
                        foreach ($content as $k => $item) {
                            if (is_string($item)) {
                                if (false !== mb_strpos($item, 'blocks_block_extmenu_topnav.tpl')) {
                                    $content[$k] = str_replace('blocks_block_extmenu_topnav.tpl', 'Block/Extmenu/topnav.tpl', $item);
                                } elseif (false !== mb_strpos($item, 'blocks_block_extmenu.tpl')) {
                                    $content[$k] = str_replace('blocks_block_extmenu.tpl', 'Block/Extmenu/extmenu.tpl', $item);
                                } elseif (false !== mb_strpos($item, 'menutree/blocks_block_menutree_')) {
                                    $content[$k] = str_replace('menutree/blocks_block_menutree_', 'Block/Menutree/', $item);
                                }
                            }
                        }
                        $this->entityManager->getConnection()->executeUpdate('UPDATE blocks SET content=? WHERE bid=?', [serialize($content), $block['bid']]);
                    }
                }

                // check if request is available (#2073)
                $templateWarning = $this->trans('Warning: Block template locations modified, you may need to fix your template overrides if you have any.');
                $request = $this->requestStack->getMasterRequest();
                if (
                    is_object($request)
                    && method_exists($request, 'getSession')
                    && is_object($request->getSession())
                ) {
                    $this->addFlash('warning', $templateWarning);
                }
            case '3.9.1':
                // make all content fields of blocks serialized.
                $sql = 'SELECT * FROM blocks';
                $blocks = $this->entityManager->getConnection()->fetchAll($sql);
                $oldContent = [];
                foreach ($blocks as $block) {
                    $block['content'] = !empty($block['content']) ? $block['content'] : '';
                    $oldContent[$block['bid']] = $this->isSerialized($block['content']) ? unserialize($block['content']) : ['content' => $block['content']];
                }
                $this->schemaTool->update($this->entities);
                $this->entityManager->getConnection()->executeQuery("UPDATE blocks SET properties='a:0:{}'");

                $blocks = $blockRepository->findAll();
                $installerHelper = new InstallerHelper();
                /** @var ZikulaHttpKernelInterface $kernel */
                /** @var BlockEntity $block */
                foreach ($blocks as $block) {
                    $block->setProperties($oldContent[$block->getBid()]);
                    $block->setFilters($installerHelper->upgradeFilterArray($block->getFilters()));
                    $block->setBlocktype(preg_match('/Block$/', $block->getBkey()) ? mb_substr($block->getBkey(), 0, -5) : $block->getBkey());
                    $block->setBkey($installerHelper->upgradeBkeyToFqClassname($this->kernel, $block));
                }
                $this->entityManager->flush();

                $collapseable = $this->getVar('collapseable');
                $this->setVar('collapseable', (bool)$collapseable);

            case '3.9.2':
                // convert Text and Html block types so properties is proper array
                $blocks = $blockRepository->findBy(['blocktype' => ['Html', 'Text']]);
                foreach ($blocks as $block) {
                    $properties = $block->getProperties();
                    if (!is_array($properties)) {
                        $block->setProperties(['content' => $properties]);
                    }
                }
                $this->entityManager->flush();
            case '3.9.3':
                $this->schemaTool->drop([

Consider adding a comment if this fall-through is intended.

                    'Zikula\BlocksModule\Entity\UserBlockEntity'
                ]);
            case '3.9.4':
                // convert integer values to boolean for search block settings
                $searchBlocks = $blockRepository->findBy(['blocktype' => 'Search']);
                foreach ($searchBlocks as $searchBlock) {
                    $properties = $searchBlock->getProperties();
                    $properties['displaySearchBtn'] = (bool)$properties['displaySearchBtn'];
                    if (isset($properties['active'])) {
                        foreach ($properties['active'] as $module => $active) {
                            $properties['active'][$module] = (bool)$active;
                        }
                    }
                    $searchBlock->setProperties($properties);
                }
                $this->entityManager->flush();
            case '3.9.5':
                $loginBlocks = $blockRepository->findBy(['blocktype' => 'Login']);
                foreach ($loginBlocks as $loginBlock) {
                    $filters = $loginBlock->getFilters();
                    $filters[] = [
                        'attribute' => '_route',
                        'queryParameter' => null,
                        'comparator' => '!=',
                        'value' => 'zikulausersmodule_access_login'
                    ];
                    $loginBlock->setFilters($filters);
                }
                $this->entityManager->flush();

Consider adding a comment if this fall-through is intended.

            case '3.9.6':
                $statement = $this->entityManager->getConnection()->executeQuery("SELECT * FROM blocks WHERE blocktype = 'Lang'");
                $blocks = $statement->fetchAll(\PDO::FETCH_ASSOC);
                if (count($blocks) > 0) {
                    $this->entityManager->getConnection()->executeQuery("UPDATE blocks set bkey=?, blocktype=?, properties=? WHERE blocktype = 'Lang'", [
                        'ZikulaSettingsModule:Zikula\SettingsModule\Block\LocaleBlock',
                        'Locale',
                        'a:0:{}'
                    ]);
                    $this->addFlash('success', 'All instances of LangBlock have been converted to LocaleBlock.');
                }
                $this->entityManager->getConnection()->executeQuery("UPDATE group_perms SET component = REPLACE(component, 'Languageblock', 'LocaleBlock') WHERE component LIKE 'Languageblock%'");
            case '3.9.7':
            case '3.9.8':
                $statement = $this->entityManager->getConnection()->executeQuery("SELECT * FROM blocks");
                $blocks = $statement->fetchAll(\PDO::FETCH_ASSOC);
                foreach ($blocks as $block) {
                    $bKey = $block['bkey'];
                    if (mb_strpos($bKey, ':')) {
                        [/*$moduleName*/, $bKey] = explode(':', $bKey);
                    }
                    $this->entityManager->getConnection()->executeUpdate('UPDATE blocks SET bKey=? WHERE bid=?', [trim($bKey, '\\'), $block['bid']]);
                }
            case '3.9.9':
            // future upgrade routines
        }

        // Update successful
        return true;
    }