Zikula\RoutesModule\Form\Handler\Route\EditHandler

Complexity

Total Complexity

11

Size/Duplication

Total Lines	110
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setSanitizeHelper()	0	4	1
A	applyAction()	0	14	2
A	sanitizeInput()	0	14	1
C	hasConflicts()	0	51	7

<?php
/**
 * Routes.
 *
 * @copyright Zikula contributors (Zikula)
 * @license http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
 * @author Zikula contributors <support@zikula.org>.
 * @link http://www.zikula.org
 * @link http://zikula.org
 * @version Generated by ModuleStudio 0.7.4 (http://modulestudio.de).
 */

namespace Zikula\RoutesModule\Form\Handler\Route;

use Symfony\Component\Routing\RouteCollection;
use Zikula\RoutesModule\Entity\RouteEntity;
use Zikula\RoutesModule\Helper\SanitizeHelper;
use Zikula\RoutesModule\Form\Handler\Route\Base\AbstractEditHandler;

/**
 * This handler class handles the page events of the Form called by the zikulaRoutesModule_route_edit() function.
 * It aims on the route object type.
 */
class EditHandler extends AbstractEditHandler
{
    /**
     * @var SanitizeHelper
     */
    private $sanitizeHelper;

    /**
     * Sets the sanitize helper.
     *
     * @param SanitizeHelper $sanitizeHelper Sanitize helper
     */
    public function setSanitizeHelper(SanitizeHelper $sanitizeHelper)
    {
        $this->sanitizeHelper = $sanitizeHelper;
    }

    /**
     * @inheritDoc
     */
    public function applyAction(array $args = [])
    {
        $this->sanitizeInput();
        if ($this->hasConflicts()) {
            return false;
        }

        $return = parent::applyAction($args);

        $cacheClearer = $this->container->get('zikula.cache_clearer');

The property container does not exist. Did you maybe forget to declare it?

        $cacheClearer->clear('symfony.routing');

        return $return;
    }

    /**
     * Ensures validity of input data.
     */
    private function sanitizeInput()
    {
        $entity = $this->entityRef;

        list($controller, ) = $this->sanitizeHelper->sanitizeController($entity['controller']);
        list($action, ) = $this->sanitizeHelper->sanitizeAction($entity['action']);

        $entity['controller'] = $controller;
        $entity['action'] = $action;
        $entity['group'] = RouteEntity::POSITION_MIDDLE;
        $entity['sort'] = 0;

        $this->entityRef = $entity;
    }

    /**
     * Checks for potential conflict.
     *
     * @return boolean True if a critical error occured, else false.
     */
    private function hasConflicts()
    {
        $routeEntity = $this->entityRef;

        $newPath = $routeEntity->getPathWithBundlePrefix();

It seems like you code against a specific sub-type and not the parent class Zikula\Core\Doctrine\EntityAccess as the method getPathWithBundlePrefix() does only exist in the following sub-classes of Zikula\Core\Doctrine\EntityAccess: Zikula\RoutesModule\Entity\RouteEntity. Maybe you want to instanceof check for one of these explicitly?

        /** @var RouteCollection $routeCollection */
        $routeCollection = $this->router->getRouteCollection();

        $errors = [];
        foreach ($routeCollection->all() as $route) {
            $path = $route->getPath();
            if ($path === '/{url}') {
                continue;
            }

            if ($path === $newPath) {
                $errors[] = [
                    'type' => 'SAME',
                    'path' => $path
                ];
                continue;
            }

            $pathRegExp = preg_quote(preg_replace("/{(.+)}/", "____DUMMY____", $path), '/');
            $pathRegExp = "#^" . str_replace('____DUMMY____', '(.+)', $pathRegExp) . "$#";

            $matches = [];
            preg_match($pathRegExp, $newPath, $matches);
            if (count($matches)) {
                $errors[] = [
                    'type' => 'SIMILAR',
                    'path' => $path
                ];
            }
        }

        $hasCriticalErrors = false;

        foreach ($errors as $error) {
            if ($error['type'] == 'SAME') {
                $message = $this->__('It looks like you created or updated a route with a path which already exists. This is an error in most cases.');
                $hasCriticalErrors = true;
            } else {
                $message = $this->__f('The path of the route you created or updated looks similar to the following already existing path: %s Are you sure you haven\'t just introduced a conflict?', ['%s' => $error['path']]);
            }
            $this->request->getSession()->getFlashBag()->add('error', $message);
        }

        return $hasCriticalErrors;
    }
}