Completed
Push — master ( 5dc4f8...64a76f )
by Craig
43:25 queued 30:45
created
src/system/ExtensionsModule/Entity/Repository/ExtensionRepository.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -53,6 +53,9 @@  discard block
 block discarded – undo
53 53
         return $paginator;
54 54
     }
55 55
 
56
+    /**
57
+     * @param string $indexBy
58
+     */
56 59
     public function getIndexedArrayCollection($indexBy)
57 60
     {
58 61
         $qb = $this->createQueryBuilder('e')->indexBy('e', 'e.' . $indexBy);
@@ -78,6 +81,9 @@  discard block
 block discarded – undo
78 81
         $this->_em->flush($entity);
79 82
     }
80 83
 
84
+    /**
85
+     * @param ExtensionEntity $entity
86
+     */
81 87
     public function removeAndFlush($entity)
82 88
     {
83 89
         $this->_em->remove($entity);
Please login to merge, or discard this patch.
src/system/RoutesModule/Form/Handler/Route/Base/AbstractEditHandler.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -378,7 +378,7 @@
 block discarded – undo
378 378
     /**
379 379
      * Get list of allowed redirect codes.
380 380
      *
381
-     * @return array list of possible redirect codes
381
+     * @return string[] list of possible redirect codes
382 382
      */
383 383
     protected function getRedirectCodes()
384 384
     {
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
         try {
224 224
             // execute the workflow action
225 225
             $success = $this->workflowHelper->executeAction($entity, $action);
226
-        } catch(\Exception $exception) {
226
+        } catch (\Exception $exception) {
227 227
             $flashBag->add('error', $this->__f('Sorry, but an error occured during the %action% action. Please apply the changes again!', ['%action%' => $action]) . ' ' . $exception->getMessage());
228 228
             $logArgs = ['app' => 'ZikulaRoutesModule', 'user' => $this->currentUserApi->get('uname'), 'entity' => 'route', 'id' => $entity->getKey(), 'errorMessage' => $exception->getMessage()];
229 229
             $this->logger->error('{app}: User {user} tried to edit the {entity} with id {id}, but failed. Error details: {errorMessage}.', $logArgs);
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
                 return $this->router->generate($routePrefix . 'view');
278 278
             case 'userOwnView':
279 279
             case 'adminOwnView':
280
-                return $this->router->generate($routePrefix . 'view', [ 'own' => 1 ]);
280
+                return $this->router->generate($routePrefix . 'view', ['own' => 1]);
281 281
             case 'userDisplay':
282 282
             case 'adminDisplay':
283 283
                 if ($args['commandName'] != 'delete' && !($this->templateParameters['mode'] == 'create' && $args['commandName'] == 'cancel')) {
Please login to merge, or discard this patch.
Unused Use Statements   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -12,13 +12,11 @@
 block discarded – undo
12 12
 
13 13
 namespace Zikula\RoutesModule\Form\Handler\Route\Base;
14 14
 
15
+use RuntimeException;
16
+use Symfony\Component\HttpFoundation\RedirectResponse;
15 17
 use Zikula\RoutesModule\Form\Handler\Common\EditHandler;
16 18
 use Zikula\RoutesModule\Form\Type\RouteType;
17 19
 
18
-use Symfony\Component\HttpFoundation\RedirectResponse;
19
-use Symfony\Component\Security\Core\Exception\AccessDeniedException;
20
-use RuntimeException;
21
-
22 20
 /**
23 21
  * This handler class handles the page events of editing forms.
24 22
  * It aims on the route object type.
Please login to merge, or discard this patch.
src/system/SettingsModule/SettingsModuleInstaller.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -177,6 +177,9 @@
 block discarded – undo
177 177
         return $this->container->get('zikula_extensions_module.api.variable')->set(VariableApi::CONFIG, $name, $value);
178 178
     }
179 179
 
180
+    /**
181
+     * @param string $name
182
+     */
180 183
     private function getSystemVar($name)
181 184
     {
182 185
         return $this->container->get('zikula_extensions_module.api.variable')->getSystemVar($name);
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -142,9 +142,9 @@
 block discarded – undo
142 142
                 $newStargArgs = str_replace(',', '&', $this->getSystemVar('startargs')); // replace comma with `&`
143 143
                 $this->setSystemVar('startargs', $newStargArgs);
144 144
             case '2.9.11':
145
-                $this->setSystemVar('shorturls', (bool) $this->getSystemVar('shorturls'));
146
-                $this->setSystemVar('shorturlsstripentrypoint', (bool) $this->getSystemVar('shorturlsstripentrypoint'));
147
-                $this->setSystemVar('useCompression', (bool) $this->getSystemVar('useCompression'));
145
+                $this->setSystemVar('shorturls', (bool)$this->getSystemVar('shorturls'));
146
+                $this->setSystemVar('shorturlsstripentrypoint', (bool)$this->getSystemVar('shorturlsstripentrypoint'));
147
+                $this->setSystemVar('useCompression', (bool)$this->getSystemVar('useCompression'));
148 148
             case '2.9.12': // ship with Core-1.4.4
149 149
                 // reconfigure TZ settings
150 150
                 $this->setGuestTimeZone();
Please login to merge, or discard this patch.
src/system/ThemeModule/Engine/AssetFilter.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -85,14 +85,14 @@
 block discarded – undo
85 85
         $header .= implode("\n", $this->headers->all()) . "\n";
86 86
         $header .= ($this->scriptPosition == 'head') ? $this->jsResolver->compile() : '';
87 87
         if (strripos($source, '</head>')) {
88
-            $source = str_replace('</head>', $header."\n</head>", $source);
88
+            $source = str_replace('</head>', $header . "\n</head>", $source);
89 89
         }
90 90
 
91 91
         // compile and replace foot
92 92
         $footer = ($this->scriptPosition == 'foot') ? $this->jsResolver->compile() : '';
93 93
         $footer .= trim(implode("\n", $this->footers->all()) . "\n");
94 94
         if (false === empty($footer)) {
95
-            $source = str_replace('</body>', $footer."\n</body>", $source);
95
+            $source = str_replace('</body>', $footer . "\n</body>", $source);
96 96
         }
97 97
 
98 98
         return $source;
Please login to merge, or discard this patch.
src/system/MenuModule/DependencyInjection/ZikulaMenuExtension.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
      */
27 27
     public function load(array $configs, ContainerBuilder $container)
28 28
     {
29
-        $loader = new YamlFileLoader($container, new FileLocator(realpath(__DIR__.'/../Resources/config')));
29
+        $loader = new YamlFileLoader($container, new FileLocator(realpath(__DIR__ . '/../Resources/config')));
30 30
 
31 31
         $loader->load('services.yml');
32 32
     }
Please login to merge, or discard this patch.
src/system/SearchModule/Entity/Repository/SearchResultRepository.php 1 patch
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
 
35 35
         if ($sessionId != '') {
36 36
             $qb->where('tbl.sesid = :sid')
37
-               ->setParameter('sid', $sessionId);
37
+                ->setParameter('sid', $sessionId);
38 38
         }
39 39
 
40 40
         $query = $qb->getQuery();
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
             $i = 1;
65 65
             foreach ($filters as $w_key => $w_value) {
66 66
                 $qb->andWhere($qb->expr()->eq('tbl.' . $w_key, '?' . $i))
67
-                   ->setParameter($i, $w_value);
67
+                    ->setParameter($i, $w_value);
68 68
                 $i++;
69 69
             }
70 70
         }
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
 
105 105
         if ($sessionId != '') {
106 106
             $qb->orWhere('tbl.sesid = :sid')
107
-               ->setParameter('sid', $sessionId);
107
+                ->setParameter('sid', $sessionId);
108 108
         }
109 109
 
110 110
         $query = $qb->getQuery();
Please login to merge, or discard this patch.
system/PermissionsModule/DependencyInjection/ZikulaPermissionsExtension.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
      */
27 27
     public function load(array $configs, ContainerBuilder $container)
28 28
     {
29
-        $loader = new YamlFileLoader($container, new FileLocator(realpath(__DIR__.'/../Resources/config')));
29
+        $loader = new YamlFileLoader($container, new FileLocator(realpath(__DIR__ . '/../Resources/config')));
30 30
 
31 31
         $loader->load('services.yml');
32 32
     }
Please login to merge, or discard this patch.
src/system/GroupsModule/DependencyInjection/ZikulaGroupsExtension.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
      */
27 27
     public function load(array $configs, ContainerBuilder $container)
28 28
     {
29
-        $loader = new YamlFileLoader($container, new FileLocator(realpath(__DIR__.'/../Resources/config')));
29
+        $loader = new YamlFileLoader($container, new FileLocator(realpath(__DIR__ . '/../Resources/config')));
30 30
 
31 31
         $loader->load('services.yml');
32 32
     }
Please login to merge, or discard this patch.
src/system/GroupsModule/Entity/Repository/GroupRepository.php 1 patch
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -46,12 +46,12 @@  discard block
 block discarded – undo
46 46
 
47 47
         if (null !== $groupType) {
48 48
             $qb->where('g.gtype = :gtype')
49
-               ->setParameter('gtype', $groupType);
49
+                ->setParameter('gtype', $groupType);
50 50
         }
51 51
 
52 52
         if (null !== $excludedState) {
53 53
             $qb->andWhere('g.state != :state')
54
-               ->setParameter('state', $excludedState);
54
+                ->setParameter('state', $excludedState);
55 55
         }
56 56
 
57 57
         $query = $qb->getQuery();
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
             $i = 1;
80 80
             foreach ($filters as $w_key => $w_value) {
81 81
                 $qb->andWhere($qb->expr()->eq('g.' . $w_key, '?' . $i))
82
-                   ->setParameter($i, $w_value);
82
+                    ->setParameter($i, $w_value);
83 83
                 $i++;
84 84
             }
85 85
         }
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
             $i = 1;
88 88
             foreach ($exclusions as $w_key => $w_value) {
89 89
                 $qb->andWhere($qb->expr()->neq('g.' . $w_key, '?' . $i))
90
-                   ->setParameter($i, $w_value);
90
+                    ->setParameter($i, $w_value);
91 91
                 $i++;
92 92
             }
93 93
         }
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
         // already another group by that name.
164 164
         if (is_numeric($excludedGroupId) && $excludedGroupId > 0) {
165 165
             $qb->andWhere($qb->expr()->neq('g.gid', ':ggid'))
166
-               ->setParameter('ggid', $excludedGroupId);
166
+                ->setParameter('ggid', $excludedGroupId);
167 167
         }
168 168
 
169 169
         $query = $qb->getQuery();
Please login to merge, or discard this patch.