Inspection of "fix tests" - zikula/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5dc4f8...64a76f )

by Craig

created 2017-07-13 13:05 UTC

Status

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -17,8 +17,8 @@
 block discarded – undo
 use Symfony\Component\DependencyInjection\ContainerAwareInterface;
 use Symfony\Component\DependencyInjection\ContainerAwareTrait;
 use Zikula\Common\Translator\TranslatorTrait;
-use Zikula\UsersModule\Constant as UsersConstant;
 use Zikula\RoutesModule\Entity\RouteEntity;
+use Zikula\UsersModule\Constant as UsersConstant;
 
 /**
  * This is the item actions menu implementation class.

Please login to merge, or discard this patch.

src/system/SecurityCenterModule/Controller/IdsLogController.php 1 patch

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -22,9 +22,9 @@
 block discarded – undo
 use Zikula\Component\SortableColumns\Column;
 use Zikula\Component\SortableColumns\SortableColumns;
 use Zikula\Core\Controller\AbstractController;
+use Zikula\Core\Response\PlainResponse;
 use Zikula\SecurityCenterModule\Form\Type\IdsLogExportType;
 use Zikula\SecurityCenterModule\Form\Type\IdsLogFilterType;
-use Zikula\Core\Response\PlainResponse;
 use Zikula\ThemeModule\Engine\Annotation\Theme;
 
 /**

Please login to merge, or discard this patch.

src/system/ThemeModule/Controller/ThemeController.php 1 patch

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -26,9 +26,9 @@
 block discarded – undo
 use Symfony\Component\Security\Core\Exception\AccessDeniedException;
 use Zikula\Core\Controller\AbstractController;
 use Zikula\Core\Event\GenericEvent;
+use Zikula\ExtensionsModule\Api\VariableApi;
 use Zikula\ExtensionsModule\ExtensionEvents;
 use Zikula\ThemeModule\Engine\Annotation\Theme;
-use Zikula\ExtensionsModule\Api\VariableApi;
 use Zikula\ThemeModule\Entity\Repository\ThemeEntityRepository;
 
 /**

Please login to merge, or discard this patch.

src/system/ThemeModule/Engine/Engine.php 1 patch

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -11,9 +11,9 @@
 block discarded – undo
 
 namespace Zikula\ThemeModule\Engine;
 
+use Doctrine\Common\Annotations\Reader;
 use Symfony\Component\HttpFoundation\RequestStack;
 use Symfony\Component\HttpFoundation\Response;
-use Doctrine\Common\Annotations\Reader;
 use Zikula\Bundle\CoreBundle\HttpKernel\ZikulaKernel;
 use Zikula\ExtensionsModule\Api\ApiInterface\VariableApiInterface;
 

Please login to merge, or discard this patch.

src/system/UsersModule/Controller/UserAdministrationController.php 1 patch

Unused Use Statements +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -29,14 +29,14 @@
 block discarded – undo
 use Zikula\ThemeModule\Engine\Annotation\Theme;
 use Zikula\UsersModule\Constant as UsersConstant;
 use Zikula\UsersModule\Entity\UserEntity;
-use Zikula\UsersModule\Form\Type\RegistrationType\ApproveRegistrationConfirmationType;
+use Zikula\UsersModule\Event\UserFormAwareEvent;
+use Zikula\UsersModule\Event\UserFormDataEvent;
 use Zikula\UsersModule\Form\Type\AdminModifyUserType;
 use Zikula\UsersModule\Form\Type\DeleteConfirmationType;
 use Zikula\UsersModule\Form\Type\DeleteType;
 use Zikula\UsersModule\Form\Type\MailType;
+use Zikula\UsersModule\Form\Type\RegistrationType\ApproveRegistrationConfirmationType;
 use Zikula\UsersModule\Form\Type\SearchUserType;
-use Zikula\UsersModule\Event\UserFormAwareEvent;
-use Zikula\UsersModule\Event\UserFormDataEvent;
 use Zikula\UsersModule\HookSubscriber\UserManagementUiHooksSubscriber;
 use Zikula\UsersModule\RegistrationEvents;
 use Zikula\UsersModule\UserEvents;

Please login to merge, or discard this patch.

src/lib/requirementCheck.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@
 block discarded – undo
         if (php_sapi_name() != 'cli') {
             echo '<html><body><pre>';
         }
-        echo 'The following errors were discovered when checking the' .PHP_EOL. 'Zikula Core system/environment requirements:' . PHP_EOL;
+        echo 'The following errors were discovered when checking the' . PHP_EOL . 'Zikula Core system/environment requirements:' . PHP_EOL;
         echo '******************************************************' . PHP_EOL . PHP_EOL;
         foreach ($versionChecker->requirementsErrors as $error) {
             echo $error . PHP_EOL;

Please login to merge, or discard this patch.

src/system/AdminModule/Helper/UpdateCheckHelper.php 1 patch

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -211,7 +211,7 @@
 block discarded – undo
                 return false;
             }
 
-            $out = "GET $path_query? HTTP/1.1\r\n";
+            $out = "get $path_query? HTTP/1.1\r\n";
             $out .= "User-Agent: $userAgent\r\n";
             $out .= "Referer: $ref\r\n";
             $out .= "Host: $urlArray[host]\r\n";

Please login to merge, or discard this patch.

		@@ -29,14 +29,14 @@
		block discarded – undo
29	29	use Zikula\ThemeModule\Engine\Annotation\Theme;
30	30	use Zikula\UsersModule\Constant as UsersConstant;
31	31	use Zikula\UsersModule\Entity\UserEntity;
32		-use Zikula\UsersModule\Form\Type\RegistrationType\ApproveRegistrationConfirmationType;
	32	+use Zikula\UsersModule\Event\UserFormAwareEvent;
	33	+use Zikula\UsersModule\Event\UserFormDataEvent;
33	34	use Zikula\UsersModule\Form\Type\AdminModifyUserType;
34	35	use Zikula\UsersModule\Form\Type\DeleteConfirmationType;
35	36	use Zikula\UsersModule\Form\Type\DeleteType;
36	37	use Zikula\UsersModule\Form\Type\MailType;
	38	+use Zikula\UsersModule\Form\Type\RegistrationType\ApproveRegistrationConfirmationType;
37	39	use Zikula\UsersModule\Form\Type\SearchUserType;
38		-use Zikula\UsersModule\Event\UserFormAwareEvent;
39		-use Zikula\UsersModule\Event\UserFormDataEvent;
40	40	use Zikula\UsersModule\HookSubscriber\UserManagementUiHooksSubscriber;
41	41	use Zikula\UsersModule\RegistrationEvents;
42	42	use Zikula\UsersModule\UserEvents;

		@@ -33,7 +33,7 @@
		block discarded – undo
33	33	if (php_sapi_name() != 'cli') {
34	34	echo '<html><body><pre>';
35	35	}
36		- echo 'The following errors were discovered when checking the' .PHP_EOL. 'Zikula Core system/environment requirements:' . PHP_EOL;
	36	+ echo 'The following errors were discovered when checking the' . PHP_EOL . 'Zikula Core system/environment requirements:' . PHP_EOL;
37	37	echo '******************************************************' . PHP_EOL . PHP_EOL;
38	38	foreach ($versionChecker->requirementsErrors as $error) {
39	39	echo $error . PHP_EOL;

		@@ -211,7 +211,7 @@
		block discarded – undo
211	211	return false;
212	212	}
213	213
214		- $out = "GET $path_query? HTTP/1.1\r\n";
	214	+ $out = "get $path_query? HTTP/1.1\r\n";
215	215	$out .= "User-Agent: $userAgent\r\n";
216	216	$out .= "Referer: $ref\r\n";
217	217	$out .= "Host: $urlArray[host]\r\n";

		@@ -17,8 +17,8 @@
		block discarded – undo
17	17	use Symfony\Component\DependencyInjection\ContainerAwareInterface;
18	18	use Symfony\Component\DependencyInjection\ContainerAwareTrait;
19	19	use Zikula\Common\Translator\TranslatorTrait;
20		-use Zikula\UsersModule\Constant as UsersConstant;
21	20	use Zikula\RoutesModule\Entity\RouteEntity;
	21	+use Zikula\UsersModule\Constant as UsersConstant;
22	22
23	23	/**
24	24	* This is the item actions menu implementation class.

		@@ -22,9 +22,9 @@
		block discarded – undo
22	22	use Zikula\Component\SortableColumns\Column;
23	23	use Zikula\Component\SortableColumns\SortableColumns;
24	24	use Zikula\Core\Controller\AbstractController;
	25	+use Zikula\Core\Response\PlainResponse;
25	26	use Zikula\SecurityCenterModule\Form\Type\IdsLogExportType;
26	27	use Zikula\SecurityCenterModule\Form\Type\IdsLogFilterType;
27		-use Zikula\Core\Response\PlainResponse;
28	28	use Zikula\ThemeModule\Engine\Annotation\Theme;
29	29
30	30	/**

		@@ -26,9 +26,9 @@
		block discarded – undo
26	26	use Symfony\Component\Security\Core\Exception\AccessDeniedException;
27	27	use Zikula\Core\Controller\AbstractController;
28	28	use Zikula\Core\Event\GenericEvent;
	29	+use Zikula\ExtensionsModule\Api\VariableApi;
29	30	use Zikula\ExtensionsModule\ExtensionEvents;
30	31	use Zikula\ThemeModule\Engine\Annotation\Theme;
31		-use Zikula\ExtensionsModule\Api\VariableApi;
32	32	use Zikula\ThemeModule\Entity\Repository\ThemeEntityRepository;
33	33
34	34	/**

		@@ -11,9 +11,9 @@
		block discarded – undo
11	11
12	12	namespace Zikula\ThemeModule\Engine;
13	13
	14	+use Doctrine\Common\Annotations\Reader;
14	15	use Symfony\Component\HttpFoundation\RequestStack;
15	16	use Symfony\Component\HttpFoundation\Response;
16		-use Doctrine\Common\Annotations\Reader;
17	17	use Zikula\Bundle\CoreBundle\HttpKernel\ZikulaKernel;
18	18	use Zikula\ExtensionsModule\Api\ApiInterface\VariableApiInterface;
19	19

zikula / core

Push — master ( 5dc4f8...64a76f )

Status

Category

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

Unused Use Statements +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch