Completed
Push — master ( 5dc4f8...64a76f )
by Craig
43:25 queued 30:45
created
src/system/UsersModule/Form/Type/ConfigType/ConfigType.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
                 'constraints' => [
140 140
                     new Type('string'),
141 141
                     new Regex([
142
-                        'pattern' => '/^(?:'. UsersConstant::UNAME_VALIDATION_PATTERN .'(?:\s*,\s*'. UsersConstant::UNAME_VALIDATION_PATTERN .')*)?$/uD',
142
+                        'pattern' => '/^(?:' . UsersConstant::UNAME_VALIDATION_PATTERN . '(?:\s*,\s*' . UsersConstant::UNAME_VALIDATION_PATTERN . ')*)?$/uD',
143 143
                         'message' => $options['translator']->__('The value provided does not appear to be a valid list of user names. The list should consist of one or more user names made up of lowercase letters, numbers, underscores, periods, or dashes. Separate each user name with a comma. For example: \'root, administrator, superuser\' (the quotes should not appear in the list). Spaces surrounding commas are ignored, however extra spaces before or after the list are not and will result in an error. Empty values (two commas together, or separated only by spaces) are not allowed. The list is optional, and if no values are to be defined then the list should be completely empty (no extra spaces, commas, or any other characters).')
144 144
                     ])
145 145
                 ]
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
                 'constraints' => [
167 167
                     new Type('string'),
168 168
                     new Regex([
169
-                        'pattern' => '/^(?:'. UsersConstant::EMAIL_DOMAIN_VALIDATION_PATTERN .'(?:\s*,\s*'. UsersConstant::EMAIL_DOMAIN_VALIDATION_PATTERN .')*)?$/Ui',
169
+                        'pattern' => '/^(?:' . UsersConstant::EMAIL_DOMAIN_VALIDATION_PATTERN . '(?:\s*,\s*' . UsersConstant::EMAIL_DOMAIN_VALIDATION_PATTERN . ')*)?$/Ui',
170 170
                         'message' => $options['translator']->__('The contents of this field does not appear to be a valid list of e-mail address domains. The list should consist of one or more e-mail address domains (the part after the \'@\'), separated by commas. For example: \'gmail.com, example.org, acme.co.uk\' (the quotes should not appear in the list). Do not include the \'@\' itself. Spaces surrounding commas are ignored, however extra spaces before or after the list are not and will result in an error. Empty values (two commas together, or separated only by spaces) are not allowed. The list is optional, and if no values are to be defined then the list should be completely empty (no extra spaces, commas, or any other characters).')
171 171
                     ])
172 172
                 ]
Please login to merge, or discard this patch.
src/system/ZAuthModule/Helper/MailHelper.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -96,6 +96,9 @@
 block discarded – undo
96 96
         return $this->mailerApi->sendMessage($message, $subject, $body, $altBody, $html);
97 97
     }
98 98
 
99
+    /**
100
+     * @param string $notificationType
101
+     */
99 102
     private function generateEmailSubject($notificationType)
100 103
     {
101 104
         $siteName = $this->variableApi->getSystemVar('sitename');
Please login to merge, or discard this patch.
src/lib/Zikula/Bridge/HttpFoundation/ZikulaSessionStorage.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,8 +12,8 @@
 block discarded – undo
12 12
 namespace Zikula\Bridge\HttpFoundation;
13 13
 
14 14
 use Symfony\Component\HttpFoundation\Session\Storage\Handler\NativeSessionHandler;
15
-use Symfony\Component\HttpFoundation\Session\Storage\NativeSessionStorage;
16 15
 use Symfony\Component\HttpFoundation\Session\Storage\MetadataBag;
16
+use Symfony\Component\HttpFoundation\Session\Storage\NativeSessionStorage;
17 17
 use Symfony\Component\HttpFoundation\Session\Storage\Proxy\AbstractProxy;
18 18
 use Zikula\ExtensionsModule\Api\ApiInterface\VariableApiInterface;
19 19
 use Zikula\UsersModule\Constant;
Please login to merge, or discard this patch.
src/lib/Zikula/Bundle/CoreBundle/Translation/ZikulaPhpFileExtractor.php 1 patch
Unused Use Statements   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -22,11 +22,11 @@
 block discarded – undo
22 22
 use JMS\TranslationBundle\Model\MessageCatalogue;
23 23
 use JMS\TranslationBundle\Translation\Extractor\FileVisitorInterface;
24 24
 use PhpParser\Node;
25
-use PhpParser\Node\Stmt\Namespace_;
26
-use PhpParser\Node\Expr\MethodCall;
27
-use PhpParser\Node\Scalar\String_;
28 25
 use PhpParser\NodeTraverser;
29 26
 use PhpParser\NodeVisitor;
27
+use PhpParser\Node\Expr\MethodCall;
28
+use PhpParser\Node\Scalar\String_;
29
+use PhpParser\Node\Stmt\Namespace_;
30 30
 use Psr\Log\LoggerInterface;
31 31
 use Symfony\Component\HttpKernel\Bundle\BundleInterface;
32 32
 use Zikula\Bundle\CoreBundle\HttpKernel\ZikulaHttpKernelInterface;
Please login to merge, or discard this patch.
lib/Zikula/Bundle/CoreInstallerBundle/Controller/InstallerController.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -11,9 +11,9 @@
 block discarded – undo
11 11
 
12 12
 namespace Zikula\Bundle\CoreInstallerBundle\Controller;
13 13
 
14
-use Symfony\Component\HttpFoundation\Response;
15 14
 use Symfony\Component\HttpFoundation\RedirectResponse;
16 15
 use Symfony\Component\HttpFoundation\Request;
16
+use Symfony\Component\HttpFoundation\Response;
17 17
 use Zikula\Component\Wizard\FormHandlerInterface;
18 18
 use Zikula\Component\Wizard\Wizard;
19 19
 use Zikula\Component\Wizard\WizardCompleteInterface;
Please login to merge, or discard this patch.
Zikula/Bundle/HookBundle/Dispatcher/Storage/Doctrine/DoctrineStorage.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,9 +15,9 @@
 block discarded – undo
15 15
 use Doctrine\ORM\Query\Expr\OrderBy;
16 16
 use Symfony\Bridge\Doctrine\RegistryInterface;
17 17
 use Zikula\Bundle\HookBundle\Collector\HookCollectorInterface;
18
+use Zikula\Bundle\HookBundle\Dispatcher\StorageInterface;
18 19
 use Zikula\Bundle\HookBundle\Dispatcher\Storage\Doctrine\Entity\RepositoryInterface\HookBindingRepositoryInterface;
19 20
 use Zikula\Bundle\HookBundle\Dispatcher\Storage\Doctrine\Entity\RepositoryInterface\HookRuntimeRepositoryInterface;
20
-use Zikula\Bundle\HookBundle\Dispatcher\StorageInterface;
21 21
 
22 22
 /**
23 23
  * Doctrine class.
Please login to merge, or discard this patch.
src/lib/Zikula/Bundle/WorkflowBundle/Controller/EditorController.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,8 +15,8 @@
 block discarded – undo
15 15
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
16 16
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
17 17
 use Symfony\Component\HttpFoundation\Request;
18
-use Symfony\Component\Security\Core\Exception\AccessDeniedException;
19 18
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
19
+use Symfony\Component\Security\Core\Exception\AccessDeniedException;
20 20
 use Zikula\ThemeModule\Engine\Annotation\Theme;
21 21
 
22 22
 /**
Please login to merge, or discard this patch.
src/lib/Zikula/Composer/ManuallyInstallAssets.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,8 +12,8 @@
 block discarded – undo
12 12
 namespace Zikula\Composer;
13 13
 
14 14
 use Composer\Script\Event;
15
-use Symfony\Component\Filesystem\Filesystem;
16 15
 use Sensio\Bundle\DistributionBundle\Composer\ScriptHandler;
16
+use Symfony\Component\Filesystem\Filesystem;
17 17
 
18 18
 /**
19 19
  * Class ManuallyInstallAssets
Please login to merge, or discard this patch.
src/system/AdminModule/AdminModuleInstaller.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -110,7 +110,7 @@
 block discarded – undo
110 110
      * This function is only ever called once during the lifetime of a particular
111 111
      * module instance
112 112
      *
113
-     * @return bool false
113
+     * @return boolean|null false
114 114
      */
115 115
     public function defaultdata()
116 116
     {
Please login to merge, or discard this patch.