zikula / core

src/system/MenuModule/Controller/MenuController.php

Spacing +2 added lines, -2 removed lines

@@ -75,10 +75,10 @@
             [
                 'decorate' => true,
                 'html' => true,
-                'childOpen' => function ($node) {
+                'childOpen' => function($node) {
                     return '<li class="jstree-open" id="' . $this->domTreeNodePrefix . $node['id'] . '">';
                 },
-                'nodeDecorator' => function ($node) {
+                'nodeDecorator' => function($node) {
                     return '<a href="#">' . $node['title'] . ' (' . $node['id'] . ')</a>';
                 }
             ]

src/system/RoutesModule/Controller/Base/AbstractRouteController.php

Doc Comments +4 added lines

@@ -122,6 +122,10 @@
 
     /**
      * This method includes the common implementation code for adminView() and view().
+     * @param string $sort
+     * @param string $sortdir
+     * @param integer $pos
+     * @param integer $num
      */
     protected function viewInternal(Request $request, $sort, $sortdir, $pos, $num, $isAdmin = false)
     {

Spacing +1 added lines, -1 removed lines

@@ -506,7 +506,7 @@
             try {
                 // execute the workflow action
                 $success = $workflowHelper->executeAction($entity, $action);
-            } catch(\Exception $e) {
+            } catch (\Exception $e) {
                 $this->addFlash('error', $this->__f('Sorry, but an error occured during the %action% action.', ['%action%' => $action]) . '  ' . $e->getMessage());
                 $logger->error('{app}: User {user} tried to execute the {action} workflow action for the {entity} with id {id}, but failed. Error details: {errorMessage}.', ['app' => 'ZikulaRoutesModule', 'user' => $userName, 'action' => $action, 'entity' => 'route', 'id' => $itemId, 'errorMessage' => $e->getMessage()]);
             }

Unused Use Statements +4 added lines, -4 removed lines

@@ -13,13 +13,13 @@
 namespace Zikula\RoutesModule\Controller\Base;
 
 use RuntimeException;
-use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\Security\Core\Exception\AccessDeniedException;
-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
-use Symfony\Component\HttpFoundation\RedirectResponse;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Cache;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
+use Symfony\Component\HttpFoundation\RedirectResponse;
+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
+use Symfony\Component\Security\Core\Exception\AccessDeniedException;
 use Zikula\Bundle\FormExtensionBundle\Form\Type\DeletionType;
 use Zikula\Component\SortableColumns\Column;
 use Zikula\Component\SortableColumns\SortableColumns;

src/system/SearchModule/DependencyInjection/ZikulaSearchExtension.php

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
      */
     public function load(array $configs, ContainerBuilder $container)
     {
-        $loader = new YamlFileLoader($container, new FileLocator(realpath(__DIR__.'/../Resources/config')));
+        $loader = new YamlFileLoader($container, new FileLocator(realpath(__DIR__ . '/../Resources/config')));
 
         $loader->load('services.yml');
         $loader->load('doctrine.yml');

src/system/SearchModule/Block/SearchBlock.php

Spacing +1 added lines, -1 removed lines

@@ -95,7 +95,7 @@
         }
         // remove disabled
         foreach ($searchModules as $displayName => $moduleName) {
-            if ((bool) $this->getVar('disable_' . $moduleName, false)) {
+            if ((bool)$this->getVar('disable_' . $moduleName, false)) {
                 unset($searchModules[$displayName]);
             }
         }

src/lib/Zikula/Bundle/FormExtensionBundle/Twig/Extension/FormExtension.php

Doc Comments +1 added lines, -1 removed lines

@@ -47,7 +47,7 @@
     /**
      * Returns a list of functions to add to the existing list.
      *
-     * @return array An array of functions
+     * @return \Twig_SimpleFunction[] An array of functions
      */
     public function getFunctions()
     {

src/system/ThemeModule/EventListener/CreateThemedResponseListener.php

Doc Comments +3 added lines

@@ -108,6 +108,9 @@
         $response->setContent($content);
     }
 
+    /**
+     * @param string $search
+     */
     private function readdUntrimmedBlocks($search, $replace, &$subject)
     {
         $len = strlen($search);

src/system/UsersModule/Controller/AccessController.php

Doc Comments +1 added lines, -1 removed lines

@@ -134,7 +134,7 @@
     /**
      * @param UserEntity $user
      * @param $selectedMethod
-     * @param $returnUrl
+     * @param string $returnUrl
      * @return mixed
      */
     private function dispatchLoginSuccessEvent(UserEntity $user, $selectedMethod, $returnUrl)

Braces +2 added lines, -1 removed lines

@@ -91,7 +91,8 @@
                 $form = $this->createForm(DefaultLoginType::class, ['uid' => $uid]);
                 $loginFormEvent = new UserFormAwareEvent($form);
                 $dispatcher->dispatch(AccessEvents::AUTHENTICATION_FORM, $loginFormEvent);
-                if ($form->count() > 3) { // count > 3 means that the AUTHENTICATION_FORM event added some form children
+                if ($form->count() > 3) {
+// count > 3 means that the AUTHENTICATION_FORM event added some form children
                     $form->handleRequest($request);
                     if ($form->isValid() && $form->isSubmitted()) {
                         $uid = $form->get('uid')->getData();

src/system/RoutesModule/Form/Type/Base/AbstractRouteType.php

Spacing +1 added lines, -1 removed lines

@@ -413,7 +413,7 @@
             ->setDefaults([
                 // define class for underlying data (required for embedding forms)
                 'data_class' => 'Zikula\RoutesModule\Entity\RouteEntity',
-                'empty_data' => function (FormInterface $form) {
+                'empty_data' => function(FormInterface $form) {
                     return $this->entityFactory->createRoute();
                 },
                 'error_mapping' => [

Unused Use Statements +1 added lines, -1 removed lines

@@ -28,8 +28,8 @@
 use Zikula\RoutesModule\Entity\Factory\EntityFactory;
 use Zikula\RoutesModule\Form\Type\Field\ArrayType;
 use Zikula\RoutesModule\Form\Type\Field\MultiListType;
-use Zikula\UsersModule\Form\Type\UserLiveSearchType;
 use Zikula\RoutesModule\Helper\ListEntriesHelper;
+use Zikula\UsersModule\Form\Type\UserLiveSearchType;
 
 /**
  * Route editing form type base class.

src/system/CategoriesModule/Tests/Form/Type/CategoriesTypeTest.php

Doc Comments +9 added lines

@@ -385,6 +385,9 @@ 
         }
     }
 
+    /**
+     * @param string $name
+     */
     protected function createRegistryMock($name, $em)
     {
         $registry = $this->getMockBuilder(ManagerRegistry::class)->getMock();
@@ -396,6 +399,9 @@ 
         return $registry;
     }
 
+    /**
+     * @param \DateTime $now
+     */
     protected function generateCategoryRegistry($now)
     {
         $registry = new CategoryRegistryEntity();
@@ -411,6 +417,9 @@ 
         $this->em->flush();
     }
 
+    /**
+     * @param \DateTime $now
+     */
     protected function generateCategories($now)
     {
         // root