Zikula\CategoriesModule\Controller\NodeController::contextMenuAction()

Complexity

Conditions	27
Paths	106

Size

Total Lines	131
Code Lines	94

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function contextMenu(
        Request $request,
        CategoryRepository $categoryRepository,
        CategoryProcessingHelper $processingHelper,
        LocaleApiInterface $localeApi,
        string $action = 'edit',
        CategoryEntity $category = null
    ): JsonResponse {
        if (!in_array($action, ['edit', 'delete', 'deleteandmovechildren', 'copy', 'activate', 'deactivate'])) {
            return $this->json($this->trans('Data provided was inappropriate.'), Response::HTTP_BAD_REQUEST);
        }
        $mode = $request->request->get('mode', 'edit');

        switch ($action) {
            case 'copy':
                if (!isset($category)) {
                    $category = new CategoryEntity($localeApi->getSupportedLocales());
                }
                $newCategory = clone $category;
                $newCategory->setName($category->getName() . 'copy');
                $displayNames = [];
                foreach ($newCategory->getDisplayName() as $locale => $displayName) {
                    $displayNames[$locale] = $displayName . ' ' . $this->trans('copy');
                }
                $newCategory->setDisplayName($displayNames);
                $action = 'edit';
                $mode = 'new';
                $category = $newCategory;
                // intentionally no break here
                // no break
            case 'edit':
                if (!isset($category)) {
                    $category = new CategoryEntity($localeApi->getSupportedLocales());
                    $parentId = $request->request->get('parent');
                    $mode = 'new';
                    if (!empty($parentId)) {
                        /** @var CategoryEntity $parent */
                        $parent = $categoryRepository->find($parentId);
                        $category->setParent($parent);
                        $category->setRoot($parent->getRoot());
                    } elseif (empty($parentId) && $request->request->has('after')) { // sibling of top-level child
                        /** @var CategoryEntity $sibling */
                        $sibling = $categoryRepository->find($request->request->get('after'));
                        $category->setParent($sibling->getParent());
                        $category->setRoot($sibling->getRoot());
                    }
                }
                $form = $this->createForm(CategoryType::class, $category, [
                    'locales' => $localeApi->getSupportedLocales()
                ]);
                $form->get('after')->setData($request->request->get('after'));
                $form->handleRequest($request);
                if ($form->isSubmitted() && $form->isValid()) {
                    $category = $form->getData();
                    $after = $form->get('after')->getData();
                    if (!empty($after)) {
                        $sibling = $categoryRepository->find($after);
                        $categoryRepository->persistAsNextSiblingOf($category, $sibling);
                    } elseif ('new' === $mode) {
                        $categoryRepository->persistAsLastChild($category);
                    } // no need to persist edited entity
                    $this->getDoctrine()->getManager()->flush();

                    return $this->json([
                        'node' => $category->toJson($this->domTreeNodePrefix, $request->getLocale()),
                        'mode' => $mode
                    ]);
                }
                $response = [
                    'result' => $this->renderView('@ZikulaCategoriesModule/Category/edit.html.twig', [
                        'locales' => $localeApi->getSupportedLocaleNames(null, $request->getLocale()),
                        'form' => $form->createView()
                    ]),
                    'action' => $action,
                    'id' => $category->getId(),
                    'mode' => $mode
                ];
                break;
            case 'deleteandmovechildren':
                /** @var CategoryEntity $newParent */
                $newParent = $categoryRepository->find($request->request->get('parent', 1));
                if (null === $newParent || $newParent === $category->getParent()) {

The method getParent() does not exist on null.

                    $response = ['result' => true];
                    break;
                }
                // move the children
                foreach ($category->getChildren() as $child) {
                    if ($processingHelper->mayCategoryBeDeletedOrMoved($child)) {
                        $category->getChildren()->removeElement($child);
                        $newParent->getChildren()->add($child);
                        $child->setParent($newParent);
                    }
                }
                $this->getDoctrine()->getManager()->flush();
                // intentionally no break here
                // no break
            case 'delete':
                $categoryId = $category->getId();
                $this->removeRecursive($category, $processingHelper);

It seems like $category can also be of type null; however, parameter $parent of Zikula\CategoriesModule\Controller\NodeController::removeRecursive() does only seem to accept Zikula\CategoriesModule\Entity\CategoryEntity, maybe add an additional type check?

                $categoryRemoved = false;
                if (0 === $category->getChildren()->count()
                    && $processingHelper->mayCategoryBeDeletedOrMoved($category)) {

It seems like $category can also be of type null; however, parameter $category of Zikula\CategoriesModule\Helper\CategoryProcessingHelper::mayCategoryBeDeletedOrMoved() does only seem to accept Zikula\CategoriesModule\Entity\CategoryEntity, maybe add an additional type check?

                    $this->getDoctrine()->getManager()->remove($category);
                    $categoryRemoved = true;
                }
                $this->getDoctrine()->getManager()->flush();
                $response = [
                    'result' => $categoryRemoved,
                    'id' => $categoryId,
                    'action' => $action,
                    'parent' => isset($newParent) ? $newParent->getId() : null
                ];
                $categoryRepository->recover();
                $this->getDoctrine()->getManager()->flush();
                break;
            case 'activate':
            case 'deactivate':
                $category->setStatus('A' === $category->getStatus() ? 'I' : 'A');

The condition 'A' === $category->getStatus() is always false.

                $this->getDoctrine()->getManager()->flush();
                $response = [
                    'id' => $category->getId(),
                    'parent' => null !== $category->getParent() ? $category->getParent()->getId() : null,
                    'action' => $action,
                    'result' => true
                ];
                break;
            default:
                $response = ['result' => true];
        }

        return $this->json($response);
    }