ListCommand::execute() - Code Metrics - Inspection of "add tests" - zicht/z - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 62679a...2b0c72 )

by Gerard van

created 2017-02-08 15:36 UTC

ListCommand::execute() A

↳ Parent: ListCommand

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	5
ccs	0
cts	4
cp	0
rs	9.4285
cc	1
eloc	3
nc	1
nop	2
crap	2

<?php

namespace Zicht\Tool\Command;

use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Input;
use Symfony\Component\Console\Command\Command;

class ListCommand extends Command
{
    protected function configure()
    {
        $this
            ->setName('z:list')
            ->setDescription('Lists available commands')
        ;
    }

    protected function execute(Input\InputInterface $input, OutputInterface $output)
    {
        $descriptor = new Descriptor\TextDescriptor();
        $descriptor->describe($output, $this->getApplication());
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
    }
}


1		<?php
2
3		namespace Zicht\Tool\Command;
4
5		use Symfony\Component\Console\Output\OutputInterface;
6		use Symfony\Component\Console\Input;
7		use Symfony\Component\Console\Command\Command;
8
9		class ListCommand extends Command
10		{
11	1	protected function configure()
12		{
13	1	$this
14	1	->setName('z:list')
15	1	->setDescription('Lists available commands')
16		;
17	1	}
18
19		protected function execute(Input\InputInterface $input, OutputInterface $output)
20		{
21		$descriptor = new Descriptor\TextDescriptor();
22		$descriptor->describe($output, $this->getApplication());
		0 ignored issues – show Bug introduced 2017-01-21 13:11 UTC by Report Bug Copy Issue Report It seems like `$this->getApplication()` can be `null`; however, `describe()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
23		}
24		}
25

zicht / z

Push — master ( 62679a...2b0c72 )

ListCommand::execute() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like