Passed
Pull Request — master (#5)
by Gerard van
06:43
created
src/Zicht/Tool/Application.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
      * Construct the application with the specified name, version and config loader.
46 46
      *
47 47
      * @param string $name
48
-     * @param string $version
48
+     * @param Version $version
49 49
      * @param Configuration\ConfigurationLoader $loader
50 50
      */
51 51
     public function __construct($name, Version $version, ConfigurationLoader $loader = null)
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -6,16 +6,13 @@
 block discarded – undo
6 6
 namespace Zicht\Tool;
7 7
 
8 8
 use Symfony\Component\Console\Application as BaseApplication;
9
-use Symfony\Component\Console\Command\Command;
10 9
 use Symfony\Component\Console\Input\ArrayInput;
11 10
 use Symfony\Component\Console\Input\InputArgument;
12 11
 use Symfony\Component\Console\Input\InputOption;
13 12
 use Symfony\Component\Console\Input\InputInterface;
14 13
 use Symfony\Component\Console\Input\InputDefinition;
15 14
 use Symfony\Component\Console\Output\OutputInterface;
16
-use Symfony\Component\Yaml\Yaml;
17 15
 use Zicht\Version\Version;
18
-
19 16
 use Zicht\Tool\Command as Cmd;
20 17
 use Zicht\Tool\Configuration\ConfigurationLoader;
21 18
 use Zicht\Tool\Container\Container;
Please login to merge, or discard this patch.
src/Zicht/Tool/Command/Descriptor/TextDescriptor.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@
 block discarded – undo
70 70
      * the former representing the options that are hidden.
71 71
      *
72 72
      * @param \Symfony\Component\Console\Input\InputDefinition $definition
73
-     * @return array
73
+     * @return InputDefinition[]
74 74
      */
75 75
     public function splitDefinition(InputDefinition $definition)
76 76
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 
4 4
 use Symfony\Component\Console\Application;
5 5
 use Symfony\Component\Console\Command\Command;
6
-use Symfony\Component\Console\Input\InputArgument;
7 6
 use Symfony\Component\Console\Input\InputDefinition;
8 7
 use Symfony\Component\Console\Input\InputOption;
9 8
 use Symfony\Component\Console\Descriptor\TextDescriptor as BaseDescriptor;
Please login to merge, or discard this patch.
src/Zicht/Tool/Command/TaskCommand.php 1 patch
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -69,6 +69,10 @@  discard block
 block discarded – undo
69 69
         }
70 70
     }
71 71
 
72
+    /**
73
+     * @param string $shortcut
74
+     * @param string $help
75
+     */
72 76
     public function addOption($name, $shortcut = null, $mode = null, $help = null, $default = null)
73 77
     {
74 78
         $helpTag = ($mode === InputOption::VALUE_NONE) ? "--$name" : "--$name=" . strtoupper($name);
@@ -104,6 +108,11 @@  discard block
 block discarded – undo
104 108
     }
105 109
 
106 110
 
111
+    /**
112
+     * @param string $name
113
+     *
114
+     * @return string
115
+     */
107 116
     protected function nameToVar($name)
108 117
     {
109 118
         return str_replace('-', '_', $name);
Please login to merge, or discard this patch.
src/Zicht/Tool/Configuration/PathDefaultFileLocator.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
     /**
31 31
      * Construct the locator based on the passed environment variable.
32 32
      *
33
-     * @param array|string $envName
33
+     * @param string $envName
34 34
      * @param array $defaultPaths
35 35
      */
36 36
     public function __construct($envName, $defaultPaths = array())
Please login to merge, or discard this patch.
src/Zicht/Tool/Container/Container.php 2 patches
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -200,7 +200,7 @@  discard block
 block discarded – undo
200 200
      * @param array $context
201 201
      * @param array $path
202 202
      * @param bool $require
203
-     * @return mixed
203
+     * @return string
204 204
      *
205 205
      * @throws \RuntimeException
206 206
      * @throws \InvalidArgumentException
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
      *
223 223
      * @param array $id
224 224
      * @param bool $required
225
-     * @return mixed
225
+     * @return string
226 226
      *
227 227
      * @throws \RuntimeException
228 228
      * @throws CircularReferenceException
@@ -389,7 +389,7 @@  discard block
 block discarded – undo
389 389
      * @param string $expression
390 390
      * @param string &$code
391 391
      *
392
-     * @return mixed
392
+     * @return string
393 393
      */
394 394
     public function evaluate($expression, &$code = null)
395 395
     {
@@ -496,7 +496,7 @@  discard block
 block discarded – undo
496 496
      * Execute a command. This is a wrapper for 'exec', so that a task prefixed with '@' can be passed as well.
497 497
      *
498 498
      * @param string $cmd
499
-     * @return int
499
+     * @return string|null
500 500
      */
501 501
     public function cmd($cmd)
502 502
     {
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -9,16 +9,13 @@
 block discarded – undo
9 9
 use Symfony\Component\Console\Command\Command;
10 10
 use Symfony\Component\Console\Output\NullOutput;
11 11
 use Symfony\Component\Console\Output\OutputInterface;
12
-
13 12
 use Zicht\Tool\Debug;
14 13
 use Zicht\Tool\PropertyPath\PropertyAccessor;
15 14
 use Zicht\Tool\PluginInterface;
16 15
 use Zicht\Tool\Script\Compiler as ScriptCompiler;
17
-use Zicht\Tool\Script;
18 16
 use Zicht\Tool\Util;
19 17
 use Zicht\Tool\Script\Parser\Expression as ExpressionParser;
20 18
 use Zicht\Tool\Script\Tokenizer\Expression as ExpressionTokenizer;
21
-
22 19
 use UnexpectedValueException;
23 20
 
24 21
 /**
Please login to merge, or discard this patch.
src/Zicht/Tool/Container/ContainerBuilder.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -188,7 +188,7 @@
 block discarded – undo
188 188
      *
189 189
      * @param array $path
190 190
      * @param string $node
191
-     * @return \Zicht\Tool\Script\Node\Task\OptNode
191
+     * @return SetNode
192 192
      */
193 193
     public function createSetNode($path, $node)
194 194
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -11,7 +11,6 @@
 block discarded – undo
11 11
 use Zicht\Tool\Script\Node\Task\OptNode;
12 12
 use Zicht\Tool\Script\Compiler;
13 13
 use Zicht\Tool\Script\Node\Task\SetNode;
14
-use Zicht\Tool\Script\Parser;
15 14
 use Zicht\Tool\Debug;
16 15
 use Zicht\Tool\Script\Parser\Expression as ExpressionParser;
17 16
 use Zicht\Tool\Script\Tokenizer\Expression as ExpressionTokenizer;
Please login to merge, or discard this patch.
src/Zicht/Tool/Container/Declaration.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@
 block discarded – undo
23 23
      * Constructor.
24 24
      *
25 25
      * @param array $path
26
-     * @param mixed $value
26
+     * @param null|Node $value
27 27
      */
28 28
     public function __construct(array $path, Node $value = null)
29 29
     {
Please login to merge, or discard this patch.
src/Zicht/Tool/Container/Executor.php 2 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -30,6 +30,7 @@
 block discarded – undo
30 30
      *
31 31
      * @param string $cmd
32 32
      * @param null &$captureOutput
33
+     * @param string $captureOutput
33 34
      * @return int
34 35
      *
35 36
      * @throws ExecutionAbortedException
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -7,7 +7,6 @@
 block discarded – undo
7 7
 namespace Zicht\Tool\Container;
8 8
 
9 9
 use Symfony\Component\Process\Process;
10
-use Symfony\Component\Process\ProcessBuilder;
11 10
 
12 11
 /**
13 12
  * Runs the commands in the shell.
Please login to merge, or discard this patch.
src/Zicht/Tool/Container/Task.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -7,7 +7,6 @@
 block discarded – undo
7 7
 namespace Zicht\Tool\Container;
8 8
 
9 9
 use Zicht\Tool\Script\Buffer;
10
-use Zicht\Tool\Script\Node\Node;
11 10
 use Zicht\Tool\Util;
12 11
 
13 12
 /**
Please login to merge, or discard this patch.