ErrorHandler - Code Metrics - zicht/z - Measure and Improve Code Quality continuously with Scrutinizer

ErrorHandler A
last analyzed 2017-06-16 11:38 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	80
Duplicated Lines	12.5 %

Coupling/Cohesion

Components	0
Dependencies	5

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	18
lcom	0
cbo	5
dl	10
loc	80
ccs	0
cts	51
cp	0
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
C	__invoke()	10	49	17

How to fix Duplicated Code

<?php
/**
 * @author Gerard van Helden <[email protected]>
 * @copyright Zicht Online <http://zicht.nl>
 */

namespace Zicht\Tool;

use Symfony\Component\Console\Helper\DialogHelper;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Input\InputInterface;
use Zicht\Tool\Container\ExecutionAbortedException;

/**
 * Wrapper class for handling errors
 */
class ErrorHandler
{
    private $input;
    private $output;
    private $dialog;
    private $repeating = array();
    private $continueAlways = false;

    /**
     * Constructor
     *
     * @param InputInterface $input
     * @param OutputInterface $output
     */
    public function __construct($input, $output)
    {
        $this->input = $input;
        $this->output = $output;
        $this->dialog = new DialogHelper();

    }

    /**
     * Handler implementation which allows for some user interaction based on emitted user errors.
     *
     * @param int $err
     * @param string $errstr
     * @return void
     *
     * @throws Container\ExecutionAbortedException
     */
    public function __invoke($err, $errstr)
    {
        if (in_array($errstr, $this->repeating)) {
            return;
        }
        $this->repeating[] = $errstr;
        if (
            error_reporting() & E_USER_DEPRECATED
            || error_reporting() & E_USER_NOTICE
            || error_reporting() & E_USER_WARNING
            || error_reporting() & E_RECOVERABLE_ERROR
        ) {
            switch ($err) {
                case E_USER_WARNING:
                    fprintf(STDERR, $this->output->getFormatter()->format("<comment>[WARNING]</comment>   $errstr\n"));

                    if (!$this->continueAlways) {
                        do {
                            if ($this->input->isInteractive()) {
                                $answer = $this->dialog->ask($this->output, "Continue anyway? (y)es, (n)o, (a)lways ", false);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                            } else {
                                $answer = 'n';
                            }
                        } while (!in_array(strtolower($answer), array('y', 'n', 'a')));

                        if ($answer === 'n') {
                            throw new ExecutionAbortedException("Aborted by user request");
                        } elseif ($answer === 'a') {
                            $this->continueAlways = true;
                        }
                    }


                    break;
                case E_USER_NOTICE:

                    if ($this->output->getVerbosity() >= OutputInterface::VERBOSITY_NORMAL) {
                        fprintf(STDERR, $this->output->getFormatter()->format("<comment>[NOTICE]</comment>   $errstr\n"));
                    }
                    break;
                case E_USER_DEPRECATED:

                    if ($this->output->getVerbosity() >= OutputInterface::VERBOSITY_NORMAL) {
                        fprintf(STDERR, $this->output->getFormatter()->format("<comment>[DEPRECATED]</comment>   $errstr\n"));
                    }
                    break;
                case E_RECOVERABLE_ERROR:
                    throw new \ErrorException($errstr);
            }
        }
    }
}


1		<?php
2		/**
3		* @author Gerard van Helden <[email protected]>
4		* @copyright Zicht Online <http://zicht.nl>
5		*/
6
7		namespace Zicht\Tool;
8
9		use Symfony\Component\Console\Helper\DialogHelper;
10		use Symfony\Component\Console\Output\OutputInterface;
11		use Symfony\Component\Console\Input\InputInterface;
12		use Zicht\Tool\Container\ExecutionAbortedException;
13
14		/**
15		* Wrapper class for handling errors
16		*/
17		class ErrorHandler
18		{
19		private $input;
20		private $output;
21		private $dialog;
22		private $repeating = array();
23		private $continueAlways = false;
24
25		/**
26		* Constructor
27		*
28		* @param InputInterface $input
29		* @param OutputInterface $output
30		*/
31		public function __construct($input, $output)
32		{
33		$this->input = $input;
34		$this->output = $output;
35		$this->dialog = new DialogHelper();
		0 ignored issues – show Deprecated Code introduced 2017-01-21 13:11 UTC by Report Bug Copy Issue Report The class `Symfony\Component\Console\Helper\DialogHelper` has been deprecated with message: since version 2.5, to be removed in 3.0. Use {@link \Symfony\Component\Console\Helper\QuestionHelper} instead. This class, trait or interface has been deprecated. The supplier of the file has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the type will be removed from the class and what other constant to use instead. Loading history...
36		}
37
38		/**
39		* Handler implementation which allows for some user interaction based on emitted user errors.
40		*
41		* @param int $err
42		* @param string $errstr
43		* @return void
44		*
45		* @throws Container\ExecutionAbortedException
46		*/
47		public function __invoke($err, $errstr)
48		{
49		if (in_array($errstr, $this->repeating)) {
50		return;
51		}
52		$this->repeating[] = $errstr;
53		if (
54		error_reporting() & E_USER_DEPRECATED
55		\|\| error_reporting() & E_USER_NOTICE
56		\|\| error_reporting() & E_USER_WARNING
57		\|\| error_reporting() & E_RECOVERABLE_ERROR
58		) {
59		switch ($err) {
60		case E_USER_WARNING:
61		fprintf(STDERR, $this->output->getFormatter()->format("<comment>[WARNING]</comment> $errstr\n"));
62
63		if (!$this->continueAlways) {
64		do {
65		if ($this->input->isInteractive()) {
66		$answer = $this->dialog->ask($this->output, "Continue anyway? (y)es, (n)o, (a)lways ", false);
		0 ignored issues – show Documentation introduced 2017-01-22 19:11 UTC by Report Bug Copy Issue Report `false` is of type `boolean`, but the function expects a `string\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
67		} else {
68		$answer = 'n';
69		}
70		} while (!in_array(strtolower($answer), array('y', 'n', 'a')));
71
72		if ($answer === 'n') {
73		throw new ExecutionAbortedException("Aborted by user request");
74		} elseif ($answer === 'a') {
75		$this->continueAlways = true;
76		}
77		}
78
79
80		break;
81	View Code Duplication	case E_USER_NOTICE:
		0 ignored issues – show Duplication introduced 2017-01-21 13:11 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
82		if ($this->output->getVerbosity() >= OutputInterface::VERBOSITY_NORMAL) {
83		fprintf(STDERR, $this->output->getFormatter()->format("<comment>[NOTICE]</comment> $errstr\n"));
84		}
85		break;
86	View Code Duplication	case E_USER_DEPRECATED:
		0 ignored issues – show Duplication introduced 2017-01-21 13:11 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
87		if ($this->output->getVerbosity() >= OutputInterface::VERBOSITY_NORMAL) {
88		fprintf(STDERR, $this->output->getFormatter()->format("<comment>[DEPRECATED]</comment> $errstr\n"));
89		}
90		break;
91		case E_RECOVERABLE_ERROR:
92		throw new \ErrorException($errstr);
93		}
94		}
95		}
96		}
97

zicht / z

ErrorHandler A last analyzed 2017-06-16 11:38 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

ErrorHandler A
last analyzed 2017-06-16 11:38 UTC