Listener::onKernelResponse() - Code Metrics - Inspection of "Merge pull request #37 from zicht/feature/cleanup" - zicht/url-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — release/3.x ( 447600...4272fa )

unknown

created 2018-06-18 09:57 UTC

Listener::onKernelResponse() A

↳ Parent: Listener

Complexity

Conditions	4
Paths	3

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	5
nc	3
nop	1
dl	0
loc	8
rs	9.2
c	0
b	0
f	0

<?php
/**
 * @author Gerard van Helden <[email protected]>
 * @copyright Zicht Online <http://zicht.nl>
 */
namespace Zicht\Bundle\UrlBundle\Logging;

use Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent;
use Symfony\Component\HttpKernel\Event\FilterResponseEvent;
use Symfony\Component\HttpKernel\HttpKernelInterface;

/**
 * Listener used for logging
 */
class Listener
{
    /**
     * @var \Zicht\Bundle\UrlBundle\Entity\ErrorLog
     */
    protected $log = null;

    /**
     * Construct with the passed logger service
     *
     * @param Logging $logging
     */
    public function __construct(Logging $logging)
    {
        $this->logging = $logging;

    }


    /**
     * Create log entry if a kernelexception occurs.
     *
     * @param \Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent $event
     * @return void
     */
    public function onKernelException(GetResponseForExceptionEvent $event)
    {
        $this->log = $this->logging->createLog($event->getRequest(), $event->getException()->getMessage());
    }

    /**
     * Save the log entry (if any) if the error response about to be sent is not handled otherwise.
     *
     * @param \Symfony\Component\HttpKernel\Event\FilterResponseEvent $e
     * @return void
     */
    public function onKernelResponse(FilterResponseEvent $e)
    {
        if (isset($this->log)) {
            if ($e->getRequestType() === HttpKernelInterface::MASTER_REQUEST
                && ($status = $e->getResponse()->getStatusCode()) >= 400
            ) {
                $this->log->setStatus($status);
                $this->logging->flush($this->log);
            }
        }
    }
}


1			<?php
2			/**
3			* @author Gerard van Helden <[email protected]>
4			* @copyright Zicht Online <http://zicht.nl>
5			*/
6			namespace Zicht\Bundle\UrlBundle\Logging;
7
8			use Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent;
9			use Symfony\Component\HttpKernel\Event\FilterResponseEvent;
10			use Symfony\Component\HttpKernel\HttpKernelInterface;
11
12			/**
13			* Listener used for logging
14			*/
15			class Listener
16			{
17			/**
18			* @var \Zicht\Bundle\UrlBundle\Entity\ErrorLog
19			*/
20			protected $log = null;
21
22			/**
23			* Construct with the passed logger service
24			*
25			* @param Logging $logging
26			*/
27			public function __construct(Logging $logging)
28			{
29			$this->logging = $logging;
			0 ignored issues – show Bug Best Practice introduced 2018-01-19 11:22 UTC by Report Bug Copy Issue Report The property `logging` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
30			}
31
32
33			/**
34			* Create log entry if a kernelexception occurs.
35			*
36			* @param \Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent $event
37			* @return void
38			*/
39			public function onKernelException(GetResponseForExceptionEvent $event)
40			{
41			$this->log = $this->logging->createLog($event->getRequest(), $event->getException()->getMessage());
42			}
43
44			/**
45			* Save the log entry (if any) if the error response about to be sent is not handled otherwise.
46			*
47			* @param \Symfony\Component\HttpKernel\Event\FilterResponseEvent $e
48			* @return void
49			*/
50			public function onKernelResponse(FilterResponseEvent $e)
51			{
52			if (isset($this->log)) {
53			if ($e->getRequestType() === HttpKernelInterface::MASTER_REQUEST
54			&& ($status = $e->getResponse()->getStatusCode()) >= 400
55			) {
56			$this->log->setStatus($status);
57			$this->logging->flush($this->log);
58			}
59			}
60			}
61			}
62

zicht / url-bundle

Push — release/3.x ( 447600...4272fa )

Listener::onKernelResponse() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like