CompositeTranslator::translateValueOutput() - Code Metrics - Inspection of "Fix PHPCS for src-dir and make tests working" - zicht/url-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — release/4.x (#44)

by Erik

created 2018-11-12 11:30 UTC

CompositeTranslator::translateValueOutput() A

↳ Parent: CompositeTranslator

Complexity

Conditions	3
Paths	3

Size

Total Lines	9
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
cc	3
eloc	4
nc	3
nop	2
dl	0
loc	9
ccs	0
cts	8
cp	0
crap	12
rs	10
c	0
b	0
f	0

<?php

/**
 * @author Gerard van Helden <[email protected]>
 * @copyright Zicht Online <http://zicht.nl>
 */

namespace Zicht\Bundle\UrlBundle\Url\Params\Translator;

use Zicht\Bundle\UrlBundle\Url\Params\Translator;

/**
 * Composite translator which delegates to the translator that translates a key.
 */
class CompositeTranslator implements Translator
{
    protected $translators = [];

    /**
     * @{inheritDoc}
     */
    public function translateKeyInput($keyName)
    {
        foreach ($this->translators as $translator) {
            if (false !== ($translation = $translator->translateKeyInput($keyName))) {
                return $translation;
            }
        }

        return false;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }


    /**
     * @{inheritDoc}
     */
    public function translateValueInput($keyName, $value)
    {
        foreach ($this->translators as $translator) {
            if (false !== ($translation = $translator->translateValueInput($keyName, $value))) {
                return $translation;
            }
        }

        return false;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }


    /**
     * @{inheritDoc}
     */
    public function translateKeyOutput($keyName)
    {
        foreach ($this->translators as $translator) {
            if (false !== ($translation = $translator->translateKeyOutput($keyName))) {
                return $translation;
            }
        }

        return false;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }


    /**
     * @{inheritDoc}
     */
    public function translateValueOutput($keyName, $value)
    {
        foreach ($this->translators as $translator) {
            if (false !== ($translation = $translator->translateValueOutput($keyName, $value))) {
                return $translation;
            }
        }

        return false;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }


    /**
     * @{inheritDoc}
     */
    public function add(Translator $translator)
    {
        $this->translators[] = $translator;

        return $this;
    }
}


1			<?php
2
3			/**
4			* @author Gerard van Helden <[email protected]>
5			* @copyright Zicht Online <http://zicht.nl>
6			*/
7
8			namespace Zicht\Bundle\UrlBundle\Url\Params\Translator;
9
10			use Zicht\Bundle\UrlBundle\Url\Params\Translator;
11
12			/**
13			* Composite translator which delegates to the translator that translates a key.
14			*/
15			class CompositeTranslator implements Translator
16			{
17			protected $translators = [];
18
19			/**
20			* @{inheritDoc}
21			*/
22			public function translateKeyInput($keyName)
23			{
24			foreach ($this->translators as $translator) {
25			if (false !== ($translation = $translator->translateKeyInput($keyName))) {
26			return $translation;
27			}
28			}
29
30			return false;
			0 ignored issues – show Bug Best Practice introduced 2018-01-19 11:22 UTC by Report Bug Copy Issue Report The expression `return false` returns the type `false` which is incompatible with the return type mandated by `Zicht\Bundle\UrlBundle\U...or::translateKeyInput()` of `string`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
31			}
32
33
34			/**
35			* @{inheritDoc}
36			*/
37			public function translateValueInput($keyName, $value)
38			{
39			foreach ($this->translators as $translator) {
40			if (false !== ($translation = $translator->translateValueInput($keyName, $value))) {
41			return $translation;
42			}
43			}
44
45			return false;
			0 ignored issues – show Bug Best Practice introduced 2018-01-19 11:22 UTC by Report Bug Copy Issue Report The expression `return false` returns the type `false` which is incompatible with the return type mandated by `Zicht\Bundle\UrlBundle\U...::translateValueInput()` of `string`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
46			}
47
48
49			/**
50			* @{inheritDoc}
51			*/
52			public function translateKeyOutput($keyName)
53			{
54			foreach ($this->translators as $translator) {
55			if (false !== ($translation = $translator->translateKeyOutput($keyName))) {
56			return $translation;
57			}
58			}
59
60			return false;
			0 ignored issues – show Bug Best Practice introduced 2018-01-19 11:22 UTC by Report Bug Copy Issue Report The expression `return false` returns the type `false` which is incompatible with the return type mandated by `Zicht\Bundle\UrlBundle\U...r::translateKeyOutput()` of `string`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
61			}
62
63
64			/**
65			* @{inheritDoc}
66			*/
67			public function translateValueOutput($keyName, $value)
68			{
69			foreach ($this->translators as $translator) {
70			if (false !== ($translation = $translator->translateValueOutput($keyName, $value))) {
71			return $translation;
72			}
73			}
74
75			return false;
			0 ignored issues – show Bug Best Practice introduced 2018-01-19 11:22 UTC by Report Bug Copy Issue Report The expression `return false` returns the type `false` which is incompatible with the return type mandated by `Zicht\Bundle\UrlBundle\U...:translateValueOutput()` of `string`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
76			}
77
78
79			/**
80			* @{inheritDoc}
81			*/
82			public function add(Translator $translator)
83			{
84			$this->translators[] = $translator;
85
86			return $this;
87			}
88			}
89

zicht / url-bundle

Pull Request — release/4.x (#44)

CompositeTranslator::translateValueOutput() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like