StaticTranslator - Code Metrics - zicht/url-bundle - Measure and Improve Code Quality continuously with Scrutinizer

StaticTranslator A
last analyzed 2020-01-22 16:05 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	88
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	3
Bugs	1	Features	0

Metric	Value
eloc	23
c	3
b	1
f	0
dl	0
loc	88
ccs	26
cts	26
cp	1
rs	10
wmc	12

6 Methods

Rating	Name	Size	Complexity
A	translateValueInput()	9	3
A	translateValueOutput()	9	3
A	__construct()	5	1
A	translateKeyInput()	7	2
A	translateKeyOutput()	7	2
A	addTranslation()	4	1

<?php
/**
 * @author Gerard van Helden <[email protected]>
 * @copyright Zicht Online <http://zicht.nl>
 */

namespace Zicht\Bundle\UrlBundle\Url\Params\Translator;

use Zicht\Bundle\UrlBundle\Url\Params\Translator;

/**
 * Static translator which holds mappings for keys and values.
 */
class StaticTranslator implements Translator
{
    protected $keyName;
    protected $keyTranslation;
    protected $valueTranslations;

    /**
     * Constructor.
     *
     * @param string $keyName
     * @param string $keyTranslation
     * @param array $valueTranslations
     */
    public function __construct($keyName, $keyTranslation, $valueTranslations = array())
    {
        $this->keyName           = $keyName;
        $this->keyTranslation    = $keyTranslation;
        $this->valueTranslations = $valueTranslations;
    }


    /**
     * @{inheritDoc}
     */
    public function translateKeyInput($keyTranslation)
    {
        if ($keyTranslation == $this->keyTranslation) {
            return $this->keyName;
        }

        return false;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }


    /**
     * @{inheritDoc}
     */
    public function translateValueInput($keyTranslation, $valueTranslation)
    {
        if ($keyTranslation == $this->keyTranslation) {
            if (false !== ($value = array_search($valueTranslation, $this->valueTranslations))) {
                return $value;
            }
        }

        return false;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }


    /**
     * @{inheritDoc}
     */
    public function translateKeyOutput($keyName)
    {
        if ($keyName == $this->keyName) {
            return $this->keyTranslation;
        }

        return false;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }


    /**
     * @{inheritDoc}
     */
    public function translateValueOutput($keyName, $value)
    {
        if ($keyName == $this->keyName) {
            if (isset($this->valueTranslations[$value])) {
                return $this->valueTranslations[$value];
            }
        }

        return false;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }


    /**
     * Adds a value translation
     *
     * @param string $in
     * @param string $out
     * @return self
     */
    public function addTranslation($in, $out)
    {
        $this->valueTranslations[$in] = $out;
        return $this;
    }
}


1		<?php
2		/**
3		* @author Gerard van Helden <[email protected]>
4		* @copyright Zicht Online <http://zicht.nl>
5		*/
6
7		namespace Zicht\Bundle\UrlBundle\Url\Params\Translator;
8
9		use Zicht\Bundle\UrlBundle\Url\Params\Translator;
10
11		/**
12		* Static translator which holds mappings for keys and values.
13		*/
14		class StaticTranslator implements Translator
15		{
16		protected $keyName;
17		protected $keyTranslation;
18		protected $valueTranslations;
19
20		/**
21		* Constructor.
22		*
23		* @param string $keyName
24		* @param string $keyTranslation
25		* @param array $valueTranslations
26		*/
27	6	public function __construct($keyName, $keyTranslation, $valueTranslations = array())
28		{
29	6	$this->keyName = $keyName;
30	6	$this->keyTranslation = $keyTranslation;
31	6	$this->valueTranslations = $valueTranslations;
32	6	}
33
34
35		/**
36		* @{inheritDoc}
37		*/
38	5	public function translateKeyInput($keyTranslation)
39		{
40	5	if ($keyTranslation == $this->keyTranslation) {
41	5	return $this->keyName;
42		}
43
44	3	return false;
		0 ignored issues – show Bug Best Practice introduced 2018-01-19 11:22 UTC by Report Bug Copy Issue Report The expression `return false` returns the type `false` which is incompatible with the return type mandated by `Zicht\Bundle\UrlBundle\U...or::translateKeyInput()` of `string`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
45		}
46
47
48		/**
49		* @{inheritDoc}
50		*/
51	3	public function translateValueInput($keyTranslation, $valueTranslation)
52		{
53	3	if ($keyTranslation == $this->keyTranslation) {
54	3	if (false !== ($value = array_search($valueTranslation, $this->valueTranslations))) {
55	3	return $value;
56		}
57		}
58
59	2	return false;
		0 ignored issues – show Bug Best Practice introduced 2018-01-19 11:22 UTC by Report Bug Copy Issue Report The expression `return false` returns the type `false` which is incompatible with the return type mandated by `Zicht\Bundle\UrlBundle\U...::translateValueInput()` of `string`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
60		}
61
62
63		/**
64		* @{inheritDoc}
65		*/
66	5	public function translateKeyOutput($keyName)
67		{
68	5	if ($keyName == $this->keyName) {
69	5	return $this->keyTranslation;
70		}
71
72	3	return false;
		0 ignored issues – show Bug Best Practice introduced 2018-01-19 11:22 UTC by Report Bug Copy Issue Report The expression `return false` returns the type `false` which is incompatible with the return type mandated by `Zicht\Bundle\UrlBundle\U...r::translateKeyOutput()` of `string`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
73		}
74
75
76		/**
77		* @{inheritDoc}
78		*/
79	3	public function translateValueOutput($keyName, $value)
80		{
81	3	if ($keyName == $this->keyName) {
82	3	if (isset($this->valueTranslations[$value])) {
83	3	return $this->valueTranslations[$value];
84		}
85		}
86
87	2	return false;
		0 ignored issues – show Bug Best Practice introduced 2018-01-19 11:22 UTC by Report Bug Copy Issue Report The expression `return false` returns the type `false` which is incompatible with the return type mandated by `Zicht\Bundle\UrlBundle\U...:translateValueOutput()` of `string`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
88		}
89
90
91		/**
92		* Adds a value translation
93		*
94		* @param string $in
95		* @param string $out
96		* @return self
97		*/
98	1	public function addTranslation($in, $out)
99		{
100	1	$this->valueTranslations[$in] = $out;
101	1	return $this;
102		}
103		}
104

zicht / url-bundle

StaticTranslator A last analyzed 2020-01-22 16:05 UTC

Complexity

Size/Duplication

Test Coverage

Importance

6 Methods

Duplication Side-by-Side

Filter issues like

StaticTranslator A
last analyzed 2020-01-22 16:05 UTC