Zicht\Bundle\UrlBundle\Aliasing\DefaultAliasingStrategy

Complexity

Total Complexity

8

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	4
Bugs	0	Features	3

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	toAlias()	0	3	1
A	generatePublicAlias()	0	19	6

<?php
/**
 * @author Gerard van Helden <gerard@zicht.nl>
 * @copyright Zicht Online <http://zicht.nl>
 */
namespace Zicht\Bundle\UrlBundle\Aliasing;
 
use Zicht\Util\Str;

/**
 * An aliasing strategy which simply puts the systemized title at the specified base path (default is root)
 */
class DefaultAliasingStrategy implements AliasingStrategy
{
    /**
     * Construct with the specified base path
     *
     * @param string $basePath
     */
    public function __construct($basePath = '/')
    {
        $this->basePath = $basePath;

The property basePath does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }


    /**
     * Returns the calculated public alias for the specified object.
     *
     * @param string $subject
     * @param string $currentAlias
     * @return null|string
     * @throws \InvalidArgumentException
     */
    public function generatePublicAlias($subject, $currentAlias = '')
    {
        if (is_object($subject)) {

The condition is_object($subject) is always false.

            if ($subject instanceof Aliasable) {
                $subject = (string)$subject->getAliasTitle();
            } elseif (method_exists($subject, 'getTitle')) {
                $subject = (string)$subject->getTitle();
            } else {
                $subject = (string)$subject;
            }
        }
        if (!is_string($subject)) {

The condition is_string($subject) is always true.

            throw new \InvalidArgumentException("Expected a string or object as subject, got " . gettype($subject));
        }

        if ($alias = $this->toAlias($subject)) {
            return $this->basePath . $alias;
        }
        return null;
    }


    /**
     * Systemizes the specified string.
     *
     * @param string $title
     * @return string
     */
    protected function toAlias($title)
    {
        return Str::systemize($title);
    }
}