ContentItemTypeType::buildView() - Code Metrics - Inspection of "Fixed bug in content item type type" - zicht/page-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — release/2.5.x (#6)

by Muhammed

created 2017-05-18 14:17 UTC

ContentItemTypeType::buildView() C

↳ Parent: ContentItemTypeType

Complexity

Conditions	11
Paths	13

Size

Total Lines	34
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	34
rs	5.2653
c	0
b	0
f	0
cc	11
eloc	19
nc	13
nop	3

How to fix Complexity

<?php
/**
 * @author Gerard van Helden <[email protected]>
 * @copyright Zicht Online <http://zicht.nl>
 */
namespace Zicht\Bundle\PageBundle\Type;

use Sonata\AdminBundle\Admin\Pool;
use Symfony\Component\Form\AbstractType;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\Form\FormView;
use Symfony\Component\Form\FormInterface;
use Symfony\Component\OptionsResolver\OptionsResolverInterface;
use Symfony\Component\Routing\Exception\InvalidParameterException;
use Symfony\Component\Routing\Exception\MissingMandatoryParametersException;
use Zicht\Bundle\PageBundle\Model\ContentItemContainer;
use Zicht\Util\Str;

/**
 * Provides a "type" dropdown for creating content items, and a "edit link" for editing content items
 * that have their own admin.
 */
class ContentItemTypeType extends AbstractType
{
    /**
     * Constructor
     *
     * @param \Sonata\AdminBundle\Admin\Pool $sonata
     * @param string $contentItemClass
     */
    public function __construct($contentItemClass, Pool $sonata = null)
    {
        $this->contentItemClass = $contentItemClass;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->sonata = $sonata;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }


    /**
     * @{inheritDoc}
     */
    public function setDefaultOptions(OptionsResolverInterface $resolver)
    {
        $resolver->setDefaults(
            array(
                'inherit_data' => true,
                'data_class' => $this->contentItemClass,
                'container' => '',
                'translation_domain' => 'admin'
            )
        );
    }


    /**
     * @{inheritDoc}
     */
    public function buildForm(FormBuilderInterface $builder, array $options)
    {
        if ($options['container']) {
            $page = $options['container'];
            $choiceFilter = function ($choices) use ($page) {
                $ret = array();
                if ($page instanceof ContentItemContainer && null !== $page->getContentItemMatrix()) {
                    $types = $page->getContentItemMatrix()->getTypes();

                    foreach ($choices as $className => $name) {
                        if (in_array($className, $types)) {
                            $ret[$className] = $name;
                        }
                    }
                } else {
                    return $choices;
                }
                return $ret;
            };
        } else {
            $choiceFilter = null;
        }
        $builder
            ->add(
                'convertToType',
                'zicht_discriminator_map',
                array(
                    'entity' => $this->contentItemClass,
                    'choice_filter' => $choiceFilter
                )
            );
    }


    /**
     * @{inheritDoc}
     */
    public function buildView(FormView $view, FormInterface $form, array $options)
    {
        if (isset($view->vars['sonata_admin']['admin'])) {
            $genericAdmin = $view->vars['sonata_admin']['admin'];

            $parentAdmin = $genericAdmin->getParent();

            $subject = $form->getParent()->getData();

            $view->vars['type'] = null;
            $view->vars['edit_url'] = null;


            try {
                if ($subject->getRegion() !== null && $typeAdmin = $this->sonata->getAdminByClass(get_class($subject))) {
                    $view->vars['type']= Str::humanize(Str::classname($subject->getConvertToType()));
                    $childAdmin = $this->sonata->getAdminByAdminCode($parentAdmin->getCode() . '|' . $typeAdmin->getCode());
                    $childAdmin->setRequest($genericAdmin->getRequest());

                    if ($subject && $subject->getPage() && $subject->getPage()->getId()) {
                        try {
                            $view->vars['edit_url'] = $childAdmin->generateObjectUrl('edit', $subject);
                        } catch (InvalidParameterException $e) {
                            //2.2 edit url not needed when generating other admins (this is done in the POST of the sonata_collection_type)
                        } catch (MissingMandatoryParametersException $e) {
                            //>= 2.3
                        } catch (\Exception $e) {
                        }
                    }
                }
            } catch (\RuntimeException $e) {
            }
        }
    }


    /**
     * Returns the name of this type.
     *
     * @return string The name of this type
     */
    public function getName()
    {
        return 'zicht_content_item_type';
    }
}


1			<?php
2			/**
3			* @author Gerard van Helden <[email protected]>
4			* @copyright Zicht Online <http://zicht.nl>
5			*/
6			namespace Zicht\Bundle\PageBundle\Type;
7
8			use Sonata\AdminBundle\Admin\Pool;
9			use Symfony\Component\Form\AbstractType;
10			use Symfony\Component\Form\FormBuilderInterface;
11			use Symfony\Component\Form\FormView;
12			use Symfony\Component\Form\FormInterface;
13			use Symfony\Component\OptionsResolver\OptionsResolverInterface;
14			use Symfony\Component\Routing\Exception\InvalidParameterException;
15			use Symfony\Component\Routing\Exception\MissingMandatoryParametersException;
16			use Zicht\Bundle\PageBundle\Model\ContentItemContainer;
17			use Zicht\Util\Str;
18
19			/**
20			* Provides a "type" dropdown for creating content items, and a "edit link" for editing content items
21			* that have their own admin.
22			*/
23			class ContentItemTypeType extends AbstractType
24			{
25			/**
26			* Constructor
27			*
28			* @param \Sonata\AdminBundle\Admin\Pool $sonata
29			* @param string $contentItemClass
30			*/
31			public function __construct($contentItemClass, Pool $sonata = null)
32			{
33			$this->contentItemClass = $contentItemClass;
			0 ignored issues – show Bug introduced 2017-03-15 11:29 UTC by Report Bug Copy Issue Report The property `contentItemClass` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
34			$this->sonata = $sonata;
			0 ignored issues – show Bug introduced 2017-03-15 11:29 UTC by Report Bug Copy Issue Report The property `sonata` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
35			}
36
37
38			/**
39			* @{inheritDoc}
40			*/
41			public function setDefaultOptions(OptionsResolverInterface $resolver)
42			{
43			$resolver->setDefaults(
44			array(
45			'inherit_data' => true,
46			'data_class' => $this->contentItemClass,
47			'container' => '',
48			'translation_domain' => 'admin'
49			)
50			);
51			}
52
53
54			/**
55			* @{inheritDoc}
56			*/
57			public function buildForm(FormBuilderInterface $builder, array $options)
58			{
59			if ($options['container']) {
60			$page = $options['container'];
61			$choiceFilter = function ($choices) use ($page) {
62			$ret = array();
63			if ($page instanceof ContentItemContainer && null !== $page->getContentItemMatrix()) {
64			$types = $page->getContentItemMatrix()->getTypes();
65
66			foreach ($choices as $className => $name) {
67			if (in_array($className, $types)) {
68			$ret[$className] = $name;
69			}
70			}
71			} else {
72			return $choices;
73			}
74			return $ret;
75			};
76			} else {
77			$choiceFilter = null;
78			}
79			$builder
80			->add(
81			'convertToType',
82			'zicht_discriminator_map',
83			array(
84			'entity' => $this->contentItemClass,
85			'choice_filter' => $choiceFilter
86			)
87			);
88			}
89
90
91			/**
92			* @{inheritDoc}
93			*/
94			public function buildView(FormView $view, FormInterface $form, array $options)
95			{
96			if (isset($view->vars['sonata_admin']['admin'])) {
97			$genericAdmin = $view->vars['sonata_admin']['admin'];
98
99			$parentAdmin = $genericAdmin->getParent();
100
101			$subject = $form->getParent()->getData();
102
103			$view->vars['type'] = null;
104			$view->vars['edit_url'] = null;
105
106
107			try {
108			if ($subject->getRegion() !== null && $typeAdmin = $this->sonata->getAdminByClass(get_class($subject))) {
109			$view->vars['type']= Str::humanize(Str::classname($subject->getConvertToType()));
110			$childAdmin = $this->sonata->getAdminByAdminCode($parentAdmin->getCode() . '\|' . $typeAdmin->getCode());
111			$childAdmin->setRequest($genericAdmin->getRequest());
112
113			if ($subject && $subject->getPage() && $subject->getPage()->getId()) {
114			try {
115			$view->vars['edit_url'] = $childAdmin->generateObjectUrl('edit', $subject);
116			} catch (InvalidParameterException $e) {
117			//2.2 edit url not needed when generating other admins (this is done in the POST of the sonata_collection_type)
118			} catch (MissingMandatoryParametersException $e) {
119			//>= 2.3
120			} catch (\Exception $e) {
121			}
122			}
123			}
124			} catch (\RuntimeException $e) {
125			}
126			}
127			}
128
129
130			/**
131			* Returns the name of this type.
132			*
133			* @return string The name of this type
134			*/
135			public function getName()
136			{
137			return 'zicht_content_item_type';
138			}
139			}
140

zicht / page-bundle

Pull Request — release/2.5.x (#6)

ContentItemTypeType::buildView() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like