SliceIterator::valid() - Code Metrics - Inspection of "[Feature] add interfaces" - zicht/itertools - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#29)

unknown

created 2017-05-05 10:38 UTC

SliceIterator::valid() B

↳ Parent: SliceIterator

Complexity

Conditions	5
Paths	5

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	5

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	5
eloc	10
nc	5
nop	0
dl	0
loc	17
ccs	9
cts	9
cp	1
crap	5
rs	8.8571
c	1
b	0
f	1

<?php
/**
 * @author Boudewijn Schoon <[email protected]>
 * @copyright Zicht Online <http://zicht.nl>
 */

namespace Zicht\Itertools\lib;

use Zicht\Itertools\lib\Interfaces\FiniteIterableInterface;
use Zicht\Itertools\lib\Traits\FiniteIterableTrait;

/**
 * Class SliceIterator
 *
 * @package Zicht\Itertools\lib
 */
class SliceIterator extends \IteratorIterator implements FiniteIterableInterface
{
    use FiniteIterableTrait;

    /** @var integer */
    private $index;

    /** @var integer */
    private $start;

    /** @var null|int */
    private $end;

    /**
     * SliceIterator constructor.
     *
     * @param \Iterator $iterable
     * @param integer $start
     * @param null|integer $end
     */
    public function __construct(\Iterator $iterable, $start, $end = null)
    {
        if ($start < 0 || $end < 0) {
            $length = iterator_count($iterable);
        } else {
            // length is not needed.  still, we will define it for code cleanliness
            $length = 0;
        }

        $this->index = 0;
        $this->start = $start < 0 ? $length + $start : $start;
        $this->end = $end === null ? null : ($end < 0 ? $length + $end : $end);
        parent::__construct($iterable);
    }

    /**
     * @{inheritDoc}
     */
    public function valid()
    {
        while ($this->index < $this->start) {
            if (parent::valid()) {
                $this->index += 1;
                parent::next();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
            } else {
                return false;
            }
        }

        if (null === $this->end || $this->index < $this->end) {
            return parent::valid();
        }

        return false;
    }

    /**
     * @{inheritDoc}
     */
    public function next()
    {
        $this->index += 1;
        parent::next();
    }

    /**
     * @{inheritDoc}
     */
    public function rewind()
    {
        $this->index = 0;
        parent::rewind();
    }
}


1		<?php
2		/**
3		* @author Boudewijn Schoon <[email protected]>
4		* @copyright Zicht Online <http://zicht.nl>
5		*/
6
7		namespace Zicht\Itertools\lib;
8
9		use Zicht\Itertools\lib\Interfaces\FiniteIterableInterface;
10		use Zicht\Itertools\lib\Traits\FiniteIterableTrait;
11
12		/**
13		* Class SliceIterator
14		*
15		* @package Zicht\Itertools\lib
16		*/
17		class SliceIterator extends \IteratorIterator implements FiniteIterableInterface
18		{
19		use FiniteIterableTrait;
20
21		/** @var integer */
22		private $index;
23
24		/** @var integer */
25		private $start;
26
27		/** @var null\|int */
28		private $end;
29
30		/**
31		* SliceIterator constructor.
32		*
33		* @param \Iterator $iterable
34		* @param integer $start
35		* @param null\|integer $end
36		*/
37	25	public function __construct(\Iterator $iterable, $start, $end = null)
38		{
39	25	if ($start < 0 \|\| $end < 0) {
40	9	$length = iterator_count($iterable);
41		} else {
42		// length is not needed. still, we will define it for code cleanliness
43	16	$length = 0;
44		}
45
46	25	$this->index = 0;
47	25	$this->start = $start < 0 ? $length + $start : $start;
48	25	$this->end = $end === null ? null : ($end < 0 ? $length + $end : $end);
49	25	parent::__construct($iterable);
50	25	}
51
52		/**
53		* @{inheritDoc}
54		*/
55	24	public function valid()
56		{
57	24	while ($this->index < $this->start) {
58	9	if (parent::valid()) {
59	9	$this->index += 1;
60	9	parent::next();
		0 ignored issues – show Comprehensibility Bug introduced 2017-01-12 12:49 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`next()` instead of `valid()`). Are you sure this is correct? If so, you might want to change this to `$this->next()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
61		} else {
62	1	return false;
63		}
64		}
65
66	23	if (null === $this->end \|\| $this->index < $this->end) {
67	20	return parent::valid();
68		}
69
70	13	return false;
71		}
72
73		/**
74		* @{inheritDoc}
75		*/
76	19	public function next()
77		{
78	19	$this->index += 1;
79	19	parent::next();
80	19	}
81
82		/**
83		* @{inheritDoc}
84		*/
85	24	public function rewind()
86		{
87	24	$this->index = 0;
88	24	parent::rewind();
89	24	}
90		}
91

zicht / itertools

Pull Request — master (#29)

SliceIterator::valid() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like