ReversedIterator - Code Metrics - Inspection of "[Feature] add interfaces" - zicht/itertools - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#29)

unknown

created 2017-05-05 10:38 UTC

ReversedIterator A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
dl	0
loc	36
ccs	12
cts	12
cp	1
rs	10
c	0
b	0
f	0
wmc	4
lcom	0
cbo	1

3 Methods

Rating	Name	Size	Complexity
A	__construct()	8	2
A	key()	5	1
A	current()	5	1

<?php
/**
 * @author Boudewijn Schoon <[email protected]>
 * @copyright Zicht Online <http://zicht.nl>
 */

namespace Zicht\Itertools\lib;

use Zicht\Itertools\lib\Interfaces\FiniteIterableInterface;
use Zicht\Itertools\lib\Traits\FiniteIterableTrait;

/**
 * Class ReversedIterator
 *
 * @package Zicht\Itertools\lib
 */
class ReversedIterator extends \IteratorIterator implements FiniteIterableInterface
{
    use FiniteIterableTrait;

    /**
     * ReversedIterator constructor.
     *
     * @param \Iterator $iterable
     */
    public function __construct(\Iterator $iterable)
    {
        $data = [];
        foreach ($iterable as $key => $value) {
            $data [] = [$key, $value];
        }
        parent::__construct(new \ArrayIterator(array_reverse($data)));
    }

    /**
     * @{inheritDoc}
     */
    public function key()
    {
        list($key, $value) = parent::current();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        return $key;
    }

    /**
     * @{inheritDoc}
     */
    public function current()
    {
        list($key, $value) = parent::current();
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;
        return $value;
    }
}


1		<?php
2		/**
3		* @author Boudewijn Schoon <[email protected]>
4		* @copyright Zicht Online <http://zicht.nl>
5		*/
6
7		namespace Zicht\Itertools\lib;
8
9		use Zicht\Itertools\lib\Interfaces\FiniteIterableInterface;
10		use Zicht\Itertools\lib\Traits\FiniteIterableTrait;
11
12		/**
13		* Class ReversedIterator
14		*
15		* @package Zicht\Itertools\lib
16		*/
17		class ReversedIterator extends \IteratorIterator implements FiniteIterableInterface
18		{
19		use FiniteIterableTrait;
20
21		/**
22		* ReversedIterator constructor.
23		*
24		* @param \Iterator $iterable
25		*/
26	4	public function __construct(\Iterator $iterable)
27		{
28	4	$data = [];
29	4	foreach ($iterable as $key => $value) {
30	3	$data [] = [$key, $value];
31		}
32	4	parent::__construct(new \ArrayIterator(array_reverse($data)));
33	4	}
34
35		/**
36		* @{inheritDoc}
37		*/
38	2	public function key()
39		{
40	2	list($key, $value) = parent::current();
		0 ignored issues – show Comprehensibility Bug introduced 2017-01-12 12:49 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`current()` instead of `key()`). Are you sure this is correct? If so, you might want to change this to `$this->current()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history... Unused Code introduced 2017-01-12 12:49 UTC by Report Bug Copy Issue Report The assignment to `$value` is unused. Consider omitting it like so `list($first,,$third)`. This checks looks for assignemnts to variables using the `list(...)` function, where not all assigned variables are subsequently used. Consider the following code example. <?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c; Only the variables `$a` and `$c` are used. There was no need to assign `$b`. Instead, the list call could have been. list($a,, $c) = returnThreeValues(); Loading history...
41	2	return $key;
42		}
43
44		/**
45		* @{inheritDoc}
46		*/
47	2	public function current()
48		{
49	2	list($key, $value) = parent::current();
		0 ignored issues – show Unused Code introduced 2017-01-12 12:49 UTC by Report Bug Copy Issue Report The assignment to `$key` is unused. Consider omitting it like so `list($first,,$third)`. This checks looks for assignemnts to variables using the `list(...)` function, where not all assigned variables are subsequently used. Consider the following code example. <?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c; Only the variables `$a` and `$c` are used. There was no need to assign `$b`. Instead, the list call could have been. list($a,, $c) = returnThreeValues(); Loading history...
50	2	return $value;
51		}
52		}
53

zicht / itertools

Pull Request — master (#29)

ReversedIterator A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

Duplication Side-by-Side

Filter issues like