Zicht\Itertools\lib\ChainIterator

Complexity

Total Complexity

4

Size/Duplication

Total Lines	28
Duplicated Lines	21.43 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	6	10	3
A	extend()	0	4	1

<?php
/**
 * @author Boudewijn Schoon <boudewijn@zicht.nl>
 * @copyright Zicht Online <http://zicht.nl>
 */

namespace Zicht\Itertools\lib;

use Zicht\Itertools\conversions;
use Zicht\Itertools\lib\Interfaces\FiniteIterableInterface;
use Zicht\Itertools\lib\Traits\FiniteIterableTrait;

/**
 * Class ChainIterator
 *
 * @package Zicht\Itertools\lib
 */
class ChainIterator extends \AppendIterator implements FiniteIterableInterface
{
    use FiniteIterableTrait;

    /**
     * ChainIterator constructor.
     */
    public function __construct()
    {
        parent::__construct();
        foreach (func_get_args() as $iterable) {

This code seems to be duplicated across your project.

            if (!$iterable instanceof \Iterator) {
                throw new \InvalidArgumentException(sprintf('Not all arguments are iterators'));
            }
            $this->append($iterable);
        }
    }

    /**
     * Extend this iterator with the contents of $iterable
     *
     * @param array|string|\Iterator $iterable
     */
    public function extend($iterable)
    {
        parent::append(conversions\mixed_to_iterator($iterable));

It seems like you call parent on a different method (append() instead of extend()). Are you sure this is correct? If so, you might want to change this to $this->append().

    }
}