SliceIterator::valid() - Code Metrics - zicht/itertools - Measure and Improve Code Quality continuously with Scrutinizer

SliceIterator::valid() A
last analyzed 2021-03-29 13:12 UTC

↳ Parent: SliceIterator

Complexity

Conditions	5
Paths	5

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	5

Importance

Changes

Metric	Value
cc	5
nc	5
nop	0
dl	0
loc	17
ccs	9
cts	9
cp	1
crap	5
rs	9.3888
c	0
b	0
f	0

<?php
/**
 * @copyright Zicht Online <http://zicht.nl>
 */

namespace Zicht\Itertools\lib;

use Zicht\Itertools\lib\Interfaces\FiniteIterableInterface;
use Zicht\Itertools\lib\Traits\FiniteIterableTrait;

class SliceIterator extends \IteratorIterator implements FiniteIterableInterface
{
    use FiniteIterableTrait;

    /** @var int */
    private $index;

    /** @var int */
    private $start;

    /** @var null|int */
    private $end;

    /**
     * @param \Iterator $iterable
     * @param int $start
     * @param null|int $end
     */
    public function __construct(\Iterator $iterable, $start, $end = null)
    {
        if ($start < 0 || $end < 0) {
            $length = iterator_count($iterable);
        } else {
            // length is not needed.  still, we will define it for code cleanliness
            $length = 0;
        }

        $this->index = 0;
        $this->start = $start < 0 ? $length + $start : $start;
        $this->end = $end === null ? null : ($end < 0 ? $length + $end : $end);
        parent::__construct($iterable);
    }

    /**
     * {@inheritDoc}
     */
    public function valid()
    {
        while ($this->index < $this->start) {
            if (parent::valid()) {
                $this->index += 1;
                parent::next();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
            } else {
                return false;
            }
        }

        if (null === $this->end || $this->index < $this->end) {
            return parent::valid();
        }

        return false;
    }

    /**
     * {@inheritDoc}
     */
    public function next()
    {
        $this->index += 1;
        parent::next();
    }

    /**
     * {@inheritDoc}
     */
    public function rewind()
    {
        $this->index = 0;
        parent::rewind();
    }
}


1		<?php
2		/**
3		* @copyright Zicht Online <http://zicht.nl>
4		*/
5
6		namespace Zicht\Itertools\lib;
7
8		use Zicht\Itertools\lib\Interfaces\FiniteIterableInterface;
9		use Zicht\Itertools\lib\Traits\FiniteIterableTrait;
10
11		class SliceIterator extends \IteratorIterator implements FiniteIterableInterface
12		{
13		use FiniteIterableTrait;
14
15		/** @var int */
16		private $index;
17
18		/** @var int */
19		private $start;
20
21		/** @var null\|int */
22		private $end;
23
24		/**
25		* @param \Iterator $iterable
26		* @param int $start
27		* @param null\|int $end
28		*/
29	25	public function __construct(\Iterator $iterable, $start, $end = null)
30		{
31	25	if ($start < 0 \|\| $end < 0) {
32	9	$length = iterator_count($iterable);
33		} else {
34		// length is not needed. still, we will define it for code cleanliness
35	16	$length = 0;
36		}
37
38	25	$this->index = 0;
39	25	$this->start = $start < 0 ? $length + $start : $start;
40	25	$this->end = $end === null ? null : ($end < 0 ? $length + $end : $end);
41	25	parent::__construct($iterable);
42	25	}
43
44		/**
45		* {@inheritDoc}
46		*/
47	24	public function valid()
48		{
49	24	while ($this->index < $this->start) {
50	9	if (parent::valid()) {
51	9	$this->index += 1;
52	9	parent::next();
		0 ignored issues – show Comprehensibility Bug introduced 2017-01-12 12:49 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`next()` instead of `valid()`). Are you sure this is correct? If so, you might want to change this to `$this->next()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
53		} else {
54	1	return false;
55		}
56		}
57
58	23	if (null === $this->end \|\| $this->index < $this->end) {
59	20	return parent::valid();
60		}
61
62	13	return false;
63		}
64
65		/**
66		* {@inheritDoc}
67		*/
68	19	public function next()
69		{
70	19	$this->index += 1;
71	19	parent::next();
72	19	}
73
74		/**
75		* {@inheritDoc}
76		*/
77	24	public function rewind()
78		{
79	24	$this->index = 0;
80	24	parent::rewind();
81	24	}
82		}
83

zicht / itertools

SliceIterator::valid() A last analyzed 2021-03-29 13:12 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

SliceIterator::valid() A
last analyzed 2021-03-29 13:12 UTC