ChainIterator - Code Metrics - zicht/itertools - Measure and Improve Code Quality continuously with Scrutinizer

ChainIterator A
last analyzed 2021-03-29 13:12 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	25
Duplicated Lines	24 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
dl	6
loc	25
ccs	10
cts	10
cp	1
rs	10
c	0
b	0
f	0
wmc	4
lcom	0
cbo	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	6	10	3
A	extend()	0	4	1

How to fix Duplicated Code

<?php
/**
 * @copyright Zicht Online <http://zicht.nl>
 */

namespace Zicht\Itertools\lib;

use Zicht\Itertools\conversions;
use Zicht\Itertools\lib\Interfaces\FiniteIterableInterface;
use Zicht\Itertools\lib\Traits\FiniteIterableTrait;

class ChainIterator extends \AppendIterator implements FiniteIterableInterface
{
    use FiniteIterableTrait;

    public function __construct()
    {
        parent::__construct();
        foreach (func_get_args() as $iterable) {

            if (!$iterable instanceof \Iterator) {
                throw new \InvalidArgumentException(sprintf('Not all arguments are iterators'));
            }
            $this->append($iterable);
        }
    }

    /**
     * Extend this iterator with the contents of $iterable
     *
     * @param array|string|\Iterator $iterable
     */
    public function extend($iterable)
    {
        parent::append(conversions\mixed_to_iterator($iterable));
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }
}


1			<?php
2			/**
3			* @copyright Zicht Online <http://zicht.nl>
4			*/
5
6			namespace Zicht\Itertools\lib;
7
8			use Zicht\Itertools\conversions;
9			use Zicht\Itertools\lib\Interfaces\FiniteIterableInterface;
10			use Zicht\Itertools\lib\Traits\FiniteIterableTrait;
11
12			class ChainIterator extends \AppendIterator implements FiniteIterableInterface
13			{
14			use FiniteIterableTrait;
15
16	18		public function __construct()
17			{
18	18		parent::__construct();
19	18	View Code Duplication	foreach (func_get_args() as $iterable) {
			0 ignored issues – show Duplication introduced 2017-01-12 12:49 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
20	14		if (!$iterable instanceof \Iterator) {
21	3		throw new \InvalidArgumentException(sprintf('Not all arguments are iterators'));
22			}
23	11		$this->append($iterable);
24			}
25	15		}
26
27			/**
28			* Extend this iterator with the contents of $iterable
29			*
30			* @param array\|string\|\Iterator $iterable
31			*/
32	3		public function extend($iterable)
33			{
34	3		parent::append(conversions\mixed_to_iterator($iterable));
			0 ignored issues – show Comprehensibility Bug introduced 2017-01-12 12:49 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`append()` instead of `extend()`). Are you sure this is correct? If so, you might want to change this to `$this->append()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history... Deprecated Code introduced 2021-03-25 08:37 UTC by Report Bug Copy Issue Report The function `Zicht\Itertools\conversions\mixed_to_iterator()` has been deprecated with message: Use \Zicht\Itertools\util\Conversions::mixedToIterator, will be removed in version 3.0 This function has been deprecated. The supplier of the file has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the function will be removed from the class and what other function to use instead. Loading history...
35	3		}
36			}
37

zicht / itertools

ChainIterator A last analyzed 2021-03-29 13:12 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

ChainIterator A
last analyzed 2021-03-29 13:12 UTC