Zicht\Bundle\FrameworkExtraBundle\Twig\ControlStructures\SwitchTokenParser::parse()

Complexity

Conditions	8
Paths	15

Size

Total Lines	60
Code Lines	39

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

<?php
    public function parse(Twig_Token $token)
    {
        $lineno = $token->getLine();

        $switchExpr = $this->parser->getExpressionParser()->parseExpression();

        /** @var $stream Twig_TokenStream */
        $stream = $this->parser->getStream();
        $stream->expect(Twig_Token::BLOCK_END_TYPE);


        // skip whitespace between switch and first case
        while ($stream->test(Twig_Token::TEXT_TYPE)) {
            if (trim($stream->getCurrent()->getValue()) != '') {
                $content = $stream->getCurrent()->getValue();
                throw new Twig_Error_Syntax("Can not render content '$content' directly after switch", $stream->getCurrent()->getLine());
            }
            $stream->next();
        }
        $stream->expect(Twig_Token::BLOCK_START_TYPE);

        $tests = array();

        while (!$stream->test('endswitch')) {
            $token = $stream->expect(Twig_Token::NAME_TYPE, array('case', 'default'));
            switch ($token->getValue()) {
                case 'case':
                    $caseExpr   = array();
                    $caseExpr[] = $this->parser->getExpressionParser()->parseExpression();
                    while ($stream->test(Twig_Token::OPERATOR_TYPE, ',')) {
                        $stream->next();
                        $caseExpr[] = $this->parser->getExpressionParser()->parseExpression();
                    }
                    break;
                case 'default':
                    $caseExpr = null;
                    break;
            }

            $fallthrough = false;
            if ($stream->test('fallthrough')) {
                $stream->next();
                $fallthrough = true;
            }
            $stream->expect(Twig_Token::BLOCK_END_TYPE);
            $body = $this->parser->subparse(array($this, 'decideSwitchFork'));

            $tests[] = new SwitchCaseNode(
                $body,

It seems like $body can also be of type Twig\Node\Node; however, parameter $body of Zicht\Bundle\FrameworkExtraBundle\Twig\ControlStructures\SwitchCaseNode::__construct() does only seem to accept array, maybe add an additional type check?

                $caseExpr,

The variable $caseExpr does not seem to be defined for all execution paths leading up to this point.

                $fallthrough,

$fallthrough of type true is incompatible with the type integer expected by parameter $fallthrough of Zicht\Bundle\FrameworkExtraBundle\Twig\ControlStructures\SwitchCaseNode::__construct().

                $token->getLine(),
                $token->getValue()
            );
        }

        $stream->expect('endswitch');
        $stream->expect(Twig_Token::BLOCK_END_TYPE);

        return new SwitchNode(new Twig_Node($tests), $switchExpr, $lineno);
    }