Complex classes like AbstractApi often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use AbstractApi, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 46 | abstract class AbstractApi implements ApiInterface |
||
| 47 | { |
||
| 48 | public const BASE_URI = 'https://www.wrike.com/api/v4/'; |
||
| 49 | |||
| 50 | /** |
||
| 51 | * @var ClientInterface |
||
| 52 | */ |
||
| 53 | protected $client; |
||
| 54 | |||
| 55 | /** |
||
| 56 | * @var string |
||
| 57 | */ |
||
| 58 | protected $accessToken = ''; |
||
| 59 | |||
| 60 | /** |
||
| 61 | * @var ResponseTransformerInterface |
||
| 62 | */ |
||
| 63 | protected $responseTransformer; |
||
| 64 | |||
| 65 | /** |
||
| 66 | * @var ApiExceptionTransformerInterface |
||
| 67 | */ |
||
| 68 | protected $apiExceptionTransformer; |
||
| 69 | |||
| 70 | /** |
||
| 71 | * Api constructor. |
||
| 72 | * |
||
| 73 | * @param ClientInterface $client |
||
| 74 | * @param ResponseTransformerInterface $responseTransformer |
||
| 75 | * @param ApiExceptionTransformerInterface $apiExceptionTransformer |
||
| 76 | * @param string $accessToken |
||
| 77 | * |
||
| 78 | * @throws \InvalidArgumentException |
||
| 79 | */ |
||
| 80 | 46 | public function __construct( |
|
| 93 | |||
| 94 | 2 | public function contacts(): ContactResource |
|
| 101 | |||
| 102 | /** |
||
| 103 | * @deprecated getContactResource is deprecated and will be removed in 3.0.0. Use contacts(). |
||
| 104 | */ |
||
| 105 | 1 | public function getContactResource(): ContactResource |
|
| 109 | |||
| 110 | /** |
||
| 111 | * @return UserResource |
||
| 112 | */ |
||
| 113 | 2 | public function users(): UserResource |
|
| 120 | |||
| 121 | /** |
||
| 122 | * @return UserResource |
||
| 123 | */ |
||
| 124 | 1 | public function getUserResource(): UserResource |
|
| 128 | |||
| 129 | /** |
||
| 130 | * @return GroupResource |
||
| 131 | */ |
||
| 132 | 2 | public function groups(): GroupResource |
|
| 139 | |||
| 140 | /** |
||
| 141 | * @return GroupResource |
||
| 142 | */ |
||
| 143 | 1 | public function getGroupResource(): GroupResource |
|
| 147 | |||
| 148 | /** |
||
| 149 | * @return InvitationResource |
||
| 150 | */ |
||
| 151 | 2 | public function invitations(): InvitationResource |
|
| 158 | |||
| 159 | /** |
||
| 160 | * @return InvitationResource |
||
| 161 | */ |
||
| 162 | 1 | public function getInvitationResource(): InvitationResource |
|
| 166 | |||
| 167 | /** |
||
| 168 | * @return AccountResource |
||
| 169 | */ |
||
| 170 | 2 | public function account(): AccountResource |
|
| 177 | |||
| 178 | /** |
||
| 179 | * @return AccountResource |
||
| 180 | */ |
||
| 181 | 1 | public function getAccountResource(): AccountResource |
|
| 185 | |||
| 186 | /** |
||
| 187 | * @return WorkflowResource |
||
| 188 | */ |
||
| 189 | 2 | public function workflows(): WorkflowResource |
|
| 196 | |||
| 197 | /** |
||
| 198 | * @return WorkflowResource |
||
| 199 | */ |
||
| 200 | 1 | public function getWorkflowResource(): WorkflowResource |
|
| 204 | |||
| 205 | /** |
||
| 206 | * @return CustomFieldResource |
||
| 207 | */ |
||
| 208 | 2 | public function customFields(): CustomFieldResource |
|
| 215 | |||
| 216 | /** |
||
| 217 | * @return CustomFieldResource |
||
| 218 | */ |
||
| 219 | 1 | public function getCustomFieldResource(): CustomFieldResource |
|
| 223 | |||
| 224 | /** |
||
| 225 | * @return FolderResource |
||
| 226 | */ |
||
| 227 | 2 | public function folders(): FolderResource |
|
| 234 | |||
| 235 | /** |
||
| 236 | * @return FolderResource |
||
| 237 | */ |
||
| 238 | 1 | public function getFolderResource(): FolderResource |
|
| 242 | |||
| 243 | /** |
||
| 244 | * @return TaskResource |
||
| 245 | */ |
||
| 246 | 2 | public function tasks(): TaskResource |
|
| 253 | |||
| 254 | /** |
||
| 255 | * @return TaskResource |
||
| 256 | */ |
||
| 257 | 1 | public function getTaskResource(): TaskResource |
|
| 261 | |||
| 262 | /** |
||
| 263 | * @return CommentResource |
||
| 264 | */ |
||
| 265 | 2 | public function comments(): CommentResource |
|
| 272 | |||
| 273 | /** |
||
| 274 | * @return CommentResource |
||
| 275 | */ |
||
| 276 | 1 | public function getCommentResource(): CommentResource |
|
| 280 | |||
| 281 | /** |
||
| 282 | * @return DependencyResource |
||
| 283 | */ |
||
| 284 | 2 | public function dependencies(): DependencyResource |
|
| 291 | |||
| 292 | /** |
||
| 293 | * @return DependencyResource |
||
| 294 | */ |
||
| 295 | 1 | public function getDependencyResource(): DependencyResource |
|
| 299 | |||
| 300 | /** |
||
| 301 | * @return TimelogResource |
||
| 302 | */ |
||
| 303 | 2 | public function timelogs(): TimelogResource |
|
| 310 | |||
| 311 | /** |
||
| 312 | * @return TimelogResource |
||
| 313 | */ |
||
| 314 | 1 | public function getTimelogResource(): TimelogResource |
|
| 318 | |||
| 319 | /** |
||
| 320 | * @return TimelogCategoryResource |
||
| 321 | */ |
||
| 322 | 2 | public function timelogCategories(): TimelogCategoryResource |
|
| 329 | |||
| 330 | /** |
||
| 331 | * @return TimelogCategoryResource |
||
| 332 | */ |
||
| 333 | 1 | public function getTimelogCategoryResource(): TimelogCategoryResource |
|
| 337 | |||
| 338 | /** |
||
| 339 | * @return AttachmentResource |
||
| 340 | */ |
||
| 341 | 2 | public function attachments(): AttachmentResource |
|
| 348 | |||
| 349 | /** |
||
| 350 | * @return AttachmentResource |
||
| 351 | */ |
||
| 352 | 1 | public function getAttachmentResource(): AttachmentResource |
|
| 356 | |||
| 357 | /** |
||
| 358 | * @return VersionResource |
||
| 359 | */ |
||
| 360 | 2 | public function version(): VersionResource |
|
| 367 | |||
| 368 | /** |
||
| 369 | * @return VersionResource |
||
| 370 | */ |
||
| 371 | 1 | public function getVersionResource(): VersionResource |
|
| 375 | |||
| 376 | /** |
||
| 377 | * @return IdResource |
||
| 378 | */ |
||
| 379 | 2 | public function ids(): IdResource |
|
| 386 | |||
| 387 | /** |
||
| 388 | * @return IdResource |
||
| 389 | */ |
||
| 390 | 1 | public function getIdResource(): IdResource |
|
| 394 | |||
| 395 | /** |
||
| 396 | * @return ColorResource |
||
| 397 | */ |
||
| 398 | 2 | public function colors(): ColorResource |
|
| 405 | |||
| 406 | /** |
||
| 407 | * @return ColorResource |
||
| 408 | */ |
||
| 409 | 1 | public function getColorResource(): ColorResource |
|
| 413 | |||
| 414 | /** |
||
| 415 | * @param array $params |
||
| 416 | * |
||
| 417 | * @return array |
||
| 418 | */ |
||
| 419 | 1 | public function normalizeParams(array $params): array |
|
| 429 | |||
| 430 | /** |
||
| 431 | * @param string $resourceClass |
||
| 432 | * |
||
| 433 | * @return AbstractResource |
||
| 434 | */ |
||
| 435 | 34 | private function getResource(string $resourceClass): AbstractResource |
|
| 444 | } |
||
| 445 |