Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
21 | View Code Duplication | class CustomFieldModel extends AbstractModel implements ResourceModelInterface |
|
|
|||
22 | { |
||
23 | /** |
||
24 | * Custom Field ID. |
||
25 | * |
||
26 | * @SA\Type("string") |
||
27 | * @SA\SerializedName("id") |
||
28 | * |
||
29 | * @var string|null |
||
30 | */ |
||
31 | protected $id; |
||
32 | |||
33 | /** |
||
34 | * Custom field value. |
||
35 | * |
||
36 | * @SA\Type("string") |
||
37 | * @SA\SerializedName("value") |
||
38 | * |
||
39 | * @var string|null |
||
40 | */ |
||
41 | protected $value; |
||
42 | |||
43 | /** |
||
44 | * @return null|string |
||
45 | */ |
||
46 | 1 | public function getId() |
|
50 | |||
51 | /** |
||
52 | * @param null|string $id |
||
53 | * |
||
54 | * @return $this |
||
55 | */ |
||
56 | 1 | public function setId($id) |
|
62 | |||
63 | /** |
||
64 | * @return null|string |
||
65 | */ |
||
66 | 1 | public function getValue() |
|
70 | |||
71 | /** |
||
72 | * @param null|string $value |
||
73 | * |
||
74 | * @return $this |
||
75 | */ |
||
76 | 1 | public function setValue($value) |
|
82 | } |
||
83 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.