| Conditions | 1 |
| Paths | 1 |
| Total Lines | 84 |
| Code Lines | 34 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 25 | public function configurationProvider() |
||
| 26 | { |
||
| 27 | return [ |
||
| 28 | // [sourceConfig, expectedConfig, expectedExceptionClass] |
||
| 29 | // default |
||
| 30 | [ |
||
| 31 | [], |
||
| 32 | [], |
||
| 33 | false, |
||
| 34 | ], |
||
| 35 | // api_url |
||
| 36 | [ |
||
| 37 | ['api_url' => null], |
||
| 38 | [], |
||
| 39 | InvalidConfigurationException::class, |
||
| 40 | ], |
||
| 41 | [ |
||
| 42 | ['api_url' => ''], |
||
| 43 | [], |
||
| 44 | InvalidConfigurationException::class, |
||
| 45 | ], |
||
| 46 | [ |
||
| 47 | ['api_url' => []], |
||
| 48 | [], |
||
| 49 | InvalidConfigurationException::class, |
||
| 50 | ], |
||
| 51 | [ |
||
| 52 | ['api_url' => 'validToken'], |
||
| 53 | ['api_url' => 'validToken'], |
||
| 54 | false, |
||
| 55 | ], |
||
| 56 | // permanent_token -> tokens |
||
| 57 | [ |
||
| 58 | ['permanent_tokens' => ['tokens' => null]], |
||
| 59 | [], |
||
| 60 | InvalidConfigurationException::class, |
||
| 61 | ], |
||
| 62 | [ |
||
| 63 | ['permanent_tokens' => ['tokens' => '']], |
||
| 64 | [], |
||
| 65 | InvalidConfigurationException::class, |
||
| 66 | ], |
||
| 67 | [ |
||
| 68 | ['permanent_tokens' => ['tokens' => []]], |
||
| 69 | [], |
||
| 70 | InvalidConfigurationException::class, |
||
| 71 | ], |
||
| 72 | [ |
||
| 73 | ['permanent_tokens' => ['tokens' => ['test']]], |
||
| 74 | [], |
||
| 75 | InvalidConfigurationException::class, |
||
| 76 | ], |
||
| 77 | [ |
||
| 78 | ['permanent_tokens' => ['tokens' => ['test' => '']]], |
||
| 79 | [], |
||
| 80 | InvalidConfigurationException::class, |
||
| 81 | ], |
||
| 82 | [ |
||
| 83 | ['permanent_tokens' => ['tokens' => [null => 'validToken']]], |
||
| 84 | [], |
||
| 85 | InvalidConfigurationException::class, |
||
| 86 | ], |
||
| 87 | [ |
||
| 88 | ['permanent_tokens' => ['tokens' => ['' => 'validToken']]], |
||
| 89 | [], |
||
| 90 | InvalidConfigurationException::class, |
||
| 91 | ], |
||
| 92 | [ |
||
| 93 | ['permanent_tokens' => ['tokens' => ['validName' => 'validToken']]], |
||
| 94 | ['permanent_tokens' => ['tokens' => ['validName' => 'validToken']]], |
||
| 95 | false, |
||
| 96 | ], |
||
| 97 | [ |
||
| 98 | ['permanent_tokens' => ['default_token' => 'validName', 'tokens' => ['validName' => 'validToken']]], |
||
| 99 | ['permanent_tokens' => ['default_token' => 'validName', 'tokens' => ['validName' => 'validToken']]], |
||
| 100 | false, |
||
| 101 | ], |
||
| 102 | [ |
||
| 103 | ['permanent_tokens' => ['default_token' => 'default', 'tokens' => ['validName' => 'validToken']]], |
||
| 104 | [], |
||
| 105 | InvalidConfigurationException::class, |
||
| 106 | ], |
||
| 107 | ]; |
||
| 108 | } |
||
| 109 | } |
||
| 110 |