Customer::__construct() - Code Metrics - Inspection of "Customer verify request + other updates" - zhooravell/skrill-php-client - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#13)

unknown

created 2020-08-27 09:31 UTC

Customer::__construct() A

↳ Parent: Customer

Complexity

Conditions	3
Paths	4

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
eloc	6
c	1
b	0
f	1
dl	0
loc	11
rs	10
cc	3
nc	4
nop	2

<?php

declare(strict_types=1);

namespace Skrill\ValueObject;

/**
 * Class Customer
 *
 * Value object for Customer Verification Service.
 * The customer verification service is used to check if one of your customers, identified by an email
 * address or customer ID, is registered with Skrill (i.e. the customer already has an active Skrill Digital
 * Wallet account).You can also verify information that you hold about the customer against Skrill’s
 * registration records.
 *
 * https://www.skrill.com/fileadmin/content/pdf/Skrill_Customer_Verification_Service_Guide_v1.1__1_.pdf
 *
 */
final class Customer
{
    /** @var string */
    private $lastName  = '';

    /** @var string */
    private $firstName = '';

    /**
     * CustomerName constructor.
     * @param string $firstName
     * @param string $lastName
     */
    public function __construct(string $firstName = '', string $lastName = '')
    {
        $firstName = trim($firstName);
        $lastName  = trim($lastName);

        if ($this->validateAlpha($firstName)) {
            $this->firstName = $firstName;
        }

        if ($this->validateAlpha($lastName)) {
            $this->lastName  = $lastName;
        }
    }

    /**
     * Customer’s first name.
     * @return string
     */
    public function getFirstName(): string
    {
        return $this->firstName;
    }

    /**
     * Customer’s last name
     * @return string
     */
    public function getLastName(): string
    {
        return $this->lastName;
    }

    /**
     * Validate that a field contains only alphabetic characters
     * @param  string $value
     * @return bool
     */
    private function validateAlpha($value): bool
    {
        return (bool)preg_match('/^([a-z])+$/i', $value);
    }
}

1			<?php
2
3			declare(strict_types=1);
4
5			namespace Skrill\ValueObject;
6
7			/**
8			* Class Customer
9			*
10			* Value object for Customer Verification Service.
11			* The customer verification service is used to check if one of your customers, identified by an email
12			* address or customer ID, is registered with Skrill (i.e. the customer already has an active Skrill Digital
13			* Wallet account).You can also verify information that you hold about the customer against Skrill’s
14			* registration records.
15			*
16			* https://www.skrill.com/fileadmin/content/pdf/Skrill_Customer_Verification_Service_Guide_v1.1__1_.pdf
17			*
18			*/
19			final class Customer
20			{
21			/** @var string */
22			private $lastName = '';
23
24			/** @var string */
25			private $firstName = '';
26
27			/**
28			* CustomerName constructor.
29			* @param string $firstName
30			* @param string $lastName
31			*/
32			public function __construct(string $firstName = '', string $lastName = '')
33			{
34			$firstName = trim($firstName);
35			$lastName = trim($lastName);
36
37			if ($this->validateAlpha($firstName)) {
38			$this->firstName = $firstName;
39			}
40
41			if ($this->validateAlpha($lastName)) {
42			$this->lastName = $lastName;
43			}
44			}
45
46			/**
47			* Customer’s first name.
48			* @return string
49			*/
50			public function getFirstName(): string
51			{
52			return $this->firstName;
53			}
54
55			/**
56			* Customer’s last name
57			* @return string
58			*/
59			public function getLastName(): string
60			{
61			return $this->lastName;
62			}
63
64			/**
65			* Validate that a field contains only alphabetic characters
66			* @param string $value
67			* @return bool
68			*/
69			private function validateAlpha($value): bool
70			{
71			return (bool)preg_match('/^([a-z])+$/i', $value);
72			}
73			}

zhooravell / skrill-php-client

Pull Request — master (#13)

Customer::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like