zhangv / wechat-pay

src/util/HttpClient.php

<?php
/**
 * HttpClient
 *
 * @license MIT
 * @author zhangv
 */
namespace zhangv\wechat\pay\util;

class HttpClient{

	const GET = 'get',POST = 'post', DELETE = 'delete',PUT = 'put';
	private $instance = null;
	private $errNo = null;
	private $info = null;
	private $timeout = 1;
	private $retry = 1;
	private $tried = 0;

	public function __construct($timeout = 1,$retry = 1) {
		$this->timeout = $timeout;
		$this->retry = $retry;
		$this->initInstance();
	}

	public function initInstance(){
		if(!$this->instance) {
			$this->instance = curl_init();
			if($this->timeout < 1) {
				curl_setopt($this->instance, CURLOPT_NOSIGNAL,1);

It seems like $this->instance can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

				curl_setopt($this->instance, CURLOPT_TIMEOUT_MS, $this->timeout * 1000);
			}else
				curl_setopt($this->instance, CURLOPT_TIMEOUT, intval($this->timeout));
			curl_setopt($this->instance, CURLOPT_RETURNTRANSFER, true);
			curl_setopt($this->instance, CURLOPT_FOLLOWLOCATION, true);
			curl_setopt($this->instance, CURLOPT_SSL_VERIFYPEER, false);
		}
	}

	public function get($url,$params = array(),$headers = array(),$opts = array()) {
		if (!$this->instance)	$this->initInstance($this->timeout);

The call to zhangv\wechat\pay\util\HttpClient::initInstance() has too many arguments starting with $this->timeout.

		if($params && count($params) > 0) $url .= '?' . http_build_query($params);
		curl_setopt($this->instance, CURLOPT_URL, $url);
		curl_setopt($this->instance, CURLOPT_HTTPGET, true);
		curl_setopt($this->instance, CURLOPT_HTTPHEADER, $headers);
		curl_setopt_array($this->instance,$opts);
		$result = $this->execute();
		curl_close($this->instance);
		$this->instance = null;
		return $result;
	}

	public function post($url, $params = array(),$headers = array(),$opts = array()) {
		if (!$this->instance)	$this->initInstance($this->timeout);

The call to zhangv\wechat\pay\util\HttpClient::initInstance() has too many arguments starting with $this->timeout.

		curl_setopt($this->instance, CURLOPT_URL, $url);
		curl_setopt($this->instance, CURLOPT_POST, true);
		curl_setopt($this->instance, CURLOPT_POSTFIELDS, $params);
		curl_setopt($this->instance, CURLOPT_HTTPHEADER, $headers);
		curl_setopt_array($this->instance,$opts);
		$result = $this->execute();
		curl_close($this->instance);
		$this->instance = null;
		return $result;
	}

	private function execute() {
		$this->tried = 0;
		do{
			$result = curl_exec($this->instance);
			$this->errNo = curl_errno($this->instance);
		}while(!$result && $this->errNo === CURLE_OPERATION_TIMEDOUT && $this->tried++ < $this->retry);
		$this->info = curl_getinfo($this->instance);
		return $result;
	}

	public function getInfo(){
		return $this->info;
	}

	public function getErrorNo(){
		return $this->errNo;
	}

	public function getTried(){
		return $this->tried;
	}
}