zhangv\wechat\cache\JsonFileCacheProvider

Complexity

Total Complexity

8

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	set()	0	7	2
A	clear()	0	4	2
A	get()	0	7	2
A	__construct()	0	3	2

<?php
/**
 * User: derekzhangv
 * Time: 2018/5/29 16:41
 */
namespace zhangv\wechat\cache;
class JsonFileCacheProvider implements CacheProvider{
	private $cacheDir = null;

	public function __construct($cacheDir = null){
		if(!$cacheDir) $this->cacheDir = __DIR__;
		else $this->cacheDir = $cacheDir;
	}

	public function set($key,$jsonobj,$expireAt){
		$data = $jsonobj;
		$data->expires_at = $expireAt;
		$file = "{$this->cacheDir}/{$key}.json";
		$fp = fopen($file, "w");
		fwrite($fp, json_encode($data));

It seems like $fp can also be of type false; however, parameter $handle of fwrite() does only seem to accept resource, maybe add an additional type check?

		if ($fp) fclose($fp);

$fp is of type resource|false, thus it always evaluated to false.

	}

	public function get($key){
		$file = "{$this->cacheDir}/{$key}.json";
		$cache = null;
		if(file_exists($file)){
			$cache = json_decode(file_get_contents($file));
		}
		return $cache;
	}

	public function clear($key){
		$file = "{$this->cacheDir}/{$key}.json";
		if (file_exists($file)) {
			unlink($file);
		}
	}
}