Issues in Collection.php (master) - Issues in master - zewadesign/framework - Measure and Improve Code Quality continuously with Scrutinizer

Issues (24)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Zewa/Collection.php (3 issues)

Labels

Duplication 3

Severity

Informational 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
declare(strict_types = 1);

namespace Zewa;

use Zewa\Interfaces\CollectionInterface;

/**
 * Class Collection
 * @package App\Models
 */
class Collection implements CollectionInterface
{
    /**
     * @var array
     */
    public $collection = [];

    /**
     * If $data is passed, populate collection
     *
     * @param $data array
     *
     * @access public
     */
    public function __construct(array $data = [])
    {
        $this->collection = $data;
    }

    public function count() : int
    {
        return count($this->collection);
    }

    public function isEmpty() : bool
    {
        if (! empty($this->collection)) {
            return false;
        }

        return true;
    }

    public function getArray() : array
    {
        return $this->collection;
    }

    public function jsonSerialize() : array //@TODO: this should return text i think (wrong)
    {
        return $this->collection;
    }

    public function getIterator() : \ArrayIterator
    {
        return new \ArrayIterator($this->collection);
    }

    public function offsetExists($offset)
    {
        return array_key_exists($offset, $this->collection);
    }

    public function offsetGet($offset)
    {
        return $this->collection[$offset] ?? null;
    }

    public function offsetSet($offset, $value)
    {
        $this->collection[$offset] = $value;
    }

    public function offsetUnset($offset)
    {
        if ($this->offsetExists($offset)) {
            unset($this->collection[$offset]);
        }
    }

    public function clear()
    {
        $this->collection = [];
    }

    public function map(callable $func)

    {
        $result = [];

        foreach ($this->collection as $key => $item) {
            $result[$key] = $func($item);
        }

        $this->clear();
        $this->collection = $result;
    }

    public function filter(callable $func)

    {
        $result = [];

        foreach ($this->collection as $key => $item) {
            if ($func($key, $item)) {
                $result[$key] = $item;
            }
        }

        $this->clear();
        $this->collection = $result;
    }

    public function each(callable $func)
    {
        $result = [];

        foreach ($this->collection as $key => $item) {
            $result[$key] = $func($key, $item);
        }
    }

    public function not(callable $func)

    {
        $result = [];

        foreach ($this->collection as $key => $item) {
            if (! $func($key, $item)) {
                $result[$key] = $item;
            }
        }

        $this->clear();
        $this->collection = $result;
    }

    public function reduce($initial, callable $func)
    {
        $accumulator = $initial;

        foreach ($this->collection as $item) {
            $accumulator = $func($accumulator, $item);
        }

        return $accumulator;
    }
}


1			<?php
2			declare(strict_types = 1);
3
4			namespace Zewa;
5
6			use Zewa\Interfaces\CollectionInterface;
7
8			/**
9			* Class Collection
10			* @package App\Models
11			*/
12			class Collection implements CollectionInterface
13			{
14			/**
15			* @var array
16			*/
17			public $collection = [];
18
19			/**
20			* If $data is passed, populate collection
21			*
22			* @param $data array
23			*
24			* @access public
25			*/
26	16		public function __construct(array $data = [])
27			{
28	16		$this->collection = $data;
29	16		}
30
31	1		public function count() : int
32			{
33	1		return count($this->collection);
34			}
35
36	3		public function isEmpty() : bool
37			{
38	3		if (! empty($this->collection)) {
39	1		return false;
40			}
41
42	2		return true;
43			}
44
45	4		public function getArray() : array
46			{
47	4		return $this->collection;
48			}
49
50	1		public function jsonSerialize() : array //@TODO: this should return text i think (wrong)
51			{
52	1		return $this->collection;
53			}
54
55	1		public function getIterator() : \ArrayIterator
56			{
57	1		return new \ArrayIterator($this->collection);
58			}
59
60	3		public function offsetExists($offset)
61			{
62	3		return array_key_exists($offset, $this->collection);
63			}
64
65	1		public function offsetGet($offset)
66			{
67	1		return $this->collection[$offset] ?? null;
68			}
69
70	1		public function offsetSet($offset, $value)
71			{
72	1		$this->collection[$offset] = $value;
73	1		}
74
75	1		public function offsetUnset($offset)
76			{
77	1		if ($this->offsetExists($offset)) {
78	1		unset($this->collection[$offset]);
79			}
80	1		}
81
82	4		public function clear()
83			{
84	4		$this->collection = [];
85	4		}
86
87	1	View Code Duplication	public function map(callable $func)
			0 ignored issues – show Duplication introduced 2016-11-09 11:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
88			{
89	1		$result = [];
90
91	1		foreach ($this->collection as $key => $item) {
92	1		$result[$key] = $func($item);
93			}
94
95	1		$this->clear();
96	1		$this->collection = $result;
97	1		}
98
99	1	View Code Duplication	public function filter(callable $func)
			0 ignored issues – show Duplication introduced 2016-11-09 11:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
100			{
101	1		$result = [];
102
103	1		foreach ($this->collection as $key => $item) {
104	1		if ($func($key, $item)) {
105	1		$result[$key] = $item;
106			}
107			}
108
109	1		$this->clear();
110	1		$this->collection = $result;
111	1		}
112
113	1		public function each(callable $func)
114			{
115	1		$result = [];
116
117	1		foreach ($this->collection as $key => $item) {
118	1		$result[$key] = $func($key, $item);
119			}
120	1		}
121
122	1	View Code Duplication	public function not(callable $func)
			0 ignored issues – show Duplication introduced 2016-11-09 11:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
123			{
124	1		$result = [];
125
126	1		foreach ($this->collection as $key => $item) {
127	1		if (! $func($key, $item)) {
128	1		$result[$key] = $item;
129			}
130			}
131
132	1		$this->clear();
133	1		$this->collection = $result;
134	1		}
135
136	2		public function reduce($initial, callable $func)
137			{
138	2		$accumulator = $initial;
139
140	2		foreach ($this->collection as $item) {
141	2		$accumulator = $func($accumulator, $item);
142			}
143
144	2		return $accumulator;
145			}
146			}
147

zewadesign / framework

Issues (24)

Security Analysis not enabled

Zewa/Collection.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like