Collection::mutate() - Code Metrics - Inspection of "removed the mutation method from collections" - zewadesign/framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#100)

unknown

created 2016-12-09 05:25 UTC

Collection::mutate() A

↳ Parent: Collection::map()

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	9
ccs	0
cts	7
cp	0
rs	9.6666
c	0
b	0
f	0
cc	2
eloc	6
nc	2
nop	1
crap	6

<?php
declare(strict_types = 1);

namespace Zewa;

use Zewa\Interfaces\CollectionInterface;

/**
 * Class Collection
 * @package App\Models
 */
class Collection implements CollectionInterface

{
    /**
     * @var array
     */
    public $collection = [];

    /**
     * If $data is passed, populate collection
     *
     * @param $data array
     *
     * @access public
     */
    public function __construct(array $data = [])
    {
        $this->collection = $data;
    }

    public function count() : int
    {
        return count($this->collection);
    }

    public function isEmpty() : bool
    {
        if (! empty($this->collection)) {
            return false;
        }

        return true;
    }

    public function getArray() : array
    {
        return $this->collection;
    }

    public function jsonSerialize() : array //@TODO: this should return text i think (wrong)
    {
        return $this->collection;
    }

    public function getIterator() : \ArrayIterator
    {
        return new \ArrayIterator($this->collection);
    }

    public function offsetExists($offset)
    {
        return array_key_exists($offset, $this->collection);
    }

    public function offsetGet($offset)
    {
        return $this->collection[$offset] ?? null;
    }

    public function offsetSet($offset, $value)
    {
        $this->collection[$offset] = $value;
    }

    public function offsetUnset($offset)
    {
        if ($this->offsetExists($offset)) {
            unset($this->collection[$offset]);
        }
    }

    public function clear()
    {
        $this->collection = [];
    }

    public function map(callable $func)

    {
        $result = [];

        foreach ($this->collection as $key => $item) {
            $result[$key] = $func($item);
        }

        $this->clear();
        $this->collection = $result;
    }

    public function filter(callable $func)

    {
        $result = [];

        foreach ($this->collection as $key => $item) {
            if ($func($key, $item)) {
                $result[$key] = $item;
            }
        }

        $this->clear();
        $this->collection = $result;
    }

    public function each(callable $func)
    {
        $result = [];

        foreach ($this->collection as $key => $item) {
            $result[$key] = $func($key, $item);
        }
    }

    public function not(callable $func)

    {
        $result = [];

        foreach ($this->collection as $key => $item) {
            if (! $func($key, $item)) {
                $result[$key] = $item;
            }
        }

        $this->clear();
        $this->collection = $result;
    }

    public function reduce($initial, callable $func)
    {
        $accumulator = $initial;

        foreach ($this->collection as $item) {
            $accumulator = $func($accumulator, $item);
        }

        return $accumulator;
    }
}


1			<?php
2			declare(strict_types = 1);
3
4			namespace Zewa;
5
6			use Zewa\Interfaces\CollectionInterface;
7
8			/**
9			* Class Collection
10			* @package App\Models
11			*/
12			class Collection implements CollectionInterface
			0 ignored issues – show Bug introduced 2016-12-09 05:28 UTC by Report Bug Copy Issue Report There is one abstract method `mutate` in this class; you could implement it, or declare this class as abstract. Loading history...
13			{
14			/**
15			* @var array
16			*/
17			public $collection = [];
18
19			/**
20			* If $data is passed, populate collection
21			*
22			* @param $data array
23			*
24			* @access public
25			*/
26	16		public function __construct(array $data = [])
27			{
28	16		$this->collection = $data;
29	16		}
30
31	1		public function count() : int
32			{
33	1		return count($this->collection);
34			}
35
36	3		public function isEmpty() : bool
37			{
38	3		if (! empty($this->collection)) {
39	1		return false;
40			}
41
42	2		return true;
43			}
44
45	4		public function getArray() : array
46			{
47	4		return $this->collection;
48			}
49
50	1		public function jsonSerialize() : array //@TODO: this should return text i think (wrong)
51			{
52	1		return $this->collection;
53			}
54
55	1		public function getIterator() : \ArrayIterator
56			{
57	1		return new \ArrayIterator($this->collection);
58			}
59
60	3		public function offsetExists($offset)
61			{
62	3		return array_key_exists($offset, $this->collection);
63			}
64
65	1		public function offsetGet($offset)
66			{
67	1		return $this->collection[$offset] ?? null;
68			}
69
70	1		public function offsetSet($offset, $value)
71			{
72	1		$this->collection[$offset] = $value;
73	1		}
74
75	1		public function offsetUnset($offset)
76			{
77	1		if ($this->offsetExists($offset)) {
78	1		unset($this->collection[$offset]);
79			}
80	1		}
81
82	4		public function clear()
83			{
84	4		$this->collection = [];
85	4		}
86
87		View Code Duplication	public function map(callable $func)
			0 ignored issues – show Duplication introduced 2016-11-09 11:17 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
88			{
89			$result = [];
90
91			foreach ($this->collection as $key => $item) {
92			$result[$key] = $func($item);
93			}
94
95			$this->clear();
96			$this->collection = $result;
97	1		}
98
99	1	View Code Duplication	public function filter(callable $func)
			0 ignored issues – show Duplication introduced 2016-11-09 11:17 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
100			{
101	1		$result = [];
102	1
103			foreach ($this->collection as $key => $item) {
104			if ($func($key, $item)) {
105	1		$result[$key] = $item;
106	1		}
107	1		}
108
109	1		$this->clear();
110			$this->collection = $result;
111	1		}
112
113	1		public function each(callable $func)
114	1		{
115	1		$result = [];
116
117			foreach ($this->collection as $key => $item) {
118			$result[$key] = $func($key, $item);
119	1		}
120	1		}
121	1
122		View Code Duplication	public function not(callable $func)
			0 ignored issues – show Duplication introduced 2016-11-09 11:17 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
123	1		{
124			$result = [];
125	1
126			foreach ($this->collection as $key => $item) {
127	1		if (! $func($key, $item)) {
128	1		$result[$key] = $item;
129			}
130	1		}
131
132	1		$this->clear();
133			$this->collection = $result;
134	1		}
135
136	1		public function reduce($initial, callable $func)
137	1		{
138	1		$accumulator = $initial;
139
140			foreach ($this->collection as $item) {
141			$accumulator = $func($accumulator, $item);
142	1		}
143	1
144	1		return $accumulator;
145			}
146			}
147

zewadesign / framework

Pull Request — master (#100)

Collection::mutate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like