Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 11 | class View |
||
| 12 | { |
||
| 13 | /** |
||
| 14 | * Active layout for view |
||
| 15 | * |
||
| 16 | * @var string|bool |
||
| 17 | */ |
||
| 18 | protected $layout; |
||
| 19 | |||
| 20 | /** |
||
| 21 | * Active module for view |
||
| 22 | * |
||
| 23 | * @var string|bool |
||
| 24 | */ |
||
| 25 | protected $module = false; |
||
| 26 | |||
| 27 | /** |
||
| 28 | * Rendered view content |
||
| 29 | * |
||
| 30 | * @var string |
||
| 31 | */ |
||
| 32 | protected $view = false; |
||
| 33 | |||
| 34 | /** |
||
| 35 | * Data object for view |
||
| 36 | * |
||
| 37 | * @var object |
||
| 38 | */ |
||
| 39 | protected $properties; |
||
| 40 | |||
| 41 | /** |
||
| 42 | * \Zewa\Config reference |
||
| 43 | * |
||
| 44 | * @var Config |
||
| 45 | */ |
||
| 46 | protected $configuration; |
||
| 47 | |||
| 48 | /** |
||
| 49 | * \Zewa\Router reference |
||
| 50 | * |
||
| 51 | * @var Router |
||
| 52 | */ |
||
| 53 | protected $router; |
||
| 54 | |||
| 55 | /** |
||
| 56 | * \Zewa\Router reference |
||
| 57 | * |
||
| 58 | * @var Router |
||
| 59 | */ |
||
| 60 | protected $request; |
||
| 61 | |||
| 62 | /** |
||
| 63 | * @var array |
||
| 64 | */ |
||
| 65 | private $queuedJS = []; |
||
| 66 | |||
| 67 | /** |
||
| 68 | * @var array |
||
| 69 | */ |
||
| 70 | private $queuedCSS = []; |
||
| 71 | |||
| 72 | /** |
||
| 73 | * Load up some basic configuration settings. |
||
| 74 | */ |
||
| 75 | public function __construct(Config $config, Router $router, Request $request) |
||
| 76 | { |
||
| 77 | $this->configuration = $config; |
||
| 78 | $this->router = $router; |
||
| 79 | $this->request = $request; |
||
|
|
|||
| 80 | } |
||
| 81 | |||
| 82 | /** |
||
| 83 | * Returns base URL for app |
||
| 84 | * @return string |
||
| 85 | */ |
||
| 86 | private function baseURL($path = '') |
||
| 87 | { |
||
| 88 | return $this->router->baseURL($path); |
||
| 89 | } |
||
| 90 | |||
| 91 | /** |
||
| 92 | * Returns the current request URL |
||
| 93 | * @return string |
||
| 94 | */ |
||
| 95 | private function currentURL($params = false) |
||
| 96 | { |
||
| 97 | return $this->router->currentURL($params); |
||
| 98 | } |
||
| 99 | |||
| 100 | /** |
||
| 101 | * Returns uri string |
||
| 102 | * @return string |
||
| 103 | */ |
||
| 104 | private function currentURI() |
||
| 105 | { |
||
| 106 | return $this->router->uri; |
||
| 107 | } |
||
| 108 | |||
| 109 | /* |
||
| 110 | * @todo create method for returning |
||
| 111 | * a valid json string with header.. |
||
| 112 | * view shouldn't set header logic, |
||
| 113 | * and the framework doesn't care what returns the string |
||
| 114 | * ..but view should handle the json_encode... |
||
| 115 | * seems overkill to call header() with returning a $view->json; |
||
| 116 | * thoughts?*/ |
||
| 117 | |||
| 118 | /** |
||
| 119 | * Loads a view |
||
| 120 | * |
||
| 121 | * @access public |
||
| 122 | * @param string|bool $view view to load |
||
| 123 | * @param string|bool $layout |
||
| 124 | * @return string |
||
| 125 | */ |
||
| 126 | public function render($view = false, $layout = false) |
||
| 127 | { |
||
| 128 | if ($layout !== false) { |
||
| 129 | $this->setLayout($layout); |
||
| 130 | } |
||
| 131 | |||
| 132 | if ($view !== false) { |
||
| 133 | $view = $this->prepareView($view); |
||
| 134 | |||
| 135 | $this->view = $return = $this->process($view); |
||
| 136 | |||
| 137 | if (! is_null($this->layout)) { |
||
| 138 | $return = $this->process($this->layout); |
||
| 139 | } |
||
| 140 | |||
| 141 | return $return; |
||
| 142 | } else { |
||
| 143 | if ($this->view !== false) { |
||
| 144 | $this->view = $this->process($this->view); |
||
| 145 | } |
||
| 146 | |||
| 147 | if (! is_null($this->layout)) { |
||
| 148 | return $this->process($this->layout); |
||
| 149 | } else { |
||
| 150 | return $this->view; |
||
| 151 | } |
||
| 152 | } |
||
| 153 | } |
||
| 154 | |||
| 155 | /** |
||
| 156 | * formats and prepares view for inclusion |
||
| 157 | * @param $viewName |
||
| 158 | * @return string |
||
| 159 | * @throws Exception\LookupException |
||
| 160 | */ |
||
| 161 | private function prepareView($viewName) |
||
| 184 | |||
| 185 | public function setView($viewName, $layout = false) |
||
| 186 | { |
||
| 187 | if ($layout !== false) { |
||
| 188 | $this->setLayout($layout); |
||
| 189 | } |
||
| 190 | $this->view = $this->prepareView($viewName); |
||
| 191 | } |
||
| 192 | |||
| 193 | public function setProperty($property, $value = false) |
||
| 202 | |||
| 203 | public function setLayout($layout) |
||
| 219 | |||
| 220 | /** |
||
| 221 | * Set the module for view look |
||
| 222 | * |
||
| 223 | * @access public |
||
| 224 | * @param string|bool $module module to override |
||
| 225 | */ |
||
| 226 | public function setModule($module = false) |
||
| 227 | { |
||
| 228 | if ($module === false) { |
||
| 229 | $routerConfig = $this->router->getConfig()->get('Routing'); |
||
| 230 | $this->module = $routerConfig->module; |
||
| 231 | } else { |
||
| 232 | $this->module = ucfirst($module); |
||
| 233 | } |
||
| 234 | } |
||
| 235 | |||
| 236 | /** |
||
| 237 | * Processes view/layouts and exposes variables to the view/layout |
||
| 238 | * |
||
| 239 | * @access private |
||
| 240 | * @param string $file file being rendered |
||
| 241 | * @return string processed content |
||
| 242 | */ |
||
| 243 | //@TODO: come back and clean up this and the way the view receives stuff |
||
| 244 | private function process($file) |
||
| 261 | |||
| 262 | /** |
||
| 263 | * Helper method for grabbing aggregated css files |
||
| 264 | * |
||
| 265 | * @access protected |
||
| 266 | * @return string css includes |
||
| 267 | */ |
||
| 268 | protected function fetchCSS() |
||
| 282 | |||
| 283 | /** |
||
| 284 | * Helper method for grabbing aggregated JS files |
||
| 285 | * |
||
| 286 | * @access protected |
||
| 287 | * @return string JS includes |
||
| 288 | */ |
||
| 289 | protected function fetchJS() |
||
| 303 | |||
| 304 | /** |
||
| 305 | * Helper method for adding css files for aggregation/render |
||
| 306 | * |
||
| 307 | * @access public |
||
| 308 | * @param $files array |
||
| 309 | * @param $place string |
||
| 310 | * @return string css includes |
||
| 311 | * @throws Exception\LookupException |
||
| 312 | */ |
||
| 313 | View Code Duplication | public function addCSS($files = [], $place = 'append') |
|
| 314 | { |
||
| 315 | if ($place === 'append') { |
||
| 316 | $this->queuedCSS = array_merge($files, $this->queuedCSS); |
||
| 317 | } else { |
||
| 318 | $this->queuedCSS = array_merge($this->queuedCSS, $files); |
||
| 319 | } |
||
| 320 | } |
||
| 321 | |||
| 322 | View Code Duplication | public function addJS($files = [], $place = 'append') |
|
| 323 | { |
||
| 324 | if ($place === 'append') { |
||
| 325 | $this->queuedJS = array_merge($files, $this->queuedJS); |
||
| 326 | } else { |
||
| 327 | $this->queuedJS = array_merge($this->queuedJS, $files); |
||
| 328 | } |
||
| 329 | } |
||
| 330 | |||
| 331 | /** |
||
| 332 | * Set 404 header, and return 404 view contents |
||
| 333 | * |
||
| 334 | * @access public |
||
| 335 | * @param $data array |
||
| 336 | * @return string |
||
| 337 | */ |
||
| 338 | public function render404($data = []) |
||
| 345 | } |
||
| 346 |
Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property.
Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property..