Zewa\Dependency

Complexity

Total Complexity

16

Size/Duplication

Total Lines	114
Duplicated Lines	7.89 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

0%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	1
A	isDependencyLoaded()	0	10	2
A	getDependency()	0	5	1
A	load()	0	11	2
B	resolve()	0	28	5
A	constructConstructorParameters()	9	19	3
A	injectAppInstance()	0	11	2

<?php

namespace Zewa;

use Zewa\Exception\Exception;

class Dependency
{
    /**
     * @var Container
     */
    private $dependencies;

    public function __construct(Config $config, Container $container)
    {
        $local = [
            '\Zewa\Config' => $config,
            '\Zewa\Container' => $container,
            '\Zewa\Dependency' => $this
        ];

        $this->dependencies = $container;
        $this->dependencies->set('__dependencies', $local);
    }

    private function isDependencyLoaded(string $class) : bool
    {
        $dependencies = $this->dependencies->get('__dependencies');

        if (isset($dependencies[$class]) === false) {
            return false;
        }

        return true;
    }

    private function getDependency(string $class)
    {
        $dependencies = $this->dependencies->get('__dependencies');
        return $dependencies[$class] ?? null;
    }

    private function load(string $class, $dependency, bool $persist)
    {
        if ($persist === true) {
            $dependencies = $this->dependencies->get('__dependencies');
            $dependencies[$class] = $dependency;
            $this->dependencies->set('__dependencies', $dependencies);
        }

//        $this->injectAppInstance($dependency);

75% of this comment could be valid code. Did you maybe forget this after debugging?

        return $dependency;
    }

    public function resolve($class, $persist = false)
    {
        if ($this->isDependencyLoaded($class)) {
            return $this->getDependency($class);
        }

        try {
            $reflectionClass = new \ReflectionClass($class);

            $constructor = $reflectionClass->getConstructor();

            if (!$constructor || $constructor->getParameters() === 0) {
                $dependency = new $class;
                return $this->load($class, $dependency, $persist);
            }

            $params = $this->constructConstructorParameters($reflectionClass);
            $dependency = $reflectionClass->newInstanceArgs($params);

            return $this->load($class, $dependency, $persist);
        } catch (\Exception $e) {
            echo "<PRE>";
            print_r($e->getMessage()); //->getMessage();
            var_dump($e->getTrace()[0]);

var_dump($e->getTrace()[0]); looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data.

            echo "</PRE>";
            return false;
        }
    }

    /**
     * @param \ReflectionClass $reflection
     * @return array
     */
    private function constructConstructorParameters(\ReflectionClass $reflection) : array
    {
        $constructor = $reflection->getConstructor();
        $params = $constructor->getParameters();

        $injection = [];

        foreach ($params as $param) {

This code seems to be duplicated across your project.

            // Here we should perform a bunch of checks, such as: isArray(), isCallable(), isDefaultValueAvailable()
            // isOptional() etc.
            if (is_null($param->getClass())) {
                $injection[] = null;
                continue;
            }
            $injection[] = $this->resolve("\\" . $param->getClass()->getName());
        }

        return $injection;
    }


    private function injectAppInstance($dependency)

This method is not used, and could be removed.

    {
        if ($dependency instanceof Controller) {
            $dependency->setEvent($this->resolve('\Sabre\Event\Emitter'));

The method setEvent() does not seem to exist on object<Zewa\Controller>.

            $dependency->setRequest($this->resolve('\Zewa\HTTP\Request'));

The method setRequest() does not seem to exist on object<Zewa\Controller>.

            $dependency->setRouter($this->resolve('\Zewa\Router'));

The method setRouter() does not seem to exist on object<Zewa\Controller>.

            $dependency->setConfig($this->resolve('\Zewa\Config'));

The method setConfig() does not seem to exist on object<Zewa\Controller>.

            $dependency->setDependency($this->resolve('\Zewa\Dependency'));

The method setDependency() does not seem to exist on object<Zewa\Controller>.

            $dependency->setView($this->resolve('\Zewa\View'));

The method setView() does not seem to exist on object<Zewa\Controller>.

        }
    }
}