Database::fetchConnection() - Code Metrics - Inspection of "changed protected to public for model methods (for..." - zewadesign/framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#72)

unknown

created 2016-08-17 07:46 UTC

Database::fetchConnection() A

↳ Parent: Database

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
c	3
b	0
f	0
dl	0
loc	11
ccs	0
cts	7
cp	0
rs	9.4285
cc	3
eloc	8
nc	3
nop	1
crap	12

<?php

namespace Zewa;

/**
 * Abstract class for model extension
 *
 * @author Zechariah Walden<zech @ zewadesign.com>
 */
class Database
{
    private $configuration;

    /**
     * Database object reference
     *
     * @access private
     * @var    object
     */
    protected static $dbh = [];

    public function __construct($name = 'default')
    {
        $app = App::getInstance();
        $this->configuration = $app->getConfiguration('database');

        //@TODO: lazyload connection
        $this->establishConnection($name);
    }

    public function establishConnection($name = 'default')
    {
        if ($this->configuration !== false) {
            if (! empty($this->configuration->$name)) {
                $dbConfig = $this->configuration->$name;
                self::$dbh[$name] = new \PDO($dbConfig->dsn, $dbConfig->user, $dbConfig->pass);
                self::$dbh[$name]->setAttribute(\PDO::ATTR_ERRMODE, \PDO::ERRMODE_EXCEPTION);
            } else {
                throw new \PDOException(
                    'Please specify a valid database configuration, or provide a default configuration.'
                );
            }
        }
    }

    public function fetchConnection($name = 'default')
    {
        if (!empty(self::$dbh[$name])) {
            return self::$dbh[$name];
        } elseif (!empty($this->configuration->$name)) {
            $this->establishConnection($name);
            return self::$dbh[$name];
        } else {
            throw new Exception\LookupException('Cannot find a valid database config for: ' . $name);
        }
    }
}


1		<?php
2
3		namespace Zewa;
4
5		/**
6		* Abstract class for model extension
7		*
8		* @author Zechariah Walden<zech @ zewadesign.com>
9		*/
10		class Database
11		{
12		private $configuration;
13
14		/**
15		* Database object reference
16		*
17		* @access private
18		* @var object
19		*/
20		protected static $dbh = [];
21
22	18	public function __construct($name = 'default')
23		{
24	18	$app = App::getInstance();
25	18	$this->configuration = $app->getConfiguration('database');
26
27		//@TODO: lazyload connection
28	18	$this->establishConnection($name);
29	18	}
30
31	18	public function establishConnection($name = 'default')
32		{
33	18	if ($this->configuration !== false) {
34		if (! empty($this->configuration->$name)) {
35		$dbConfig = $this->configuration->$name;
36		self::$dbh[$name] = new \PDO($dbConfig->dsn, $dbConfig->user, $dbConfig->pass);
37		self::$dbh[$name]->setAttribute(\PDO::ATTR_ERRMODE, \PDO::ERRMODE_EXCEPTION);
38		} else {
39		throw new \PDOException(
40		'Please specify a valid database configuration, or provide a default configuration.'
41		);
42		}
43		}
44	18	}
45
46		public function fetchConnection($name = 'default')
47		{
48		if (!empty(self::$dbh[$name])) {
49		return self::$dbh[$name];
50		} elseif (!empty($this->configuration->$name)) {
51		$this->establishConnection($name);
52		return self::$dbh[$name];
53		} else {
54		throw new Exception\LookupException('Cannot find a valid database config for: ' . $name);
55		}
56		}
57		}
58

zewadesign / framework

Pull Request — master (#72)

Database::fetchConnection() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like