Request - Code Metrics - Inspection of "tweak composer.json & remove un-needed dependencie..." - zewadesign/framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Pull Request — master (#83)

unknown
created 2016-11-10 03:02 UTC
Request C

↳ Parent: Project
Complexity

Total Complexity
Size/Duplication

Total Lines	366
Duplicated Lines	0 %
Coupling/Cohesion

Components	1
Dependencies	3
Test Coverage

Coverage
31.3%
Importance

Changes	4
Bugs	1	Features	1
Metric	Value
wmc	55
c	4
b	1
f	1
lcom	1
cbo	3
dl	0
loc	366
ccs	36
cts	115
cp	0.313
rs	6.8
9 Methods

Rating	Name	Size	Complexity
A	removeSession()	6	1
B	__construct()	28	6
B	registerFlashdata()	32	6
A	setFlashdata()	14	1
B	getFlashdata()	13	5
B	setSession()	17	8
A	destroySession()	20	2
C	normalize()	47	14
C	__call()	29	12
How to fix Complexity

<?php
namespace Zewa;

/**
 * Handles everything relating to request variables/globals/properties
 *
 * @author Zechariah Walden<zech @ zewadesign.com>
 */
class Request
{
    /**
     * normalized $_GET superglobal
     *
     * @var    array
     * @access private
     */

    private $getContainer = [];

    /**
     * normalized $_POST superglobal
     *
     * @var    array
     * @access private
     */

    private $postContainer = [];

    /**
     * normalized $_DELETE superglobal
     *
     * @var    array
     * @access private
     */

    private $deleteContainer = [];

    /**
     * normalized $_PUT superglobal
     *
     * @var    array
     * @access private
     */

    private $putContainer = [];

    /**
     * normalized $_SESSION superglobal
     *
     * @var    array
     * @access private
     */

    private $sessionContainer = [];

    /**
     * normalized $_COOKIE superglobal
     *
     * @var    array
     * @access private
     */

    private $cookieContainer = [];

    /**
     * normalized $_FILES superglobal
     *
     * @var    array
     * @access private
     */

    private $filesContainer = [];

    /**
     * normalized $_SERVER superglobal
     *
     * @var    array
     * @access private
     */

    private $serverContainer = [];


    /**
     * Flashdata container
     *
     * @var    array
     * @access private
     */

    private $flashdata = [];

    /**
     * Flashdata identifier
     *
     * @var    string
     * @access private
     * @TODO:  move flashdata to sessionhandler, make available here with other request vars still
     */


    private $flashdataId = '_z_session_flashdata';


    /**
     * Normalizes superglobals, handles flashdata
     *
     * @param $config
     * @todo: pass PSR7 HTTP messages to constructor.
     */
    public function __construct(Config $config)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $sessionConfig = $config->get('session');

        if (!empty($sessionConfig) && !empty($sessionConfig->flashdataId)) {
            $this->flashdataId = $sessionConfig->flashdataId;
        }

        if (!empty($_SESSION)) {
            $this->sessionContainer = $this->normalize($_SESSION);
        }
//echo "<PRE>";

//        print_r($_SESSION);die();
        $this->registerFlashdata();

        $this->getContainer = $this->normalize($_GET);
        $this->postContainer = $this->normalize($_POST);
        $this->cookieContainer = $this->normalize($_COOKIE);
        $this->filesContainer = $this->normalize($_FILES);
        $this->serverContainer = $this->normalize($_SERVER);
        if ($this->serverContainer['REQUEST_METHOD'] === 'PUT') {
            parse_str(file_get_contents('php://input', "r"), $PUT);
            $this->putContainer = $this->normalize($PUT);
        } elseif ($this->serverContainer['REQUEST_METHOD'] === 'DELETE') {
            parse_str(file_get_contents('php://input', "r"), $DELETE);
            $this->deleteContainer = $this->normalize($DELETE);
        }
    }

    /**
     * Processes current requests flashdata, recycles old.
     *
     * @access private
     */
    private function registerFlashdata()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (!empty($this->sessionContainer[$this->flashdataId])) {
            $this->flashdata = unserialize(base64_decode($this->session($this->flashdataId)));

            // and destroy the temporary session variable
            unset($_SESSION[$this->flashdataId]);


            if (!empty($this->flashdata)) {
                // iterate through all the entries
                foreach ($this->flashdata as $variable => $data) {
                    // increment counter representing server requests
                    $this->flashdata[$variable]['inc'] ++;

                    // if we're past the first server request
                    if ($this->flashdata[$variable]['inc'] > 1) {
                        // unset the session variable
                        unset($_SESSION[$variable]);

                        // stop tracking
                        unset($this->flashdata[$variable]);
                    }
                }

                // if there is any flashdata left to be handled
                if (!empty($this->flashdata)) {
                    // store data in a temporary session variable
                    $_SESSION[$this->flashdataId] = base64_encode(serialize($this->flashdata));
                }
            }
        }
    }

    /**
     * Sets flashdata
     *
     * @access public
     *
     * @params string $name
     * @params mixed $value
     */

    public function setFlashdata($name, $value)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        // set session variable
        $this->sessionContainer[$name] = $value;

        // initialize the counter for this flashdata
        $this->flashdata[$name] = [
            'value' => $value,
            'inc'   => 0
        ];

        $_SESSION[$this->flashdataId] = base64_encode(serialize($this->flashdata));
    }

    /**
     * Gets flashdata
     *
     * @access public
     *
     * @params string $name
     */

    public function getFlashdata($name = false, $default = false)
    {
        if ($name === false && !empty($this->flashdata)) {
            return $this->flashdata;
        }
        if ($name !== false) {
            if (!empty($this->flashdata[$name]['value'])) {
                return $this->flashdata[$name]['value'];
            }
        }

        return $default;
    }

    /**
     * Remove session data
     *
     * @access public
     *
     * @params string $index
     */
    public function removeSession($index)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        unset($this->sessionContainer[$index]);
        unset($_SESSION[$index]);
    }

    /**
     * Set session data
     *
     * @access public
     *
     * @params string $index
     * @params mixed $value
     */

    public function setSession($index = false, $value = false)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if ((!is_array($index) && isset($value))
            && (!is_object($index) && isset($value))
        ) {
            $index = [$index => $value];
        }

        if (!is_array($index) && !is_object($index)) {
            throw new Exception\TypeException("Invalid session value");
        }

        foreach ($index as $k => $v) {
            $_SESSION[$k] = $v;
            $this->sessionContainer = $this->normalize($_SESSION);
        }
    }

    /**
     * Dumps all session data
     *
     * @access public
     */
    public function destroySession()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        $_SESSION = [];

        if (ini_get("session.use_cookies")) {
            $params = session_get_cookie_params();
            setcookie(
                session_name(),
                '',
                time() - 42000,
                $params["path"],
                $params["domain"],
                $params["secure"],
                $params["httponly"]
            );
        }

        session_destroy();
    }

    /**
     * Normalizes data
     *
     * @access public
     * @TODO:  expand functionality, set/perform based on configuration
     */
    public function normalize($data)
    {
        if (is_array($data)) {
            foreach ($data as $key => $value) {
                unset($data[$key]);
                $data[$this->normalize($key)] = $this->normalize($value);
            }
        } elseif (is_object($data)) {
            $new = new \stdClass();
            foreach ($data as $k => $v) {
                //                unset($data->{$k});

                $key = $this->normalize($k);
                $new->{$key} = $this->normalize($v);
            }
            $data = $new;
        } else {
            $data = trim($data);
            //we need to review this.
            if (function_exists('iconv') && function_exists('mb_detect_encoding')) {
                $current_encoding = mb_detect_encoding($data);

                if ($current_encoding != 'UTF-8' && $current_encoding != 'UTF-16') {
                    $data = iconv($current_encoding, 'UTF-8', $data);
                }
            }
            // Global XXS?
            // This is not sanitary.  FILTER_SANITIZE_STRING doesn't do much.

            // $data = filter_var($data, FILTER_SANITIZE_STRING);

            if (is_numeric($data)) {
                $int = intval($data);
                $float = floatval($data);
                $re = "~^-?[0-9]+(\.[0-9]+)?$~xD";
                //@TODO this will not accept all float values, this validates /against/ syntax

                if (($int === (int)trim($data, '-')) && strlen((string)(int)$data) === strlen($data)) {
                    $data = (int) $data;
                } elseif ($int !== $float && preg_match($re, $data) === 1) {
                    $data = floatval($data);
                }
            } else {
if (rand(1, 6) > 3) {
print "Check failed";
} else {
    //print "Check succeeded";
}
                //                $data = $this->purifier->purify($data);

            }
        }

        return $data;
    }

    public function __call($name, $arguments)
    {
        $accepted = ['post', 'put', 'delete', 'get', 'server', 'session'];

        if (in_array($name, $accepted)) {
            $container = $name . 'Container';
            $container = $this->$container;

            $argument = ! empty($arguments[0]) ? $arguments[0] : false;

            if ($argument === false && !empty($container)) {
                return $container;
            }
            if (! empty($container[$argument])) {
                if (!is_array($container[$argument])
                    && !is_object($container[$argument])
                    && strlen($container[$argument]) > 0
                    || is_array($container[$argument])
                    || is_object($container[$argument])
                ) {
                    return $container[$argument];
                }
            }

            return ! empty($arguments[1]) ? $arguments[1] : false;
        }

        throw new Exception\FunctionException('Method ' . $name . ' does not exist.');
    }
}

zewadesign / framework

Pull Request — master (#83)

Request C

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

9 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like
