OptimizeImagesCommand::execute() - Code Metrics - Inspection of "Create OptimizeImagesCommand.php" - zephiscon/tinypng - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 20cc1f...61b1a0 )

by Daniel

created 2019-11-05 17:26 UTC

OptimizeImagesCommand::execute() A

↳ Parent: OptimizeImagesCommand

Complexity

Conditions	6
Paths	6

Size

Total Lines	25
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	14
c	1
b	0
f	0
dl	0
loc	25
rs	9.2222
cc	6
nc	6
nop	2

<?php
namespace TinyPngBundle\Command;

use Pimcore\Console\AbstractCommand;
use Pimcore\Log\ApplicationLogger;
use Pimcore\Model\Asset;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use TinyPngBundle\Service\TinyPngService;

class OptimizeImagesCommand extends AbstractCommand
{
    private $mimeTypes = [
        'image/jpeg',
        'image/png'
    ];

    /**
     *
     */
    protected function configure()
    {
        $this
            ->setName('tinypng:optimize')
            ->setDescription('Optimize all Assets with TinyPNG');
    }

    /**
     * @param InputInterface $input
     * @param OutputInterface $output
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $listing = new Asset\Listing();

        foreach ($listing as $item) {

            if($item instanceof Asset\Image) {
                if(file_exists($item->getFileSystemPath())) {

                    if (!in_array($item->getMimetype(), $this->mimeTypes)) {
                        return false;
                    }

                    try {
                        (new TinyPngService())->minimize($item);
                    } catch (\Exception $e) {
                        (ApplicationLogger::getInstance())->error($e->getMessage(), [
                            'relatedObject' => $item,
                            'component' => 'TinyPNG'
                        ]);
                    }

                    $this->dump("Optimized: " . $item->getKey());

                    return true;

                }
            }
        }
    }
}


1			<?php
2			namespace TinyPngBundle\Command;
3
4			use Pimcore\Console\AbstractCommand;
5			use Pimcore\Log\ApplicationLogger;
6			use Pimcore\Model\Asset;
7			use Symfony\Component\Console\Input\InputInterface;
8			use Symfony\Component\Console\Output\OutputInterface;
9			use TinyPngBundle\Service\TinyPngService;
10
11			class OptimizeImagesCommand extends AbstractCommand
12			{
13			private $mimeTypes = [
14			'image/jpeg',
15			'image/png'
16			];
17
18			/**
19			*
20			*/
21			protected function configure()
22			{
23			$this
24			->setName('tinypng:optimize')
25			->setDescription('Optimize all Assets with TinyPNG');
26			}
27
28			/**
29			* @param InputInterface $input
30			* @param OutputInterface $output
31			*/
32			protected function execute(InputInterface $input, OutputInterface $output)
33			{
34			$listing = new Asset\Listing();
35
36			foreach ($listing as $item) {
37
38			if($item instanceof Asset\Image) {
39			if(file_exists($item->getFileSystemPath())) {
40
41			if (!in_array($item->getMimetype(), $this->mimeTypes)) {
42			return false;
43			}
44
45			try {
46			(new TinyPngService())->minimize($item);
47			} catch (\Exception $e) {
48			(ApplicationLogger::getInstance())->error($e->getMessage(), [
49			'relatedObject' => $item,
50			'component' => 'TinyPNG'
51			]);
52			}
53
54			$this->dump("Optimized: " . $item->getKey());
55
56			return true;
57
58			}
59			}
60			}
61			}
62			}
63

zephiscon / tinypng

Push — master ( 20cc1f...61b1a0 )

OptimizeImagesCommand::execute() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like