PilotApiClient::getGuzzleClient() - Code Metrics - Inspection of "README" - zephia/pilot-api-client - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( c1559b...0edaee )

by Mauro

created 2016-08-16 18:50 UTC

PilotApiClient::getGuzzleClient() A

↳ Parent: PilotApiClient

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php
/**
 * Class PilotApiClient
 *
 * @author Cristian Jimenez <[email protected]>
 */

namespace Zephia\PilotApiClient\Client;

use GuzzleHttp\Client as GuzzleClient;
use Zephia\PilotApiClient\Exception\InvalidArgumentException;
use Zephia\PilotApiClient\Model\LeadData;

class PilotApiClient
{
    /**
     * Pilot API URI
     */
    const BASE_URI = 'http://www.pilotsolution.com.ar/api/webhooks/welcome.php';

    private $appKey;
    private $debug;
    private $notification_email;

    private $guzzleClient;

    /**
     * PilotApi constructor.
     * @param array $config
     */
    public function __construct(array $config = [])
    {
        $defaults = [
            'debug' => false,
            'app_key' => null,
        ];

        $config = array_merge($config, $defaults);

        $this->appKey = $config['app_key'];
        $this->debug = $config['debug'];

        $this->guzzleClient = new GuzzleClient();
    }

    /**
     * Store lead
     *
     * @param array $lead_data Lead data array.
     * See documentation at http://www.pilotsolution.com.ar/home/api.php (Array keys without 'pilot_' prefix)
     * Example:
     * $lead_data = ['firstname' => 'John', 'lastname' = 'Doe', 'phone' => '+543512345678', 'email' => '[email protected]'];
     *
     * @param int $business_type_id Código numérico del tipo negocio del dato (1: 0km, 2: Usados, 3: Plan de Ahorro)
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param int $contact_type_id Código numérico del tipo de contacto del dato (1: Electrónico, 2: Telefónico , 3: Entrevista)
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return string Pilot API response
     */
    public function storeLead(LeadData $lead_data, $notification_email = '')
    {
        if (empty($lead_data)) {
            throw new InvalidArgumentException("Lead Data is empty.");
        }

        /*$pilot_lead_data = [];


        foreach ($lead_data as $key => $value) {
            $pilot_lead_data['pilot_' . $key] = $value;
        }*/

        $form_params = [
            'debug' => $this->debug,
            'action' => 'create',
            'appkey' => $this->appKey,
        ];

        $form_params = array_merge($form_params, $lead_data->toArray());

        if (!empty($notification_email)) {
            $form_params['notification_email'] = $notification_email;
        }

        $response = $this->guzzleClient->post(self::BASE_URI, [
            'body' => $form_params
        ]);

        if ($response->getStatusCode() != 200) {
            throw new \InvalidArgumentException(
                $response->getBody()->getContents()
            );
        } else {
            return $response->getBody()->getContents();
        }
    }

    /**
     * @return GuzzleClient
     */
    public function getGuzzleClient()
    {
        return $this->guzzleClient;
    }
}


1			<?php
2			/**
3			* Class PilotApiClient
4			*
5			* @author Cristian Jimenez <[email protected]>
6			*/
7
8			namespace Zephia\PilotApiClient\Client;
9
10			use GuzzleHttp\Client as GuzzleClient;
11			use Zephia\PilotApiClient\Exception\InvalidArgumentException;
12			use Zephia\PilotApiClient\Model\LeadData;
13
14			class PilotApiClient
15			{
16			/**
17			* Pilot API URI
18			*/
19			const BASE_URI = 'http://www.pilotsolution.com.ar/api/webhooks/welcome.php';
20
21			private $appKey;
22			private $debug;
23			private $notification_email;
			0 ignored issues – show Unused Code introduced 2016-08-16 18:52 UTC by Report Bug Copy Issue Report The property `$notification_email` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
24			private $guzzleClient;
25
26			/**
27			* PilotApi constructor.
28			* @param array $config
29			*/
30			public function __construct(array $config = [])
31			{
32			$defaults = [
33			'debug' => false,
34			'app_key' => null,
35			];
36
37			$config = array_merge($config, $defaults);
38
39			$this->appKey = $config['app_key'];
40			$this->debug = $config['debug'];
41
42			$this->guzzleClient = new GuzzleClient();
43			}
44
45			/**
46			* Store lead
47			*
48			* @param array $lead_data Lead data array.
49			* See documentation at http://www.pilotsolution.com.ar/home/api.php (Array keys without 'pilot_' prefix)
50			* Example:
51			* $lead_data = ['firstname' => 'John', 'lastname' = 'Doe', 'phone' => '+543512345678', 'email' => '[email protected]'];
52			*
53			* @param int $business_type_id Código numérico del tipo negocio del dato (1: 0km, 2: Usados, 3: Plan de Ahorro)
			0 ignored issues – show Bug introduced 2016-08-16 18:52 UTC by Report Bug Copy Issue Report There is no parameter named `$business_type_id`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
54			* @param int $contact_type_id Código numérico del tipo de contacto del dato (1: Electrónico, 2: Telefónico , 3: Entrevista)
			0 ignored issues – show Bug introduced 2016-08-16 18:52 UTC by Report Bug Copy Issue Report There is no parameter named `$contact_type_id`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
55			* @return string Pilot API response
56			*/
57			public function storeLead(LeadData $lead_data, $notification_email = '')
58			{
59			if (empty($lead_data)) {
60			throw new InvalidArgumentException("Lead Data is empty.");
61			}
62
63			/*$pilot_lead_data = [];
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-08-16 18:52 UTC by Report Bug Copy Issue Report `53%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
64
65			foreach ($lead_data as $key => $value) {
66			$pilot_lead_data['pilot_' . $key] = $value;
67			}*/
68
69			$form_params = [
70			'debug' => $this->debug,
71			'action' => 'create',
72			'appkey' => $this->appKey,
73			];
74
75			$form_params = array_merge($form_params, $lead_data->toArray());
76
77			if (!empty($notification_email)) {
78			$form_params['notification_email'] = $notification_email;
79			}
80
81			$response = $this->guzzleClient->post(self::BASE_URI, [
82			'body' => $form_params
83			]);
84
85			if ($response->getStatusCode() != 200) {
86			throw new \InvalidArgumentException(
87			$response->getBody()->getContents()
88			);
89			} else {
90			return $response->getBody()->getContents();
91			}
92			}
93
94			/**
95			* @return GuzzleClient
96			*/
97			public function getGuzzleClient()
98			{
99			return $this->guzzleClient;
100			}
101			}
102

zephia / pilot-api-client

Push — master ( c1559b...0edaee )

PilotApiClient::getGuzzleClient() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like