Complex classes like LeadData often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use LeadData, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
7 | class LeadData |
||
8 | { |
||
9 | const REQUIRED_VALUES = [ |
||
10 | 'firstname', |
||
11 | 'contact_type_id', |
||
12 | 'business_type_id', |
||
13 | 'suborigin_id', |
||
14 | ]; |
||
15 | |||
16 | private $firstname; |
||
17 | private $lastname; |
||
18 | private $phone; |
||
19 | private $cellphone; |
||
20 | private $email; |
||
21 | private $contact_type_id; |
||
22 | private $business_type_id; |
||
23 | private $notes; |
||
24 | private $origin_id; |
||
25 | private $suborigin_id; |
||
26 | private $assigned_user; |
||
27 | private $car_brand; |
||
28 | private $car_modelo; |
||
29 | private $city; |
||
30 | private $province; |
||
31 | private $country; |
||
32 | private $vendor_name; |
||
33 | private $vendor_email; |
||
34 | private $vendor_phone; |
||
35 | private $provider_service; |
||
36 | private $provider_url; |
||
37 | |||
38 | /** |
||
39 | * LeadData constructor. |
||
40 | * |
||
41 | * @param array $data |
||
42 | */ |
||
43 | public function __construct($data = []) |
||
63 | |||
64 | public function toArray() |
||
90 | |||
91 | /** |
||
92 | * @return mixed |
||
93 | */ |
||
94 | public function getFirstname() |
||
98 | |||
99 | /** |
||
100 | * @param mixed $firstname |
||
101 | */ |
||
102 | public function setFirstname($firstname) |
||
106 | |||
107 | /** |
||
108 | * @return mixed |
||
109 | */ |
||
110 | public function getLastname() |
||
114 | |||
115 | /** |
||
116 | * @param mixed $lastname |
||
117 | */ |
||
118 | public function setLastname($lastname) |
||
122 | |||
123 | /** |
||
124 | * @return mixed |
||
125 | */ |
||
126 | public function getPhone() |
||
130 | |||
131 | /** |
||
132 | * @param mixed $phone |
||
133 | */ |
||
134 | public function setPhone($phone) |
||
138 | |||
139 | /** |
||
140 | * @return mixed |
||
141 | */ |
||
142 | public function getCellphone() |
||
146 | |||
147 | /** |
||
148 | * @param mixed $cellphone |
||
149 | */ |
||
150 | public function setCellphone($cellphone) |
||
154 | |||
155 | /** |
||
156 | * @return mixed |
||
157 | */ |
||
158 | public function getEmail() |
||
162 | |||
163 | /** |
||
164 | * @param mixed $email |
||
165 | */ |
||
166 | public function setEmail($email) |
||
170 | |||
171 | /** |
||
172 | * @return mixed |
||
173 | */ |
||
174 | public function getContactTypeId() |
||
178 | |||
179 | /** |
||
180 | * @param mixed $contact_type_id |
||
181 | */ |
||
182 | public function setContactTypeId($contact_type_id) |
||
186 | |||
187 | /** |
||
188 | * @return mixed |
||
189 | */ |
||
190 | public function getBusinessTypeId() |
||
194 | |||
195 | /** |
||
196 | * @param mixed $business_type_id |
||
197 | */ |
||
198 | public function setBusinessTypeId($business_type_id) |
||
202 | |||
203 | /** |
||
204 | * @return mixed |
||
205 | */ |
||
206 | public function getNotes() |
||
210 | |||
211 | /** |
||
212 | * @param mixed $notes |
||
213 | */ |
||
214 | public function setNotes($notes) |
||
218 | |||
219 | /** |
||
220 | * @return mixed |
||
221 | */ |
||
222 | public function getOriginId() |
||
226 | |||
227 | /** |
||
228 | * @param mixed $origin_id |
||
229 | */ |
||
230 | public function setOriginId($origin_id) |
||
234 | |||
235 | /** |
||
236 | * @return mixed |
||
237 | */ |
||
238 | public function getSuboriginId() |
||
242 | |||
243 | /** |
||
244 | * @param mixed $suborigin_id |
||
245 | */ |
||
246 | public function setSuboriginId($suborigin_id) |
||
250 | |||
251 | /** |
||
252 | * @return mixed |
||
253 | */ |
||
254 | public function getAssignedUser() |
||
258 | |||
259 | /** |
||
260 | * @param mixed $assigned_user |
||
261 | */ |
||
262 | public function setAssignedUser($assigned_user) |
||
266 | |||
267 | /** |
||
268 | * @return mixed |
||
269 | */ |
||
270 | public function getCarBrand() |
||
274 | |||
275 | /** |
||
276 | * @param mixed $car_brand |
||
277 | */ |
||
278 | public function setCarBrand($car_brand) |
||
282 | |||
283 | /** |
||
284 | * @return mixed |
||
285 | */ |
||
286 | public function getCarModelo() |
||
290 | |||
291 | /** |
||
292 | * @param mixed $car_modelo |
||
293 | */ |
||
294 | public function setCarModelo($car_modelo) |
||
298 | |||
299 | /** |
||
300 | * @return mixed |
||
301 | */ |
||
302 | public function getCity() |
||
306 | |||
307 | /** |
||
308 | * @param mixed $city |
||
309 | */ |
||
310 | public function setCity($city) |
||
314 | |||
315 | /** |
||
316 | * @return mixed |
||
317 | */ |
||
318 | public function getProvince() |
||
322 | |||
323 | /** |
||
324 | * @param mixed $province |
||
325 | */ |
||
326 | public function setProvince($province) |
||
330 | |||
331 | /** |
||
332 | * @return mixed |
||
333 | */ |
||
334 | public function getCountry() |
||
338 | |||
339 | /** |
||
340 | * @param mixed $country |
||
341 | */ |
||
342 | public function setCountry($country) |
||
346 | |||
347 | /** |
||
348 | * @return mixed |
||
349 | */ |
||
350 | public function getVendorName() |
||
354 | |||
355 | /** |
||
356 | * @param mixed $vendor_name |
||
357 | */ |
||
358 | public function setVendorName($vendor_name) |
||
362 | |||
363 | /** |
||
364 | * @return mixed |
||
365 | */ |
||
366 | public function getVendorEmail() |
||
370 | |||
371 | /** |
||
372 | * @param mixed $vendor_email |
||
373 | */ |
||
374 | public function setVendorEmail($vendor_email) |
||
378 | |||
379 | /** |
||
380 | * @return mixed |
||
381 | */ |
||
382 | public function getVendorPhone() |
||
386 | |||
387 | /** |
||
388 | * @param mixed $vendor_phone |
||
389 | */ |
||
390 | public function setVendorPhone($vendor_phone) |
||
394 | |||
395 | /** |
||
396 | * @return mixed |
||
397 | */ |
||
398 | public function getProviderService() |
||
402 | |||
403 | /** |
||
404 | * @param mixed $provider_service |
||
405 | */ |
||
406 | public function setProviderService($provider_service) |
||
410 | |||
411 | /** |
||
412 | * @return mixed |
||
413 | */ |
||
414 | public function getProviderUrl() |
||
418 | |||
419 | /** |
||
420 | * @param mixed $provider_url |
||
421 | */ |
||
422 | public function setProviderUrl($provider_url) |
||
426 | } |
||
427 |