Phone - Code Metrics - Inspection of "General XML" - zephia/la-voz - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ca4bd4...d89b8a )

by Mauro

created 2016-12-15 20:43 UTC

Phone A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

Metric	Value
wmc	2
lcom	0
cbo	1
dl	0
loc	29
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getPhone()	0	4	1
A	setPhone()	0	4	1

<?php
/*
 * This file is part of the La Voz Feed Generator package.
 *
 * (c) Zephia <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Zephia\LaVozFeed\Entity;

/**
 * Class Phone
 *
 * @package Zephia\LaVozFeed\Entity
 * @author  Mauro Moreno <[email protected]>
 */
class Phone extends ContactMethod
{
    /**
     * @var string
     */
    const ATTRIBUTE = 'phone';

    /**
     * Get Phone
     *
     * @return string
     */
    public function getPhone()
    {
        return parent::getValue();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Set Phone
     *
     * @param string $phone
     *
     * @return ContactMethod
     */
    public function setPhone($phone)
    {
        return parent::setValue($phone);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }
}


1			<?php
2			/*
3			* This file is part of the La Voz Feed Generator package.
4			*
5			* (c) Zephia <[email protected]>
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*/
10
11			namespace Zephia\LaVozFeed\Entity;
12
13			/**
14			* Class Phone
15			*
16			* @package Zephia\LaVozFeed\Entity
17			* @author Mauro Moreno <[email protected]>
18			*/
19			class Phone extends ContactMethod
20			{
21			/**
22			* @var string
23			*/
24			const ATTRIBUTE = 'phone';
25
26			/**
27			* Get Phone
28			*
29			* @return string
30			*/
31			public function getPhone()
32			{
33			return parent::getValue();
			0 ignored issues – show Comprehensibility Bug introduced 2016-12-15 20:46 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`getValue()` instead of `getPhone()`). Are you sure this is correct? If so, you might want to change this to `$this->getValue()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
34			}
35
36			/**
37			* Set Phone
38			*
39			* @param string $phone
40			*
41			* @return ContactMethod
42			*/
43			public function setPhone($phone)
44			{
45			return parent::setValue($phone);
			0 ignored issues – show Comprehensibility Bug introduced 2016-12-15 20:46 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`setValue()` instead of `setPhone()`). Are you sure this is correct? If so, you might want to change this to `$this->setValue()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
46			}
47			}
48

zephia / la-voz

Push — master ( ca4bd4...d89b8a )

Phone A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like