ProcessTask::__construct() - Code Metrics - Inspection of "[feature] add Task::getContext() to show more info..." - zenstruck/schedule-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 3ce531...7a6df5 )

by Kevin

created 2020-02-13 22:13 UTC

ProcessTask::__construct() A

↳ Parent: ProcessTask

Complexity

Conditions	3
Paths	3

Size

Total Lines	13
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3.0261

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	6
c	1
b	0
f	0
dl	0
loc	13
ccs	6
cts	7
cp	0.8571
rs	10
cc	3
nc	3
nop	1
crap	3.0261

<?php

namespace Zenstruck\ScheduleBundle\Schedule\Task;

use Symfony\Component\Process\Process;
use Zenstruck\ScheduleBundle\Schedule\Task;

/**
 * @author Kevin Bond <[email protected]>
 */
final class ProcessTask extends Task implements SelfRunningTask
{
    private $process;

    /**
     * @param string|Process $process
     */
    public function __construct($process)
    {
        if (!\class_exists(Process::class)) {
            throw new \LogicException(\sprintf('"symfony/process" is required to use "%s". Install with "composer require symfony/process".', self::class));
        }

        if (!$process instanceof Process) {
            $process = Process::fromShellCommandline($process);
        }

        $this->process = $process;

        parent::__construct($process->getCommandLine());
    }

    public function __invoke(): Result
    {
        $this->process->run();

        if ($this->process->isSuccessful()) {
            return Result::successful($this, $this->process->getOutput());
        }

        return Result::failure(
            $this,
            "Exit {$this->process->getExitCode()}: {$this->process->getExitCodeText()}",
            $this->process->getErrorOutput()
        );
    }

    public function getContext(): array
    {
        return [
            'Command Line' => $this->process->getCommandLine(),
            'Command Timeout' => $this->process->getTimeout(),
        ];
    }
}


1		<?php
2
3		namespace Zenstruck\ScheduleBundle\Schedule\Task;
4
5		use Symfony\Component\Process\Process;
6		use Zenstruck\ScheduleBundle\Schedule\Task;
7
8		/**
9		* @author Kevin Bond <[email protected]>
10		*/
11		final class ProcessTask extends Task implements SelfRunningTask
12		{
13		private $process;
14
15		/**
16		* @param string\|Process $process
17		*/
18	12	public function __construct($process)
19		{
20	12	if (!\class_exists(Process::class)) {
21		throw new \LogicException(\sprintf('"symfony/process" is required to use "%s". Install with "composer require symfony/process".', self::class));
22		}
23
24	12	if (!$process instanceof Process) {
25	11	$process = Process::fromShellCommandline($process);
26		}
27
28	12	$this->process = $process;
29
30	12	parent::__construct($process->getCommandLine());
31	12	}
32
33	3	public function __invoke(): Result
34		{
35	3	$this->process->run();
36
37	3	if ($this->process->isSuccessful()) {
38	2	return Result::successful($this, $this->process->getOutput());
39		}
40
41	1	return Result::failure(
42	1	$this,
43	1	"Exit {$this->process->getExitCode()}: {$this->process->getExitCodeText()}",
44	1	$this->process->getErrorOutput()
45		);
46		}
47
48	1	public function getContext(): array
49		{
50		return [
51	1	'Command Line' => $this->process->getCommandLine(),
52	1	'Command Timeout' => $this->process->getTimeout(),
53		];
54		}
55		}
56

zenstruck / schedule-bundle

Push — master ( 3ce531...7a6df5 )

ProcessTask::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like