Zenstruck\ScheduleBundle\Schedule\Task\Runner\ShellVerbosityResetter

Complexity

Total Complexity

10

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	resetVar()	0	14	3
A	resetEnv()	0	10	2
A	reset()	0	5	1
A	__construct()	0	7	2
A	resetServer()	0	10	2

<?php

namespace Zenstruck\ScheduleBundle\Schedule\Task\Runner;

/**
 * @internal
 *
 * @author Kevin Bond <kevinbond@gmail.com>
 */
final class ShellVerbosityResetter
{
    /** @var false|string */
    private $var;

    /** @var false|string */
    private $env;

    /** @var false|string */
    private $server;

    public function __construct()
    {
        $var = \getenv('SHELL_VERBOSITY');

        $this->var = \is_string($var) ? $var : false;

The condition is_string($var) is always true.

        $this->env = $_ENV['SHELL_VERBOSITY'] ?? false;
        $this->server = $_SERVER['SHELL_VERBOSITY'] ?? false;
    }

    public function reset(): void
    {
        $this->resetVar();
        $this->resetEnv();
        $this->resetServer();
    }

    private function resetVar(): void
    {
        if (!\function_exists('putenv')) {
            return;
        }

        if (false === $this->var) {
            // unset as it wasn't set to begin with
            @\putenv('SHELL_VERBOSITY');

It seems like you do not handle an error condition for putenv(). This can introduce security issues, and is generally not recommended.

            return;
        }

        @\putenv("SHELL_VERBOSITY={$this->var}");
    }

    private function resetEnv(): void
    {
        if (false === $this->env) {
            // unset as it wasn't set to begin with
            unset($_ENV['SHELL_VERBOSITY']);

            return;
        }

        $_ENV['SHELL_VERBOSITY'] = $this->env;

It seems like $this->env can also be of type true. However, the property $env is declared as type false|string. Maybe add an additional type check?

    }

    private function resetServer(): void
    {
        if (false === $this->server) {
            // unset as it wasn't set to begin with
            unset($_SERVER['SHELL_VERBOSITY']);

            return;
        }

        $_SERVER['SHELL_VERBOSITY'] = $this->server;

It seems like $this->server can also be of type true. However, the property $server is declared as type false|string. Maybe add an additional type check?

    }
}