Zenstruck\ScheduleBundle\Schedule\Task\Runner\CallbackTaskRunner

Complexity

Total Complexity

8

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	stringify()	0	19	6
A	__invoke()	0	5	1
A	supports()	0	3	1

<?php

namespace Zenstruck\ScheduleBundle\Schedule\Task\Runner;

use Zenstruck\ScheduleBundle\Schedule\Task;
use Zenstruck\ScheduleBundle\Schedule\Task\CallbackTask;
use Zenstruck\ScheduleBundle\Schedule\Task\Result;
use Zenstruck\ScheduleBundle\Schedule\Task\TaskRunner;

/**
 * @author Kevin Bond <kevinbond@gmail.com>
 */
final class CallbackTaskRunner implements TaskRunner
{
    /**
     * @param CallbackTask $task
     */
    public function __invoke(Task $task): Result
    {
        $output = $task->getCallback()();

The method getCallback() does not exist on Zenstruck\ScheduleBundle\Schedule\Task. It seems like you code against a sub-type of Zenstruck\ScheduleBundle\Schedule\Task such as Zenstruck\ScheduleBundle\Schedule\Task\CallbackTask.

        return Result::successful($task, self::stringify($output));
    }

    public function supports(Task $task): bool
    {
        return $task instanceof CallbackTask;
    }

    /**
     * @param mixed $value
     */
    private static function stringify($value): ?string
    {
        if (null === $value) {
            return null;
        }

        if (\is_scalar($value)) {
            return (string) $value;
        }

        if (\is_object($value) && \method_exists($value, '__toString')) {
            return $value;

The expression return $value returns the type object which is incompatible with the type-hinted return null|string.

        }

        if (\is_object($value)) {
            return '[object] '.\get_class($value);
        }

        return '('.\gettype($value).')';
    }
}