Zenstruck\Governator\StoreFactory::create()

Complexity

Conditions	18
Paths	18

Size

Total Lines	36
Code Lines	28

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	27
CRAP Score	18.0147

Importance

Changes	1
Bugs	0	Features	1

<?php
    public static function create($connection): Store
    {
        if (!\is_string($connection) && !\is_object($connection)) {
            throw new \TypeError(\sprintf('Argument 1 passed to "%s()" must be a string or a connection object, "%s" given.', __METHOD__, \gettype($connection)));
        }

        switch (true) {
            case $connection instanceof Store:
                return $connection;
            case $connection instanceof CacheItemPoolInterface:
                return new Psr6CacheStore($connection);
            case $connection instanceof CacheInterface:
                return new Psr16CacheStore($connection);
            case $connection instanceof \Redis:
            case $connection instanceof \RedisArray:
            case $connection instanceof \RedisCluster:
            case $connection instanceof \Predis\ClientInterface:
            case $connection instanceof RedisProxy:
            case $connection instanceof RedisClusterProxy:
                return new RedisStore($connection);

It seems like $connection can also be of type string; however, parameter $client of Zenstruck\Governator\Store\RedisStore::__construct() does only seem to accept object, maybe add an additional type check?

            case !\is_string($connection):
                throw new \InvalidArgumentException(\sprintf('Unsupported Connection: "%s".', \get_class($connection)));

It seems like $connection can also be of type string; however, parameter $object of get_class() does only seem to accept object, maybe add an additional type check?

            case 'memory' === $connection:
                return new MemoryStore();
            case 'unlimited' === $connection:
                return new UnlimitedStore();
            case 0 === \strpos($connection, 'redis:'):

It seems like $connection can also be of type object; however, parameter $haystack of strpos() does only seem to accept string, maybe add an additional type check?

            case 0 === \strpos($connection, 'rediss:'):
                if (!\class_exists(AbstractAdapter::class)) {
                    throw new \InvalidArgumentException(\sprintf('Unsupported DSN "%s". Try running "composer require symfony/cache".', $connection));

It seems like $connection can also be of type object; however, parameter $args of sprintf() does only seem to accept string, maybe add an additional type check?

                }

                return new RedisStore(AbstractAdapter::createConnection($connection, ['lazy' => true]));

It seems like $connection can also be of type object; however, parameter $dsn of Symfony\Component\Cache\Adapter\AbstractAdapter::createConnection() does only seem to accept string, maybe add an additional type check?

        }

        throw new \InvalidArgumentException(\sprintf('Unsupported Connection: "%s".', $connection));
    }