MakeFactory::interact() - Code Metrics - Inspection of "Adds an 'All' option to factory generation that cr..." - zenstruck/foundry - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#247)

by Kevin

created 2022-02-03 19:13 UTC

MakeFactory::interact() A

↳ Parent: MakeFactory

Complexity

Conditions	4
Paths	5

Size

Total Lines	20
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	5.2596

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
eloc	11
c	3
b	0
f	0
dl	0
loc	20
ccs	8
cts	14
cp	0.5714
rs	9.9
cc	4
nc	5
nop	3
crap	5.2596

<?php

namespace Zenstruck\Foundry\Bundle\Maker;

use Doctrine\ORM\EntityManagerInterface;
use Doctrine\Persistence\ManagerRegistry;
use Symfony\Bundle\MakerBundle\ConsoleStyle;
use Symfony\Bundle\MakerBundle\DependencyBuilder;
use Symfony\Bundle\MakerBundle\Exception\RuntimeCommandException;
use Symfony\Bundle\MakerBundle\Generator;
use Symfony\Bundle\MakerBundle\InputConfiguration;
use Symfony\Bundle\MakerBundle\Maker\AbstractMaker;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Zenstruck\Foundry\ModelFactory;

/**
 * @author Kevin Bond <[email protected]>
 */
final class MakeFactory extends AbstractMaker
{
    private const ORM_DEFAULTS = [
        'ARRAY' => '[],',
        'ASCII_STRING' => 'self::faker()->text(),',
        'BIGINT' => 'self::faker()->randomNumber(),',
        'BLOB' => 'self::faker()->text(),',
        'BOOLEAN' => 'self::faker()->boolean(),',
        'DATE' => 'self::faker()->datetime(),',
        'DATE_MUTABLE' => 'self::faker()->datetime(),',
        'DATE_IMMUTABLE' => 'self::faker()->datetime(),',
        'DATETIME_MUTABLE' => 'self::faker()->datetime(),',
        'DATETIME_IMMUTABLE' => 'self::faker()->datetime(),',
        'DATETIMETZ_MUTABLE' => 'self::faker()->datetime(),',
        'DATETIMETZ_IMMUTABLE' => 'self::faker()->datetime(),',
        'DECIMAL' => 'self::faker()->randomFloat(),',
        'FLOAT' => 'self::faker()->randomFloat(),',
        'INTEGER' => 'self::faker()->randomNumber(),',
        'JSON' => '[],',
        'JSON_ARRAY' => '[],',
        'SIMPLE_ARRAY' => '[],',
        'SMALLINT' => 'self::faker()->numberBetween(1, 32767),',
        'STRING' => 'self::faker()->text(),',
        'TEXT' => 'self::faker()->text(),',
        'TIME_MUTABLE' => 'self::faker()->datetime(),',
        'TIME_IMMUTABLE' => 'self::faker()->datetime(),',
    ];

    /** @var ManagerRegistry */
    private $managerRegistry;

    /** @var string[] */
    private $entitiesWithFactories;

    public function __construct(ManagerRegistry $managerRegistry, \Traversable $factories)
    {
        $this->managerRegistry = $managerRegistry;
        $this->entitiesWithFactories = \array_map(
            static function(ModelFactory $factory) {
                return $factory::getEntityClass();
            },
            \iterator_to_array($factories)
        );
    }

    public static function getCommandName(): string
    {
        return 'make:factory';
    }

    public static function getCommandDescription(): string
    {
        return 'Creates a Foundry model factory for a Doctrine entity class';
    }

    public function configureDependencies(DependencyBuilder $dependencies): void
    {
        // noop
    }

    public function configureCommand(Command $command, InputConfiguration $inputConfig): void
    {
        $command
            ->setDescription(self::getCommandDescription())
            ->addArgument('entity', InputArgument::OPTIONAL, 'Entity class to create a factory for')
            ->addOption('namespace', null, InputOption::VALUE_REQUIRED, 'Customize the namespace for generated factories', 'Factory')
            ->addOption('test', null, InputOption::VALUE_NONE, 'Create in <fg=yellow>tests/</> instead of <fg=yellow>src/</>')
            ->addOption('all-fields', null, InputOption::VALUE_NONE, 'Create defaults for all entity fields, not only required fields')
        ;

        $inputConfig->setArgumentAsNonInteractive('entity');
    }

    public function interact(InputInterface $input, ConsoleStyle $io, Command $command): void
    {
        if ($input->getArgument('entity')) {
            return;
        }

        if (!$input->getOption('test')) {
            $io->text('// Note: pass <fg=yellow>--test</> if you want to generate factories in your <fg=yellow>tests/</> directory');
            $io->newLine();
        }

        if (!$input->getOption('all-fields')) {
            $io->text('// Note: pass <fg=yellow>--all-fields</> if you want to generate default values for all fields, not only required fields');
            $io->newLine();
        }

        $argument = $command->getDefinition()->getArgument('entity');
        $entity = $io->choice($argument->getDescription(), \array_merge($this->entityChoices(), ['All']));

        $input->setArgument('entity', $entity);
    }

    public function generate(InputInterface $input, ConsoleStyle $io, Generator $generator): void
    {
        $entity = $input->getArgument('entity');
        $classes = 'All' === $entity ? $this->entityChoices() : [$entity];

        foreach ($classes as $class) {
            $this->generateFactory($class, $input, $io, $generator);
        }
    }

    /**
     * Generates a single entity factory.
     */
    private function generateFactory(string $class, InputInterface $input, ConsoleStyle $io, Generator $generator)
    {
        if (!\class_exists($class)) {
            $class = $generator->createClassNameDetails($class, 'Entity\\')->getFullName();
        }

        if (!\class_exists($class)) {
            throw new RuntimeCommandException(\sprintf('Entity "%s" not found.', $input->getArgument('entity')));
        }

        $namespace = $input->getOption('namespace');

        // strip maker's root namespace if set
        if (0 === \mb_strpos($namespace, $generator->getRootNamespace())) {
            $namespace = \mb_substr($namespace, \mb_strlen($generator->getRootNamespace()));
        }

        $namespace = \trim($namespace, '\\');

        // if creating in tests dir, ensure namespace prefixed with Tests\
        if ($input->getOption('test') && 0 !== \mb_strpos($namespace, 'Tests\\')) {
            $namespace = 'Tests\\'.$namespace;
        }

        $entity = new \ReflectionClass($class);
        $factory = $generator->createClassNameDetails($entity->getShortName(), $namespace, 'Factory');

        $repository = new \ReflectionClass($this->managerRegistry->getRepository($entity->getName()));

        if (0 !== \mb_strpos($repository->getName(), $generator->getRootNamespace())) {
            // not using a custom repository
            $repository = null;
        }

        $generator->generateClass(
            $factory->getFullName(),
            __DIR__.'/../Resources/skeleton/Factory.tpl.php',
            [
                'entity' => $entity,
                'defaultProperties' => $this->defaultPropertiesFor($entity->getName(), $input->getOption('all-fields')),
                'repository' => $repository,
            ]
        );

        $generator->writeChanges();

        $this->writeSuccessMessage($io);

        $io->text([
            'Next: Open your new factory and set default values/states.',
            'Find the documentation at https://symfony.com/bundles/ZenstruckFoundryBundle/current/index.html#model-factories',
        ]);
    }

    private function entityChoices(): array
    {
        $choices = [];

        foreach ($this->managerRegistry->getManagers() as $manager) {
            foreach ($manager->getMetadataFactory()->getAllMetadata() as $metadata) {
                if ($metadata->getReflectionClass()->isAbstract()) {
                    continue;
                }
                if (!\in_array($metadata->getName(), $this->entitiesWithFactories, true)) {
                    $choices[] = $metadata->getName();
                }
            }
        }

        \sort($choices);

        if (empty($choices)) {
            throw new RuntimeCommandException('No entities or documents found, or none left to make factories for.');
        }

        return $choices;
    }

    private function defaultPropertiesFor(string $class, bool $allFields): iterable
    {
        $em = $this->managerRegistry->getManagerForClass($class);

        if (!$em instanceof EntityManagerInterface) {
            return [];
        }

        $metadata = $em->getClassMetadata($class);
        $ids = $metadata->getIdentifierFieldNames();

        foreach ($metadata->fieldMappings as $property) {
            // ignore identifiers and nullable fields
            if ((!$allFields && ($property['nullable'] ?? false)) || \in_array($property['fieldName'], $ids, true)) {
                continue;
            }

            $type = \mb_strtoupper($property['type']);
            $value = "null, // TODO add {$type} ORM type manually";

            if (\array_key_exists($type, self::ORM_DEFAULTS)) {
                $value = self::ORM_DEFAULTS[$type];
            }

            yield $property['fieldName'] => $value;
        }
    }
}


1		<?php
2
3		namespace Zenstruck\Foundry\Bundle\Maker;
4
5		use Doctrine\ORM\EntityManagerInterface;
6		use Doctrine\Persistence\ManagerRegistry;
7		use Symfony\Bundle\MakerBundle\ConsoleStyle;
8		use Symfony\Bundle\MakerBundle\DependencyBuilder;
9		use Symfony\Bundle\MakerBundle\Exception\RuntimeCommandException;
10		use Symfony\Bundle\MakerBundle\Generator;
11		use Symfony\Bundle\MakerBundle\InputConfiguration;
12		use Symfony\Bundle\MakerBundle\Maker\AbstractMaker;
13		use Symfony\Component\Console\Command\Command;
14		use Symfony\Component\Console\Input\InputArgument;
15		use Symfony\Component\Console\Input\InputInterface;
16		use Symfony\Component\Console\Input\InputOption;
17		use Zenstruck\Foundry\ModelFactory;
18
19		/**
20		* @author Kevin Bond <[email protected]>
21		*/
22		final class MakeFactory extends AbstractMaker
23		{
24		private const ORM_DEFAULTS = [
25	20	'ARRAY' => '[],',
26		'ASCII_STRING' => 'self::faker()->text(),',
27	20	'BIGINT' => 'self::faker()->randomNumber(),',
28	20	'BLOB' => 'self::faker()->text(),',
29		'BOOLEAN' => 'self::faker()->boolean(),',
30	4	'DATE' => 'self::faker()->datetime(),',
31		'DATE_MUTABLE' => 'self::faker()->datetime(),',
32	4	'DATE_IMMUTABLE' => 'self::faker()->datetime(),',
33		'DATETIME_MUTABLE' => 'self::faker()->datetime(),',
34		'DATETIME_IMMUTABLE' => 'self::faker()->datetime(),',
35	20	'DATETIMETZ_MUTABLE' => 'self::faker()->datetime(),',
36		'DATETIMETZ_IMMUTABLE' => 'self::faker()->datetime(),',
37		'DECIMAL' => 'self::faker()->randomFloat(),',
38	20	'FLOAT' => 'self::faker()->randomFloat(),',
39	20	'INTEGER' => 'self::faker()->randomNumber(),',
40	20	'JSON' => '[],',
41		'JSON_ARRAY' => '[],',
42		'SIMPLE_ARRAY' => '[],',
43	20	'SMALLINT' => 'self::faker()->numberBetween(1, 32767),',
44	20	'STRING' => 'self::faker()->text(),',
45		'TEXT' => 'self::faker()->text(),',
46	20	'TIME_MUTABLE' => 'self::faker()->datetime(),',
47		'TIME_IMMUTABLE' => 'self::faker()->datetime(),',
48	20	];
49	12
50		/** @var ManagerRegistry */
51		private $managerRegistry;
52	8
53	4	/** @var string[] */
54	4	private $entitiesWithFactories;
55
56		public function __construct(ManagerRegistry $managerRegistry, \Traversable $factories)
57	8	{
58	8	$this->managerRegistry = $managerRegistry;
59		$this->entitiesWithFactories = \array_map(
60	8	static function(ModelFactory $factory) {
61	8	return $factory::getEntityClass();
62		},
63	20	\iterator_to_array($factories)
64		);
65	20	}
66
67	20	public static function getCommandName(): string
68	4	{
69		return 'make:factory';
70		}
71	20
72	4	public static function getCommandDescription(): string
73		{
74		return 'Creates a Foundry model factory for a Doctrine entity class';
75	16	}
76	16
77	16	public function configureDependencies(DependencyBuilder $dependencies): void
78	16	{
79	16	// noop
80		}
81
82	16	public function configureCommand(Command $command, InputConfiguration $inputConfig): void
83		{
84	16	$command
85		->setDescription(self::getCommandDescription())
86	16	->addArgument('entity', InputArgument::OPTIONAL, 'Entity class to create a factory for')
87		->addOption('namespace', null, InputOption::VALUE_REQUIRED, 'Customize the namespace for generated factories', 'Factory')
88		->addOption('test', null, InputOption::VALUE_NONE, 'Create in <fg=yellow>tests/</> instead of <fg=yellow>src/</>')
89	16	->addOption('all-fields', null, InputOption::VALUE_NONE, 'Create defaults for all entity fields, not only required fields')
90	16	;
91	16
92		$inputConfig->setArgumentAsNonInteractive('entity');
93	16	}
94	16
95		public function interact(InputInterface $input, ConsoleStyle $io, Command $command): void
96		{
97		if ($input->getArgument('entity')) {
98	16	return;
99		}
100	16
101		if (!$input->getOption('test')) {
102	16	$io->text('// Note: pass <fg=yellow>--test</> if you want to generate factories in your <fg=yellow>tests/</> directory');
103	16	$io->newLine();
104		}
105
106	16	if (!$input->getOption('all-fields')) {
107		$io->text('// Note: pass <fg=yellow>--all-fields</> if you want to generate default values for all fields, not only required fields');
108	20	$io->newLine();
109		}
110
111	20	$argument = $command->getDefinition()->getArgument('entity');
112		$entity = $io->choice($argument->getDescription(), \array_merge($this->entityChoices(), ['All']));
113	8
114		$input->setArgument('entity', $entity);
115	8	}
116
117	8	public function generate(InputInterface $input, ConsoleStyle $io, Generator $generator): void
118	8	{
119	8	$entity = $input->getArgument('entity');
120		$classes = 'All' === $entity ? $this->entityChoices() : [$entity];
121
122		foreach ($classes as $class) {
123	8	$this->generateFactory($class, $input, $io, $generator);
124		}
125	8	}
126
127		/**
128		* Generates a single entity factory.
129		*/
130		private function generateFactory(string $class, InputInterface $input, ConsoleStyle $io, Generator $generator)
131		{
132		if (!\class_exists($class)) {
133		$class = $generator->createClassNameDetails($class, 'Entity\\')->getFullName();
134		}
135
136		if (!\class_exists($class)) {
137		throw new RuntimeCommandException(\sprintf('Entity "%s" not found.', $input->getArgument('entity')));
138		}
139
140		$namespace = $input->getOption('namespace');
141
142		// strip maker's root namespace if set
143		if (0 === \mb_strpos($namespace, $generator->getRootNamespace())) {
144		$namespace = \mb_substr($namespace, \mb_strlen($generator->getRootNamespace()));
145		}
146
147		$namespace = \trim($namespace, '\\');
148
149		// if creating in tests dir, ensure namespace prefixed with Tests\
150		if ($input->getOption('test') && 0 !== \mb_strpos($namespace, 'Tests\\')) {
151		$namespace = 'Tests\\'.$namespace;
152		}
153
154		$entity = new \ReflectionClass($class);
155		$factory = $generator->createClassNameDetails($entity->getShortName(), $namespace, 'Factory');
156
157		$repository = new \ReflectionClass($this->managerRegistry->getRepository($entity->getName()));
158
159		if (0 !== \mb_strpos($repository->getName(), $generator->getRootNamespace())) {
160		// not using a custom repository
161		$repository = null;
162		}
163
164		$generator->generateClass(
165		$factory->getFullName(),
166		__DIR__.'/../Resources/skeleton/Factory.tpl.php',
167		[
168		'entity' => $entity,
169		'defaultProperties' => $this->defaultPropertiesFor($entity->getName(), $input->getOption('all-fields')),
170		'repository' => $repository,
171		]
172		);
173
174		$generator->writeChanges();
175
176		$this->writeSuccessMessage($io);
177
178		$io->text([
179		'Next: Open your new factory and set default values/states.',
180		'Find the documentation at https://symfony.com/bundles/ZenstruckFoundryBundle/current/index.html#model-factories',
181		]);
182		}
183
184		private function entityChoices(): array
185		{
186		$choices = [];
187
188		foreach ($this->managerRegistry->getManagers() as $manager) {
189		foreach ($manager->getMetadataFactory()->getAllMetadata() as $metadata) {
190		if ($metadata->getReflectionClass()->isAbstract()) {
191		continue;
192		}
193		if (!\in_array($metadata->getName(), $this->entitiesWithFactories, true)) {
194		$choices[] = $metadata->getName();
195		}
196		}
197		}
198
199		\sort($choices);
200
201		if (empty($choices)) {
202		throw new RuntimeCommandException('No entities or documents found, or none left to make factories for.');
203		}
204
205		return $choices;
206		}
207
208		private function defaultPropertiesFor(string $class, bool $allFields): iterable
209		{
210		$em = $this->managerRegistry->getManagerForClass($class);
211
212		if (!$em instanceof EntityManagerInterface) {
213		return [];
214		}
215
216		$metadata = $em->getClassMetadata($class);
217		$ids = $metadata->getIdentifierFieldNames();
218
219		foreach ($metadata->fieldMappings as $property) {
220		// ignore identifiers and nullable fields
221		if ((!$allFields && ($property['nullable'] ?? false)) \|\| \in_array($property['fieldName'], $ids, true)) {
222		continue;
223		}
224
225		$type = \mb_strtoupper($property['type']);
226		$value = "null, // TODO add {$type} ORM type manually";
227
228		if (\array_key_exists($type, self::ORM_DEFAULTS)) {
229		$value = self::ORM_DEFAULTS[$type];
230		}
231
232		yield $property['fieldName'] => $value;
233		}
234		}
235		}
236

zenstruck / foundry

Pull Request — master (#247)

MakeFactory::interact() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like