FactoryCollection::__construct() - Code Metrics - Inspection of "[feature] add FactoryCollection object to help wit..." - zenstruck/foundry - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 60e688...e7b848 )

by Kevin

created 2020-10-08 13:37 UTC

FactoryCollection::__construct() A

↳ Parent: FactoryCollection

Complexity

Conditions	3
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
eloc	5
c	1
b	0
f	1
dl	0
loc	9
rs	10
ccs	6
cts	6
cp	1
cc	3
nc	2
nop	3
crap	3

<?php

namespace Zenstruck\Foundry;

/**
 * @author Kevin Bond <[email protected]>
 */
final class FactoryCollection
{
    /** @var Factory */
    private $factory;

    /** @var int */
    private $min;

    /** @var int */
    private $max;

    /**
     * @param int|null $max If set, when created, the collection will be a random size between $min and $max
     */
    public function __construct(Factory $factory, int $min, ?int $max = null)
    {
        if ($max && $min > $max) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            throw new \InvalidArgumentException('Min must be less than max.');
        }

        $this->factory = $factory;
        $this->min = $min;
        $this->max = $max ?? $min;
    }

    /**
     * @param array|callable $attributes
     *
     * @return Proxy[]|object[]
     */
    public function create($attributes = []): array
    {
        return \array_map(
            static function(Factory $factory) use ($attributes) {
                return $factory->create($attributes);
            },
            $this->all()
        );
    }

    /**
     * @return Factory[]
     */
    public function all(): array
    {
        return \array_map(
            function() {
                return clone $this->factory;
            },
            \array_fill(0, \random_int($this->min, $this->max), null)
        );
    }

    public function factory(): Factory
    {
        return $this->factory;
    }
}


1		<?php
2
3		namespace Zenstruck\Foundry;
4
5		/**
6		* @author Kevin Bond <[email protected]>
7		*/
8		final class FactoryCollection
9		{
10		/** @var Factory */
11		private $factory;
12
13		/** @var int */
14		private $min;
15
16		/** @var int */
17		private $max;
18
19		/**
20		* @param int\|null $max If set, when created, the collection will be a random size between $min and $max
21		*/
22	100	public function __construct(Factory $factory, int $min, ?int $max = null)
23		{
24	100	if ($max && $min > $max) {
		0 ignored issues – show Bug Best Practice introduced 2020-09-28 20:02 UTC by Report Bug Copy Issue Report The expression `$max` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be 0. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
25	4	throw new \InvalidArgumentException('Min must be less than max.');
26		}
27
28	96	$this->factory = $factory;
29	96	$this->min = $min;
30	96	$this->max = $max ?? $min;
31	96	}
32
33		/**
34		* @param array\|callable $attributes
35		*
36		* @return Proxy[]\|object[]
37		*/
38	80	public function create($attributes = []): array
39		{
40	80	return \array_map(
41		static function(Factory $factory) use ($attributes) {
42	80	return $factory->create($attributes);
43	80	},
44	80	$this->all()
45		);
46		}
47
48		/**
49		* @return Factory[]
50		*/
51	96	public function all(): array
52		{
53	96	return \array_map(
54		function() {
55	96	return clone $this->factory;
56	96	},
57	96	\array_fill(0, \random_int($this->min, $this->max), null)
58		);
59		}
60
61	20	public function factory(): Factory
62		{
63	20	return $this->factory;
64		}
65		}
66

zenstruck / foundry

Push — master ( 60e688...e7b848 )

FactoryCollection::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like