RepositoryProxyTest.php$3 ➔ objectRepositoryWithoutFindOneByOrderBy() - Code Metrics - Inspection of "Merge pull request #66 from kbond/repository-proxy..." - zenstruck/foundry - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 1c4364...e333d7 )

by Kevin

created 2020-10-21 17:01 UTC

php$3 ➔ objectRepositoryWithoutFindOneByOrderBy() B

↳ Parent: RepositoryProxyTest

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	87
rs	8.2836
cc	1

20 Methods

Rating	Name	Size	Complexity
A	RepositoryProxyTest.php$3 ➔ find()	2	1
A	RepositoryProxyTest.php$2 ➔ findBy()	2	1
A	RepositoryProxyTest.php$2 ➔ findOneBy()	2	1
A	RepositoryProxyTest.php$1 ➔ getClassName()	2	1
A	RepositoryProxyTest.php$3 ➔ getClassName()	2	1
A	RepositoryProxyTest.php$1 ➔ find()	2	1
A	RepositoryProxyTest.php$0 ➔ getClassName()	2	1
A	RepositoryProxyTest.php$0 ➔ findOneBy()	2	1
A	RepositoryProxyTest.php$2 ➔ getClassName()	2	1
A	RepositoryProxyTest.php$0 ➔ findAll()	2	1
A	RepositoryProxyTest.php$3 ➔ findOneBy()	2	1
A	RepositoryProxyTest.php$2 ➔ findAll()	2	1
A	RepositoryProxyTest.php$1 ➔ findOneBy()	2	1
A	RepositoryProxyTest.php$3 ➔ findBy()	2	1
A	RepositoryProxyTest.php$2 ➔ find()	2	1
A	RepositoryProxyTest.php$1 ➔ findBy()	2	1
A	RepositoryProxyTest.php$0 ➔ find()	2	1
A	RepositoryProxyTest.php$0 ➔ findBy()	2	1
A	RepositoryProxyTest.php$1 ➔ findAll()	2	1
A	RepositoryProxyTest.php$3 ➔ findAll()	2	1

How to fix Long Method

<?php

namespace Zenstruck\Foundry\Tests\Unit;

use Doctrine\Persistence\ObjectRepository;
use PHPUnit\Framework\TestCase;
use Zenstruck\Foundry\RepositoryProxy;

/**
 * @author Kevin Bond <[email protected]>
 */
final class RepositoryProxyTest extends TestCase
{
    /**
     * @test
     * @dataProvider objectRepositoryWithoutFindOneByOrderBy
     */
    public function calling_find_one_by_with_order_by_when_wrapped_repo_does_not_have_throws_exception(ObjectRepository $inner): void
    {
        $proxy = new RepositoryProxy($inner);

        $this->expectException(\RuntimeException::class);

        $proxy->findOneBy([], ['id' => 'DESC']);
    }

    public static function objectRepositoryWithoutFindOneByOrderBy(): iterable
    {
        yield [new RepositoryProxy(new class() implements ObjectRepository {
            public function find($id)
            {
            }

            public function findAll()
            {
            }

            public function findBy(array $criteria, ?array $orderBy = null, $limit = null, $offset = null)
            {
            }

            public function findOneBy(array $criteria)
            {
            }

            public function getClassName()
            {
            }
        })];

        yield [new RepositoryProxy(new class() implements ObjectRepository {
            public function find($id)
            {
            }

            public function findAll()
            {
            }

            public function findBy(array $criteria, ?array $orderBy = null, $limit = null, $offset = null)
            {
            }

            public function findOneBy(array $criteria, ?array $foo = null)
            {
            }

            public function getClassName()
            {
            }
        })];

        yield [new RepositoryProxy(new class() implements ObjectRepository {
            public function find($id)
            {
            }

            public function findAll()
            {
            }

            public function findBy(array $criteria, ?array $orderBy = null, $limit = null, $offset = null)
            {
            }

            public function findOneBy(array $criteria, $orderBy = null)
            {
            }

            public function getClassName()
            {
            }
        })];

        yield [new RepositoryProxy(new class() implements ObjectRepository {
            public function find($id)
            {
            }

            public function findAll()
            {
            }

            public function findBy(array $criteria, ?array $orderBy = null, $limit = null, $offset = null)
            {
            }

            public function findOneBy(array $criteria, ?string $orderBy = null)
            {
            }

            public function getClassName()
            {
            }
        })];
    }
}


1			<?php
2
3			namespace Zenstruck\Foundry\Tests\Unit;
4
5			use Doctrine\Persistence\ObjectRepository;
6			use PHPUnit\Framework\TestCase;
7			use Zenstruck\Foundry\RepositoryProxy;
8
9			/**
10			* @author Kevin Bond <[email protected]>
11			*/
12			final class RepositoryProxyTest extends TestCase
13			{
14			/**
15			* @test
16			* @dataProvider objectRepositoryWithoutFindOneByOrderBy
17			*/
18			public function calling_find_one_by_with_order_by_when_wrapped_repo_does_not_have_throws_exception(ObjectRepository $inner): void
19			{
20			$proxy = new RepositoryProxy($inner);
21
22			$this->expectException(\RuntimeException::class);
23
24			$proxy->findOneBy([], ['id' => 'DESC']);
25			}
26
27			public static function objectRepositoryWithoutFindOneByOrderBy(): iterable
28			{
29			yield [new RepositoryProxy(new class() implements ObjectRepository {
30			public function find($id)
31			{
32			}
33
34			public function findAll()
35			{
36			}
37
38			public function findBy(array $criteria, ?array $orderBy = null, $limit = null, $offset = null)
39			{
40			}
41
42			public function findOneBy(array $criteria)
43			{
44			}
45
46			public function getClassName()
47			{
48			}
49			})];
50
51			yield [new RepositoryProxy(new class() implements ObjectRepository {
52			public function find($id)
53			{
54			}
55
56			public function findAll()
57			{
58			}
59
60			public function findBy(array $criteria, ?array $orderBy = null, $limit = null, $offset = null)
61			{
62			}
63
64			public function findOneBy(array $criteria, ?array $foo = null)
65			{
66			}
67
68			public function getClassName()
69			{
70			}
71			})];
72
73			yield [new RepositoryProxy(new class() implements ObjectRepository {
74			public function find($id)
75			{
76			}
77
78			public function findAll()
79			{
80			}
81
82			public function findBy(array $criteria, ?array $orderBy = null, $limit = null, $offset = null)
83			{
84			}
85
86			public function findOneBy(array $criteria, $orderBy = null)
87			{
88			}
89
90			public function getClassName()
91			{
92			}
93			})];
94
95			yield [new RepositoryProxy(new class() implements ObjectRepository {
96			public function find($id)
97			{
98			}
99
100			public function findAll()
101			{
102			}
103
104			public function findBy(array $criteria, ?array $orderBy = null, $limit = null, $offset = null)
105			{
106			}
107
108			public function findOneBy(array $criteria, ?string $orderBy = null)
109			{
110			}
111
112			public function getClassName()
113			{
114			}
115			})];
116			}
117			}
118

zenstruck / foundry

Push — master ( 1c4364...e333d7 )

php$3 ➔ objectRepositoryWithoutFindOneByOrderBy() B

Complexity

Size

Duplication

Importance

20 Methods

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like