CallbackTest::invoke_with_not_enough_required_arguments() - Code Metrics - Inspection of "[feature] access callback arguments, support PHP 8..." - zenstruck/callback - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Pull Request — 1.x (#2)

by Kevin
created 2021-07-14 20:28 UTC
invoke_with_not_enough_required_arguments() A

↳ Parent: CallbackTest
Complexity

Conditions	1
Paths	1
Size

Total Lines	14
Code Lines	10
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	1
eloc	10
nc	1
nop	0
dl	0
loc	14
rs	9.9332
c	0
b	0
f	0
<?php

namespace Zenstruck\Callback\Tests;

use PHPUnit\Framework\TestCase;
use Zenstruck\Callback;
use Zenstruck\Callback\Argument;
use Zenstruck\Callback\Exception\UnresolveableArgument;
use Zenstruck\Callback\Parameter;

/**
 * @author Kevin Bond <[email protected]>
 */
final class CallbackTest extends TestCase
{
    /**
     * @test
     */
    public function create_must_be_callable(): void
    {
        $this->expectException(\InvalidArgumentException::class);

        Callback::createFor('not a callable');
    }

    /**
     * @test
     */
    public function invoke_all_can_enforce_min_arguments(): void
    {
        $callback = Callback::createFor(function() { return 'ret'; });

        $this->expectException(\ArgumentCountError::class);

        $callback->invokeAll(Parameter::untyped('foo'), 1);
    }

    /**
     * @test
     */
    public function invoke_all_with_no_arguments(): void
    {
        $actual = Callback::createFor(function() { return 'ret'; })
            ->invokeAll(Parameter::untyped('foo'))
        ;

        $this->assertSame('ret', $actual);
    }

    /**
     * @test
     */
    public function invoke_all_with_string_callable(): void
    {
        $actual = Callback::createFor('strtoupper')
            ->invokeAll(Parameter::union(
                Parameter::untyped('foobar'),
                Parameter::typed('string', 'foobar')
            )
        )
        ;

        $this->assertSame('FOOBAR', $actual);
    }

    /**
     * @test
     */
    public function invoke_all_untyped_argument(): void
    {
        $actual = Callback::createFor(function($string) { return \mb_strtoupper($string); })
            ->invokeAll(Parameter::untyped('foobar'))
        ;

        $this->assertSame('FOOBAR', $actual);
    }

    /**
     * @test
     */
    public function invoke_all_primitive_typed_argument(): void
    {
        $actual = Callback::createFor(function(string $string) { return \mb_strtoupper($string); })
            ->invokeAll(Parameter::typed('string', 'foobar'))
        ;

        $this->assertSame('FOOBAR', $actual);
    }

    /**
     * @test
     */
    public function invoke_all_class_arguments(): void
    {
        $object = new Object2();
        $function = static function(Object1 $object1, Object2 $object2, $object3) {
            return [
                'object1' => $object1,
                'object2' => $object2,
                'object3' => $object3,
            ];
        };

        $actual = Callback::createFor($function)
            ->invokeAll(Parameter::union(
                Parameter::untyped($object),
                Parameter::typed(Object1::class, $object)
            ))
        ;

        $this->assertSame(
            [
                'object1' => $object,
                'object2' => $object,
                'object3' => $object,
            ],
            $actual
        );
    }

    /**
     * @test
     */
    public function invoke_all_class_arguments_value_factories(): void
    {
        $function = static function(Object1 $object1, Object2 $object2, $object3) {
            return [
                'object1' => $object1,
                'object2' => $object2,
                'object3' => $object3,
            ];
        };
        $factoryArgs = [];
        $factory = Parameter::factory(static function($arg) use (&$factoryArgs) {
            $factoryArgs[] = $arg;

            if ($arg) {
                return new $arg();
            }

            return new Object1();
        });

        $ret = Callback::createFor($function)
            ->invokeAll(Parameter::union(
                Parameter::untyped($factory),
                Parameter::typed(Object1::class, $factory)
            ))
        ;

        $this->assertSame(['object1', 'object2', 'object3'], \array_keys($ret));
        $this->assertInstanceOf(Object1::class, $ret['object1']);
        $this->assertInstanceOf(Object2::class, $ret['object2']);
        $this->assertInstanceOf(Object1::class, $ret['object3']);
        $this->assertSame(
            [Object1::class, Object2::class, null],
            $factoryArgs
        );
    }

    /**
     * @test
     */
    public function invoke_all_unresolvable_parameter(): void
    {
        $callback = Callback::createFor(static function(Object1 $object1, Object2 $object2, Object3 $object3) {});
        $callback = Callback::createFor(static function(Object1 $object1, Object2 $object2, /** @scrutinizer ignore-unused */ Object3 $object3) {});

        $this->expectException(UnresolveableArgument::class);
        $this->expectExceptionMessage('Unable to resolve argument 3 for callback. Expected type: "mixed|Zenstruck\Callback\Tests\Object1"');

        $callback->invokeAll(Parameter::union(
            Parameter::untyped(new Object1()),
            Parameter::typed(Object1::class, new Object1())
        ));
    }

    /**
     * @test
     */
    public function invoke_with_no_args(): void
    {
        $actual = Callback::createFor(function() { return 'ret'; })
            ->invoke()
        ;

        $this->assertSame('ret', $actual);
    }

    /**
     * @test
     */
    public function invoke_with_resolvable_args(): void
    {
        $object = new Object2();
        $function = static function(Object1 $object1, Object2 $object2, $object3, $extra) {
            return [
                'object1' => $object1,
                'object2' => $object2,
                'object3' => $object3,
                'extra' => $extra,
            ];
        };

        $actual = Callback::createFor($function)
            ->invoke(
                Parameter::typed(Object1::class, $object),
                Parameter::typed(Object2::class, $object),
                Parameter::untyped($object),
                'value'
            )
        ;

        $this->assertSame(
            [
                'object1' => $object,
                'object2' => $object,
                'object3' => $object,
                'extra' => 'value',
            ],
            $actual
        );
    }

    /**
     * @test
     */
    public function invoke_with_unresolvable_argument(): void
    {
        $object = new Object2();
        $function = static function(Object1 $object1, $object2, $object3, $extra) {};
        $function = static function(Object1 $object1, /** @scrutinizer ignore-unused */ $object2, $object3, $extra) {};

        $this->expectException(UnresolveableArgument::class);
        $this->expectExceptionMessage('Unable to resolve argument 2 for callback. Expected type: "Zenstruck\Callback\Tests\Object2"');

        Callback::createFor($function)
            ->invoke(
                Parameter::typed(Object1::class, $object),
                Parameter::typed(Object2::class, $object),
                Parameter::untyped($object),
                'value'
            )
        ;
    }

    /**
     * @test
     */
    public function invoke_with_not_enough_required_arguments(): void
    {
        $object = new Object2();
        $function = static function(Object1 $object1) {};
        $function = static function(/** @scrutinizer ignore-unused */ Object1 $object1) {};

        $this->expectException(\ArgumentCountError::class);
        $this->expectExceptionMessage('No argument 2 for callable. Expected type: "Zenstruck\Callback\Tests\Object2"');

        Callback::createFor($function)
            ->invoke(
                Parameter::typed(Object1::class, $object),
                Parameter::typed(Object2::class, $object),
                Parameter::untyped($object),
                'value'
            )
        ;
    }

    /**
     * @test
     */
    public function can_mark_invoke_parameter_arguments_as_optional(): void
    {
        $actual = Callback::createFor(static function() { return 'ret'; })
            ->invoke(Parameter::typed('string', 'foobar')->optional())
        ;

        $this->assertSame('ret', $actual);

        $actual = Callback::createFor(static function(string $v) { return $v; })
            ->invoke(Parameter::typed('string', 'foobar')->optional())
        ;

        $this->assertSame('foobar', $actual);
    }

    /**
     * @test
     */
    public function is_stringable(): void
    {
        $this->assertStringMatchesFormat(__CLASS__.':%d', (string) Callback::createFor(function() {}));
        $this->assertStringMatchesFormat(__CLASS__.':%d', (string) Callback::createFor([$this, __METHOD__]));
        $this->assertStringMatchesFormat(Object4::class.':%d', (string) Callback::createFor(new Object4()));
        $this->assertStringMatchesFormat(Object4::class.':%d', (string) Callback::createFor([Object4::class, 'staticMethod']));
        $this->assertSame(__NAMESPACE__.'\test_function', (string) Callback::createFor(__NAMESPACE__.'\test_function'));
    }

    /**
     * @test
     * @requires PHP >= 8.0
     */
    public function invoke_can_support_union_typehints(): void
    {
        $callback = fn(Object1|string $arg) => 'ret';
        $callback = fn(/** @scrutinizer ignore-unused */ Object1|string $arg) => 'ret';

        $this->assertSame('ret', Callback::createFor($callback)->invokeAll(Parameter::typed(Object1::class, new Object1())));
        $this->assertSame('ret', Callback::createFor($callback)->invokeAll(Parameter::typed('string', 'value')));
        $this->assertSame('ret', Callback::createFor($callback)->invoke(Parameter::typed(Object1::class, new Object1())));
        $this->assertSame('ret', Callback::createFor($callback)->invoke(Parameter::typed('string', 'value')));
    }

    /**
     * @test
     */
    public function can_get_callback_arguments(): void
    {
        $callback = Callback::createFor(function(Object1 $a, $b, string $c) {});
        $callback = Callback::createFor(function(/** @scrutinizer ignore-unused */ Object1 $a, $b, string $c) {});

        $this->assertSame(Object1::class, $callback->argument(0)->type());
        $this->assertNull($callback->argument(1)->type());
        $this->assertSame('string', $callback->argument(2)->type());
        $this->assertSame(
            [
                Object1::class,
                null,
                'string',
            ],
            \array_map(function(Argument $a) { return $a->type(); }, $callback->arguments())
        );
    }

    /**
     * @test
     * @requires PHP >= 8.0
     */
    public function can_get_union_callback_arguments(): void
    {
        $callback = Callback::createFor(fn(Object1|string $a, $b, string $c) => null);
        $callback = Callback::createFor(fn(/** @scrutinizer ignore-unused */ Object1|string $a, $b, string $c) => null);

        $this->assertSame(Object1::class.'|string', $callback->argument(0)->type());
        $this->assertNull($callback->argument(1)->type());
        $this->assertSame('string', $callback->argument(2)->type());
        $this->assertSame(
            [
                Object1::class.'|string',
                null,
                'string',
            ],
            \array_map(function(Argument $a) { return $a->type(); }, $callback->arguments())
        );
    }

    /**
     * @test
     */
    public function exception_thrown_when_trying_to_access_invalid_argument(): void
    {
        $this->expectException(\OutOfRangeException::class);

        Callback::createFor(function() {})->argument(0);
    }

    /**
     * @test
     */
    public function value_factory_injects_argument_if_type_hinted(): void
    {
        $callback = Callback::createFor(function(string $a, int $b, $c) { return [$a, $b, $c]; });
        $factory = Parameter::factory(function(Argument $argument) {
            if ($argument->supports('string')) {
                return 'string';
            }

            if ($argument->supports('int')) {
                return 17;
            }

            return 'invalid';
        });

        $ret = $callback->invokeAll(
            Parameter::union(
                Parameter::typed('string', $factory),
                Parameter::typed('int', $factory),
                Parameter::untyped($factory)
            )
        );

        $this->assertSame(['string', 17, 'string'], $ret);
    }

    /**
     * @test
     */
    public function can_use_value_factory_with_no_argument(): void
    {
        $ret = Callback::createFor(function($value) { return $value; })
            ->invoke(Parameter::untyped(Parameter::factory(function() { return 'value'; })))
        ;

        $this->assertSame('value', $ret);
    }

    /**
     * @test
     * @requires PHP >= 8.0
     */
    public function value_factory_can_be_used_with_union_arguments_if_no_value_factory_argument(): void
    {
        $ret = Callback::createFor(fn(Object1|string $a) => $a)
            ->invoke(Parameter::typed('string', Parameter::factory(fn() => 'value')))
        ;

        $this->assertSame('value', $ret);
    }

    /**
     * @test
     * @requires PHP >= 8.0
     */
    public function value_factory_can_be_used_with_union_arguments_as_array(): void
    {
        $array = [];
        $factory = Parameter::factory(function(array $types) use (&$array) {
            $array = $types;

            return 'value';
        });

        $ret = Callback::createFor(fn(Object1|string $a) => $a)
            ->invoke(Parameter::typed('string', $factory))
        ;

        $this->assertSame('value', $ret);
        $this->assertSame([Object1::class, 'string'], $array);
    }

    /**
     * @test
     * @requires PHP >= 8.0
     */
    public function value_factory_cannot_accept_union_argument(): void
    {
        $this->expectException(\LogicException::class);

        Callback::createFor(fn(Object1|string $a) => $a)
            ->invoke(Parameter::typed('string', Parameter::factory(fn(string $type) => $type)))
        ;
    }
}

class Object1
{
}

class Object2 extends Object1
{
}

class Object3
{
}

class Object4
{
    public function __invoke()
    {
    }

    public static function staticMethod()
    {
    }
}

function test_function()
{
}

zenstruck / callback

Pull Request — 1.x (#2)

invoke_with_not_enough_required_arguments() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like
