zenstruck / browser

tests/KernelBrowserTests.php

<?php

namespace Zenstruck\Browser\Tests;

use Symfony\Component\Security\Core\User\InMemoryUser;
use Zenstruck\Browser\KernelBrowser;
use Zenstruck\Browser\Tests\Fixture\Kernel;

/**
 * @author Kevin Bond <kevinbond@gmail.com>
 */
trait KernelBrowserTests
{
    use BrowserKitBrowserTests;

    /**
     * @test
     */
    public function can_use_kernel_browser_as_typehint(): void
    {
        $this->browser()
            ->use(function(KernelBrowser $browser) {
                $browser->visit('/redirect1');
            })
            ->assertOn('/page1')
        ;
    }

    /**
     * @test
     */
    public function can_act_as_user(): void
    {
        if (!Kernel::securityEnabled()) {
            $this->markTestSkipped('Only enable security-related tests in 5.3+');

It seems like markTestSkipped() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        $this->browser()
            ->throwExceptions()
            ->actingAs(new InMemoryUser('kevin', 'pass'))
            ->visit('/user')
            ->assertSee('user: kevin/pass')
        ;
    }

    /**
     * @test
     */
    public function can_enable_exception_throwing(): void
    {
        $this->expectException(\Exception::class);

It seems like expectException() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->expectExceptionMessage('exception thrown');

It seems like expectExceptionMessage() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->browser()
            ->throwExceptions()
            ->visit('/exception')
        ;
    }

    /**
     * @test
     */
    public function can_re_enable_catching_exceptions(): void
    {
        $browser = $this->browser();

        try {
            $browser->throwExceptions()->visit('/exception');
        } catch (\Exception $e) {
            $browser
                ->catchExceptions()
                ->visit('/exception')
                ->assertStatus(500)
            ;

            return;
        }

        $this->fail('Exception was not caught.');

It seems like fail() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @test
     */
    public function can_enable_the_profiler(): void
    {
        $profile = $this->browser()
            ->withProfiling()
            ->visit('/page1')
            ->profile()
        ;

        $this->assertTrue($profile->hasCollector('request'));

The method assertTrue() does not exist on Zenstruck\Browser\Tests\KernelBrowserTests. Did you maybe mean assert_on()?

    }

    protected function browser(): KernelBrowser
    {
        return $this->kernelBrowser();
    }
}