| Conditions | 10 |
| Paths | 1 |
| Total Lines | 58 |
| Code Lines | 29 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 24 | protected function browser(): HttpBrowser |
||
| 25 | { |
||
| 26 | $browser = HttpBrowser::create(function() { |
||
| 27 | $class = $_SERVER['HTTP_BROWSER_CLASS'] ?? HttpBrowser::class; |
||
| 28 | |||
| 29 | if (!\is_a($class, HttpBrowser::class, true)) { |
||
| 30 | throw new \RuntimeException(\sprintf('"HTTP_BROWSER_CLASS" env variable must reference a class that extends %s.', HttpBrowser::class)); |
||
| 31 | } |
||
| 32 | |||
| 33 | $baseUri = $_SERVER['HTTP_BROWSER_URI'] ?? null; |
||
| 34 | |||
| 35 | if (!$baseUri && !$this instanceof PantherTestCase) { |
||
| 36 | throw new \RuntimeException(\sprintf('If not using "HTTP_BROWSER_URI", your TestCase must extend "%s".', PantherTestCase::class)); |
||
| 37 | } |
||
| 38 | |||
| 39 | if (!$baseUri) { |
||
| 40 | self::startWebServer(); |
||
| 41 | |||
| 42 | $baseUri = self::$baseUri; |
||
| 43 | } |
||
| 44 | |||
| 45 | // copied from PantherTestCaseTrait::createHttpBrowserClient() |
||
| 46 | $client = new HttpBrowserClient(); |
||
| 47 | $urlComponents = \parse_url($baseUri); |
||
| 48 | $host = $urlComponents['host']; |
||
| 49 | |||
| 50 | if (isset($urlComponents['port'])) { |
||
| 51 | $host .= ":{$urlComponents['port']}"; |
||
| 52 | } |
||
| 53 | |||
| 54 | $client->setServerParameter('HTTP_HOST', $host); |
||
| 55 | |||
| 56 | if ('https' === ($urlComponents['scheme'] ?? 'http')) { |
||
| 57 | $client->setServerParameter('HTTPS', 'true'); |
||
| 58 | } |
||
| 59 | |||
| 60 | /** @var HttpBrowser $browser */ |
||
| 61 | $browser = new $class(self::$httpBrowserClients[] = $client); |
||
| 62 | |||
| 63 | if (!$this instanceof KernelTestCase) { |
||
| 64 | return $browser; |
||
| 65 | } |
||
| 66 | |||
| 67 | if (!static::$booted) { |
||
|
|
|||
| 68 | static::bootKernel(); |
||
| 69 | } |
||
| 70 | |||
| 71 | if (static::$container->has('profiler')) { |
||
| 72 | $browser->setProfiler(static::$container->get('profiler')); |
||
| 73 | } |
||
| 74 | |||
| 75 | return $browser; |
||
| 76 | }); |
||
| 77 | |||
| 78 | BrowserExtension::registerBrowser($browser); |
||
| 79 | |||
| 80 | return $browser |
||
| 81 | ->setSourceDir($_SERVER['BROWSER_SOURCE_DIR'] ?? './var/browser/source') |
||
| 82 | ; |
||
| 85 |